Summary:
Replace two wrapping PlasmaCore.SortFilterModel with custom sorting on model side. Extract common code to base class.
This fixes small issue in sorting and allows to implement other improvements (later on).
Test Plan: Everything should work as before.
Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Reviewed By: #plasma_workspaces, #plasma, davidedmundson, ngraham
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27088
Summary:
Activity runner is now useless:
m_activities is always nullptr in ActivityRunner::run because ActivityRunner::down is called after ActivityRunner::match which makes activity changing impossible
Reviewers: broulik, ngraham, davidedmundson
Reviewed By: ngraham, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27367
Summary:
If for some reason a service is started before StartServiceJob runs, we
will end up blocking forever.
Test Plan: Logged in
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27471
Summary:
BUG: 417747
FIXED-IN: 5.18.1
Test Plan:
Better default size when showing the most info: {F8107763}
However window is too now big when showing the least amount of info: {F8107762}
...But that seems kind of unavoidable unless we want to dynamically resize the window,
which people seem to hate.
Reviewers: #plasma, #vdg, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27448
Summary:
When having expanded System Tray once, plasmashell crashes on teardown.
Fixes regression introduced in D27085.
BUG: 417552
FIXED-IN: 5.19.0
Test Plan:
1. Start plasmashell
2. Open System Tray popup, close it again
3. run kquitapp5 plasmashell, it should not crash
Reviewers: #plasma_workspaces, #plasma, broulik, ngraham
Reviewed By: ngraham
Subscribers: anthonyfieroni, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27401
Summary:
Instead of loading the model and then showing the last shown image, we can show
it early so that we signal "wallpaper.loading = false" earlier.
CCBUG: 371455
Test Plan: Have massive slideshow, login
Reviewers: davidedmundson, broulik, #plasma
Reviewed By: davidedmundson, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27084
Avoids repeatedly resizing the dialog when copying many files.
It will still resize when the speed label comes and goes but at least when copying many tiny files it won't be as obnoxious.
BUG: 417489
FIXED-IN: 5.18.1
Differential Revision: https://phabricator.kde.org/D27344
Summary:
VirtualDesktopInfo::Private is ref counted and shared between N
VirtualDesktopInfo's.
We were passing the first VirtualDesktopInfo as a parent to
VirtualDesktopInfo::Private which didn't manage the lifespan or do
anything useful.
The wayland backend incorrectly used this 'q' object and spanned
mulitple internal objects and connections to the first object that
created the shared private instance, leaving us with dangly objects
inside.
BUG: 415200
(and possibly several other bugs of wayland task manager not updating
correctly)
Test Plan:
Compiles
Plasma still loads
Reviewers: #plasma, zzag
Reviewed By: #plasma, zzag
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27266
Summary: According to Qt docs, QUuid() creates a null UUID object.
Test Plan: N/A, plasmashell is very unstable with Qt 5.15.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27237
Summary:
plasma.kde.org doesn't exist anymore and causes the appstream test to
to fail.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27304
Summary:
The urls were changed from http to https in the test's source files
with 6d6d3c5b3e but not in the json test
files.
Test Plan: Built fine and the test passed with a clean build dir
Reviewers: #plasma, yurchor
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27281
Summary: Equivalent of dbus-update-activation-environment but in runtime
Test Plan:
Changed cursor theme (with some additional fixes there)
Checked the systemd env via the property on manager1.
It had changed
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27054
Summary:
We use this centered style in many other places and are moving towards using it
everywhere. This patch applies the same style to the System Tray popups for
notifications and devices, which were still using the old style.
Test Plan:
Notifications, before: {F8090822}
Notifications, after: {F8090777}
Device Notifier: before: {F8090825}
Device Notifier, after: {F8090776}
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: davidedmundson, ndavis, trmdi, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27219
Summary:
Also drop the prefix and use the KDE_INSTALL_FULL.. variant for an
absolute path (similar to logo=${KDE_INSTALL_FULL_DATADIR}...).
Test Plan:
Checked that the path of the background image is the same as
before.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27241
Summary:
Since D10835 opening urls that needed mimetype determination such as smb:/ or sftp:/ urls were always opened with a "Open With" dialog.
To keep the same security but adding some convenience, use KRun::setRunExecutables to disable executable run here.
Reviewers: #plasma, broulik, aleksejshilin, hein
Reviewed By: #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26582
Summary:
Few unrelated fixes, bunched together:
* move some code from main.qml to PlasmoidItem where it belongs
* easier to understand item size calculation
* where possible, replace parent.parent comparisons with a property in AbstractItem
* get rid of marginHints
* Qt 5.14 compatibility fix in configuration
* formatting etc
Test Plan: Everything should work as before, this is just refactoring.
Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27085
Konrad Materka
Nate Graham
Oleg Solovyov
Cyril Rossi
Jonathan Riddell
David Edmundson
Luca Beltrame
Aleix Pol
Yuri Chornoivan
l10n daemon script
David Redondo
Albert Astals Cid
Kai Uwe Broulik
Vlad Zahorodnii
Heiko Becker
Méven Car
Marco Martin