Summary:
The previous patch updates the pinned state only for the active applet. For instance, if you open the Networks applet and pin it, then switch to the Clipboard applet and click on the history item, then the Clipboard applet closes. This is because we need to use binding instead of assignment.
See https://phabricator.kde.org/D28408.
Reviewers: ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28483
Test Plan:
make && ctest
klipper still seems to work
Reviewers: #plasma, davidedmundson, apol, broulik
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27914
Summary:
When I pin a Klipper widget and then click on a history item, the Klipper widget closes.
To fix this bug, we need to check if Klipped is pinned, but to be able to do this, we also need to "forward" the pinned state from the SystemTray applet to the Klipper applet.
BUG: 416510
FIXED-IN: 5.19.0
Reviewers: ngraham, #plasma
Reviewed By: ngraham
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28408
GHNS Quick Button signals changedEntriesChanged initially even if nothing changed.
While this is a bug that should be fixed in GHNS, the wallpaper model didn't handle the case well,
when the model was reloaded while a preview was being generated.
It looks up whether a preview exists by QUrl and stores a QPersistentModelIndex.
However, when the model is reloaded and it accesses data for the same QUrl, the job might still be in-flight,
but the QPersistentModelIndex is invalid as the model has been reset.
This fixes it by performing all lookups exclusively on QPersistentModelIndex.
The hash lookup is optimized for data() (loads of accesses) with the slower key() lookup being done only
when the less frequently occurring thumbnail generation finishes/fails.
It will now do two preview jobs initially, but at least it shows something again...
BUG: 419234
FIXED-IN: 5.18.4
Differential Revision: https://phabricator.kde.org/D28420
Summary:
I noticed that on the first time I bring up the calendar by clicking the clock on my Plasma panel, it always shows "No event for today". If I click another day on the calendar and then click back on today, it shows today's events fine. It should display it correctly the first time.
To fix this bug, we need to compare the date without time.
BUG: 395956
FIXED-IN: 5.19.0
Reviewers: ngraham, #plasma, vkrause
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28354
Summary: Still included dcop, hadn't been compiled in years I presume.
Test Plan: All good and normal
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28385
Summary:
It's possible to have a .desktop file in your recent documents list as
you were editing it. Either as a .desktop file or masquerading as
something else.
By default we would process the .desktop file like a .desktop file.
You do get a prompt if the .desktop file is not executable like in
dolphin.
Given we know from context that we're showing recent "Documents" we may
as well turn that behaviour off without risk of ill effects.
BUG: 419310
Test Plan:
Created .desktop file (masquerading as something else)
Had it in my recent documents after opening in another format
Loaded the file from krunner. It now opened in my text editor instead of running
the Exec line
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28369
Summary:
Else the entry is still in cfg_shownItems/cfg_hiddenItems and the config UI will display it as shown instead of disabled.
BUG: 419197
Reviewers: #plasma, kmaterka, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28311
Summary:
It was safeguarded by an environment variable so we don't retroactively
change behaviour of existing setups in a bugfix update.
See https://phabricator.kde.org/D27883
Test Plan: Compiles
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28300
Summary: When none of the valid conditions are met, function should return default value for ItemLoader source. If not, error is printed in logs.
Test Plan: No warning about undefined value for url
Reviewers: #plasma_workspaces, #plasma, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28259
Summary: This change simplifies icon size logic - now it is controled only in one place: AbstractItem. This gives additional benefits, like icons perfectly centered.
Test Plan: Highlights should always be centered
Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, apol
Reviewed By: #plasma_workspaces, #plasma, ngraham, broulik
Subscribers: mart, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28109
Summary:
This patch fixes several errors in the code:
- The property is named `font.minimumPixelSize`, not `minimumPixelSize`
- The calculation in `minimumPixelSize` did not make sense
- Setting the height to `dateLabel.paintedHeight` is nonsensical
BUG: 417852
FIXED-IN: 5.18.4
Test Plan: {F8186873}
Reviewers: #vdg, #plasma, cblack, davidedmundson
Reviewed By: #vdg, #plasma, cblack, davidedmundson
Subscribers: davidedmundson, cblack, muesli, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28172
Summary:
The foreach has been refactored and the loadSyntaxes method gets now called directly.
Additionally the cached (failed) key/provider can be reused for multiple sessions and is only cleared when the config changes.
Test Plan: Should compile and open urls as before.
Reviewers: ngraham, broulik, meven, apol
Reviewed By: broulik, meven
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27566
Rather than relying on KWin to have reconfigured, which isn't the case when merely changing the number of rows.
BUG: 408783
FIXED-IN: 5.18.4
Differential Revision: https://phabricator.kde.org/D28216
Summary:
The Pin buttons in the System Tray and Clock pop-ups are very small. This has
always felt slightly odd to me, and the recent change to add a defined header
area for the System Tray pop-up makes it even odder in my opinion, as the icon
is now much smaller than the area it visibly inhabits. This patch makes both icons
in both applets use the standard size with no local overrides. The clock pop-up's
pin button is ported to PC3 in the process.
Depends on D28228
Test Plan:
Before: {F8194101}
After: {F8194100}
Reviewers: #vdg, #plasma, ognarb, mart
Reviewed By: #vdg, #plasma, ognarb, mart
Subscribers: mart, ndavis, broulik, ognarb, plasma-devel
Tags: #plasma
Maniphest Tasks: T10470
Differential Revision: https://phabricator.kde.org/D28211
Summary:
This patch allows you to switch the timezone by clicking on your desired one in the
applet's expanded representation. This is much simpler than the mouse-wheel-based UI and
does not need a config setting to turn it on or off.
Test Plan: {F8183863}
Reviewers: #vdg, #plasma, jriddell, cblack
Reviewed By: #vdg, #plasma, cblack
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T9222
Differential Revision: https://phabricator.kde.org/D28133
Summary:
The ShellConfig class has been deleted. This config class was in KDE4 for the runOptions widget used and the class/the settings are not used anymore.
Additionally the context type check has been removed, because this is already solved using the ignore types.
Futhermore the match icon and the list of actions can be reused.
Test Plan: Should compile and execute shell commands as before.
Reviewers: davidedmundson, ngraham, broulik, meven, #plasma
Reviewed By: meven
Subscribers: meven, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27495
Summary:
We have an unstable test.
KCoreDirLister has a timer involved set to 200ms
QTRY_VERIFY will fire when we have one change from the spy, but maybe
not everything if we explicitly wait and process maybe it will improve
things?
It's a bit of a random shot-in the dark.
Test Plan: Passes locally..but it always passed locally before
Reviewers: #plasma, kmaterka
Reviewed By: kmaterka
Subscribers: kmaterka, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28183
Summary: The `effectiveStatus` parameter was passed as a copy, use proper binding.
Test Plan: No visible impact
Reviewers: #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, apol
Reviewed By: ngraham
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28185
Summary:
build the runner itself in a static lib we can use for testing and then
link that into a module lib together with the factory entry point to
compose the final lib for installation
means servicesrunner.cpp is now only built once, whereas before it was
built twice through 100% duplicative targets
Test Plan: test still passes, installing and restarting krunner still yields working service searches
Reviewers: broulik, davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28137
Summary:
This patch ports the appmenu applet to use
libtaskmanager.
Test Plan: Ensure that there aren't any regressions.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28146
Fixes issues that flew under the radar in D27959, namely:
- Missing KWindowInfo flags
- Returning service name instead of object path
Reviewed-By: kbroulik
Summary:
The tasks model now exposes a window's application menu object path and service name.
No update signals set up for XOrg; not sure what to listen for.
Test Plan:
See that the model has more roles and see that they're wired to the application
menu obiect path and service name on Wayland and XOrg.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27959
Summary:
- be more consty (and don't risk detatching containers)
- init members
- don't ql1s to qstring
- use auto when newing an object
Test Plan: test passes
Reviewers: broulik
Reviewed By: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28138
Summary:
Various people were complaining that the calendar was too squished after D27903. This
patch restores its size to be closer to the old version. As a consequence, the whole
expanded representation is quite large now, but there really is no other way.
Test Plan:
Before: {F8181551}
After: {F8181550}
Reviewers: #vdg, broulik, mart, cblack
Reviewed By: #vdg, cblack
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28104
Ahmad Samir
Niccolò Venerandi
Kai Uwe Broulik
Eugene Popov
Jonathan Riddell
l10n daemon script
Aleix Pol
David Edmundson
Nate Graham
Nicolas Fella
Konrad Materka
Alexander Lohnau
Yuri Chornoivan
Harald Sitter
Carson Black
Laurent Montel