Summary:
The Clipboard and Notifications applets live in plasma-workspace; port them to use
Kirigami.PlaceholderMessage
Test Plan:
Clipboard: {F8253980}
Notifications: {F8253981}
Reviewers: #vdg, #plasma, broulik, niccolove, cblack
Reviewed By: #vdg, #plasma, niccolove, cblack
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T13021
Differential Revision: https://phabricator.kde.org/D29109
Summary: "ksmserver" is not a good user visible string.
Test Plan: check in global shortcuts kcm
Reviewers: ngraham, #plasma, #vdg, davidedmundson
Reviewed By: ngraham, #plasma, #vdg, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29058
Summary:
Is there a better way to report error from this code than the dialog box
that KRun used to pop up (and KDialogJobUiDelegate does too)?
Test Plan: Untested.
Reviewers: davidedmundson, sitter, broulik
Reviewed By: broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28988
Summary:
This patch implements part of the mockup at T10470 by putting the power management
checkbox and settings button in a heading area visually connected to the titlebar.
In the process, I fixed a problem with the power management checkbox to make the layout's
spacing work: the checkbox now has text of its own, instead of living in a mouse area
with a separate label.
Test Plan:
{F8254807}
{F8254808}
Reviewers: #vdg, #plasma, broulik, niccolove, manueljlin
Reviewed By: #vdg, manueljlin
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T10470
Differential Revision: https://phabricator.kde.org/D29116
Summary:
Before: A pointer to the favicon gets written in the BookmarkMatch and using this pointer the icon gets created when the Plasma::QueryMatch gets created.
Now: Using the favicon pointer the icon gets created and written to the BookmarkMatch, when the QueryMatch is created the icon value is read.
This makes the code easier to understand and the BookmarkMatch is independent of the Favicon class.
Test Plan: Should compile and display icons.
Reviewers: apol, broulik, davidedmundson
Reviewed By: davidedmundson
Subscribers: bruns, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28439
Summary: And use KNotificationJobUiDelegate in case of errors
Test Plan: Untested other than compilation
Reviewers: broulik, davidedmundson
Reviewed By: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29124
Summary:
Somehow the notification pop-up's positioning has never felt quite right to me. When it's
in a bottom corner, it blocks the view of the latest messages in chat apps, or the text
I'm searching for in Kate. When it's in a top corner, it blocks part of the open app's
toolbar or tab bar that I often use. The best place I've found for is in the top-middle,
which doesn't block very many of the thing I'm active using, and its centered position
feels aesthetically pleasing. I've been using this for a bit and quite like it.
However there is ony deficiency: the pop-up is not very wide, so it becomes quite tall
when displaying multi-line messages from chat apps in particular, which makes the
notification stack intrude into the middle of the screen where it definitely blocks things
you want to be looking at. This is annoying.
This patch resolves that issue by making the pop-up's size wider and the spacing between
pop-ups smaller when the pop-ups are positioned in the top or bottom middle.
Test Plan:
Centered pop-ups now look like this:
Single pop-up: {F8247020}
Stack of pop-ups: {F8247025}
There is no visual change for pop-ups in the corner, where they are by default.
Reviewers: #vdg, #plasma, broulik, ndavis, cblack, bshah
Reviewed By: #vdg, #plasma, broulik, ndavis, cblack, bshah
Subscribers: bshah, IlyaBizyaev, ndavis, cblack, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28989
Summary: Some applications, e.g. pamac, don't send an app_name, which is legal according to the fd.o spec. In this case try to read it from the desktop file before falling back to the process name.
Test Plan: I get a better appname for pamac notifications now
Reviewers: #plasma, broulik, mart
Reviewed By: #plasma, mart
Subscribers: crossi, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27786
Summary:
As per D28575, converted the FullRepr to be a Page and added a PlasmoidHeading
Result:
{F8215954}
Depends on D28575
Test Plan: Test with D28575
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: ngraham, plasma-devel
Tags: #plasma
Maniphest Tasks: T10470
Differential Revision: https://phabricator.kde.org/D28576
Test Plan:
Before, no clocks: {F8246116}
After, no clocks: {F8246114}
[Now the vertical spacing between labels matches other tooltips]
Before, some clocks: {F8246113}
After, some clocks: {F8246115}
[Now the full date is displayed on the first line instead of being split across two]
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28970
We don't show icons on tooltips anymore.
And the System Tray config doesn't show images.
BUG: 420197
FIXED-IN: 5.19.0
Differential Revision: https://phabricator.kde.org/D28917
Regression introduced in 6e660cf92d since it's now a URL with a scheme, e.g. "applications".
Service actions cannot be dragged out but that wasn't the case before either I believe.
Differential Revision: https://phabricator.kde.org/D28907
While at it, also remove some unused related includes that are likely remnant from before
this was all done centrally in TaskTools
Differential Revision: https://phabricator.kde.org/D28906
Summary:
It was pointed out to me that using NoDisplay=true breaks starting
krunner.
Alternatively D24956 could be landed.
Test Plan: Still works for me, for some reason
Reviewers: #plasma, fvogt
Reviewed By: fvogt
Subscribers: fvogt, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28853
Summary:
When the applet is a page with a plasmoidHeading as header, merge it with systray one.
{F8215920}
The only big problem is that it looks bad when you open said applet while in sidebar view, see:
{F8215916}
I'd like to solve that by removing the sidebar and adding a back button, but that would be for another patch in the future.
Test Plan: To be tested together with D28467
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: mart, manueljlin, ognarb, ngraham, plasma-devel
Tags: #plasma
Maniphest Tasks: T10470
Differential Revision: https://phabricator.kde.org/D28575
Summary:
Tell the parent Dialog class what the location is so it can configure
the dialog accordingly.
Install the desktop file where it can be found by kwin to know about
X-KDE-Wayland-Interfaces=org_kde_plasma_window_management.
While at it, make sure we don't leak if we return early.
Test Plan: Now I get the right animation
Reviewers: #plasma, cblack, davidedmundson
Reviewed By: #plasma, cblack, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28783
QML needs it on the model it uses (Notifications) where they used to be but GammaRay seems to be taking them from the source (NotificationsModel).
This has both models (and jobs model) return the roleNames() and moves them to Utils so they're shared.
Differential Revision: https://phabricator.kde.org/D28657
This mutates the source array.
In practice actions don't really change in existing notifications but still better to not do that.
Differential Revision: https://phabricator.kde.org/D28650
Summary:
The media controller has been adjusted visually. Note that this is marked as WIP due to the fact that the system tray displays margins around the applet, which doesn't look too good.
Co-authored-by: Ismael Asensio <isma.af@gmail.com>
Depends on D28089
Test Plan:
Before:
{F8085938}
After:
{F8089034}
Reviewers: #vdg, #plasma, manueljlin, ngraham, broulik!
Reviewed By: #vdg, #plasma, ngraham
Subscribers: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel
Tags: #plasma
Maniphest Tasks: T10470
Differential Revision: https://phabricator.kde.org/D27160
Summary: As we don't launch with kinit, no point ksmserver linking against it
Test Plan: Compiles
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28676
Summary:
plasma-session goes to great lengths to make sure we have the latest env
vars from kcminit in future spawned jobs.
However one part got broke in some refactor, we capture the system
environment when we make the job, not when we're about to launch.
This means potentially kded5 and ksmserver wouldn't have the envs
kcminit set.
I've not noticed any practical impact from this.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28626
This ensures that newer notification popups don't push old ones out.
Some applications are notorious for spamming the user which right now results in a firework
of notification popups. With this patch only the number that fits on screen is displayed and
everything beyond that is off screen until there's enough room for new popups which are
then gradually lowered.
It also reduces the likelihood of the notification the user is interacting with being shifted
away by an incoming notification. Furthermore, since notifications that are off screen will
have their timeout reset, it can happen that you have a bunch of recent notifications at the
bottom but then get some old ones that were off screen sliding back in because some middle ones
have expired already, leading to awkward results.
Notification scoring (e.g. critical before normal) is untouched, so a "battery is critical" notification
will show up even if it's still chugging through the backlog of browser notifications.
Differential Revision: https://phabricator.kde.org/D28646
Summary:
It was decided in T12778 to remove icons from tooltips for panel widgets and system tray
items. This patch implements that for system tray items, and removes the supporting code
from the backend.
Test Plan:
Apply patch
Hover the cursor over system tray items, either in the compat applet or the expanded
representation
No more redundant or inconsistent icons visible
Reviewers: #plasma, davidre, broulik, kmaterka
Reviewed By: kmaterka
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T12778
Differential Revision: https://phabricator.kde.org/D28631
Summary:
launchersOrder and the actual url data can be different:
in case of preferred:/ urls launcherorder will have that for
(for serialization) and the actual appdata url will be decoded as for
instance Applications:firefox.desktop.
this url is the one that needs to be compared to know the actual
launcher order
BUG:418483
Test Plan: firefox stays in first position when pinned as preferred://browser
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28632
Summary:
launchersOrder and the actual url data can be different:
in case of preferred:/ urls launcherorder will have that for
(for serialization) and the actual appdata url will be decoded as for
instance Applications:firefox.desktop.
this url is the one that needs to be compared to know the actual
launcher order
BUG:418483
Test Plan: firefox stays in first position when pinned as preferred://browser
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28632
Use ApplicationLauncherJob and CommandLauncherJob.
Also, for services runner pass a KServiceAction to the job so it invokes the appropriate jump list action
Differential Revision: https://phabricator.kde.org/D28347
Summary:
To increase consistency and reduce redundancy, widget tooltip icons are being removed
in D27847 and D27848, per discussion in T12778. This patch makes the Digital Clock
consistent what that initiative, since it has a custom tooltip.
Test Plan:
{F8150016}
{F8150021}
Reviewers: #vdg, #plasma, niccolove
Reviewed By: niccolove
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T12778
Differential Revision: https://phabricator.kde.org/D27849
Summary:
After D28144, some animations are now too long because they were inappropriately
multiplying a duration value. That's no longer necessary, so let's remove the
multiplication.
Depends on D28144
Test Plan: Various things that were a bit too slow before feel just right now
Reviewers: #vdg, #plasma, cblack
Reviewed By: #vdg, #plasma, cblack
Subscribers: cblack, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28238
Summary:
We are krunner, our default config will be krunnerrc, we can load the
instance we've already loaded in the QPT instead of doing it again.
Reviewers: #plasma, apol, broulik
Reviewed By: #plasma, apol, broulik
Subscribers: apol, plasma-devel
CCBUG: 416145
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28368
Niccolò Venerandi
Nate Graham
David Redondo
David Faure
Alexander Lohnau
Cyril Rossi
l10n daemon script
Nicolas Fella
Kai Uwe Broulik
Benjamin Port
Aleix Pol
Carson Black
David Edmundson
Marco Martin