If we have this feature now, let's use it and give the wallpaper authors the credit they deserve rather than being tucked away in the tooltip.
Differential Revision: https://phabricator.kde.org/D26531
Makes it more obvious that there is an inline reply rather than having a "Reply" button where the user must guess what it'll do.
Differential Revision: https://phabricator.kde.org/D26796
Summary:
Applications which set `Qt::AA_EnableHighDpiScaling` use the DPI of the monitor the window is on to calculate an additional scaling factor.
Plasma sets `QT_SCREEN_SCALE_FACTORS` in the environment for manual specification of per-monitor scale, which combined with the automatic scaling may result in double scaling.
To disable the automatic scaling, `QT_AUTO_SCREEN_SCALE_FACTOR=0` has to be set, even on Qt 5.14.
As a side effect, this works around QTBUG-80967 as well.
BUG: 415421
Test Plan: On X11, with a >144dpi monitor and a scaling factor of 2 set manually, scaling was doubled previously. Now it works as expected.
Reviewers: #plasma, apol, davidedmundson, fvogt
Reviewed By: #plasma, davidedmundson, fvogt
Subscribers: acooligan, fvogt, asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26185
Plasma Browser Integration provides controls for Chrome, so when a player with kde:pid metadata is found, it is preferred over the actual pid it represents.
Differential Revision: https://phabricator.kde.org/D26702
Summary:
Before loading the view, query all plasma processes and show why they're using
KUserFeedback.
Depends on D26569
Test Plan: Manual testing
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: ngraham, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26570
Summary:
- Correct the destination path when downloading images.
- Switch from FileCopyJob to CopyJob to allow showing file overwrite dialog.
BUG: 379469
Test Plan: Drop files from Firefox to the desktop to set the wallpaper successfully.
Reviewers: #plasma, mart, ngraham
Reviewed By: #plasma, mart, ngraham
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26525
Summary:
Combines settings of SNI icons and plasmoids in one list. Ability to disable whole section is removed.
Initial idea was proposed by Nicolas Fella (D22176).
BUG: 360307
FIXED-IN: 5.18.0
{F7880936}
Test Plan:
1. Disable/enable plasmoids
2. Set Shown/Hidden for plasmoid
3. Set shortcut for plasmoid
4. Previously hidden categories are shown
5. Show all icons and revert
6. Set Auto/Shown/Hidden for SNI icons
Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, mart
Reviewed By: #plasma_workspaces, #plasma, ngraham, mart
Subscribers: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26586
Summary:
sddm-greeter will have a button for the reveal password button, but due
to sddm-greeter not loading a relevant QPT has no code to force it to
load the breeze icon set.
Without the breeze icon set, the clear button does not show.
There are ways to solve this, but none are trivial or reliable.
I threatened to do a revert in 5.12 (https://phabricator.kde.org/D9040)
but the bug has still not been fixed since.
BUG: 396039
CCBUG: 387418
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26675
Summary:
If the kcm's property changes externally we don't update the slider
after the initial load, which is before KConfigModule::load which actually sets
the property.
Whilst there is an alternative fix calling load() a second time, we need
this anyway for default and reset buttons to work correctly.
I also think the original code was broken, I don't see why we would map
the value back to modeOptions[idx], we want the slider value to be the
index of the array, not the enum value. They just happen to be the same.
Test Plan: Opened KCM changed it, opened KCM repeat
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26678
Summary:
BUG: 415461
FIXED-IN: 5.18.0
Depends on D26510
Right now when you first change the wallpaper plugin to slideshow, no locations are
pre-configured, so you have to add one yourself. This patch adds a
`preferred:wallpaperlocations` token as the default that gets replaced in the user's
config file at runtime with the XDG wallpaper locations.
Test Plan:
Log in as new user > right-click desktop > configure > change to slideshow wallpaper
See that`/usr/share/wallpapers` is already in the list of wallpaper locations; how nice
Reviewers: #plasma, #vdg, ndavis, davidedmundson
Reviewed By: #plasma, #vdg, ndavis, davidedmundson
Subscribers: davidre, broulik, davidedmundson, ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26483
Summary:
Adjust to the string changes in D26551 and improve the presentation
overall to make it more likely that people will feel comfortable
using it and submitting information.
Depends on D26551
Test Plan: How it looks now: {F7875839}
Reviewers: #vdg, #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26552
Summary:
This switches the image plugin to using KNewStuffQuick instead of
launching the widget dialog through that ol' widget dialog hack.
It further uses the big preview mode by default, which just seems
to make a lot of sense for wallpapers.
Test Plan:
Without: Uses the old dialog
With: Uses the new dialog, as seen below
{F7882885}
Reviewers: mart, #plasma, ngraham
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26665
Summary:
We currently have a mouse-wheel action to switch to the previous/next activity,
but it wasn't possible to assign a global keyboard shortcut to these actions.
As discussed on Phabricator, this doesn't define a default key-sequence yet,
but at least gives users the possibility to assign there own ones, which wasn't
possible before.
Reviewers: apol, davidedmundson, #vdg, #plasma, ngraham
Reviewed By: davidedmundson, #vdg, #plasma, ngraham
Subscribers: ngraham, romangg, ivan, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22382
Creating a KFileItemList with a KFileItem with a URL that doesn't have a scheme triggers an assert in KFileItemListProperties.
It doesn't really make sense to have anyway.
Differential Revision: https://phabricator.kde.org/D26516
Summary: It was reported by Victor Ryzhykh that this patch fixes localization of the wallpaper slideshow config window.
Test Plan:
1. Open the config window in some ~100%-translated locale (ca, pt, sv, uk).
2. All messages should be translated.
Reviewers: #plasma, #localization, ngraham
Reviewed By: ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26584
Summary: Both for plasmoids and SNI
Test Plan: Now there's some kind of feedback when pressing the icons
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: filipf, broulik, anthonyfieroni, davidedmundson, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19947
Summary:
When multiple paths that end in the same folder name are added (for example with D26483),
currently the list shows multiple identical entries distinguished only by their different
tooltips. This patch improves the situation by putting the path to the folder in a
subtitle.
Test Plan:
Before: {F7868784}
After: {F7868785}
Reviewers: #vdg, #plasma, mart
Reviewed By: #vdg, #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26510
Summary: They look a little nicer this way, and can be localized more easily.
Test Plan:
Before: {F7871094, size=full}
After:{F7871093, size=full}
Reviewers: #vdg, #plasma, mart
Reviewed By: #vdg, #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26529
Summary:
Right now, when there are no configured wallpaper slideshow paths or wallpapers in the
slideshow, the list and grid (respectively) are just empty. This patch adds some
placeholder labels to let the user know that it's not broken, just like we do in the
Thunderbolt KCM.
See one `FIXME:` in the code that I could use a hand with.
Test Plan: {F7870947}
Reviewers: #vdg, #plasma, mart
Reviewed By: #vdg, #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26528
Summary:
BUG: 381551
FIXED-IN: 5.18.0
Test Plan:
Before: {F7851382, size=full}
After: {F7851383, size=full}
Texted extensively because this code is so brittle. No regressions with long date in a
thick or normal-sized horizontal panel or short date in a thick or normal-sized
horizontal or vertical panel.
The one issue I could find is that sometimes switching between short and long date
formats in a double-thickness vertical panel causes the long date to be truncated again
until plasmashell is restarted. I was unable to determine why. Assistance would be
appreciated if this is a blocker.
Reviewers: #plasma, #vdg, ndavis
Reviewed By: #vdg, ndavis
Subscribers: ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26312
Summary:
For normal distros it doesn't make sense, KDE_INSTALL_FULL_DATAROOTDIR
will be /usr/.
For devs using a prefix startplasma-dev.sh already does this for us only
for the dev setup.
For any other user, it should be their responsibility to adjust it.
It's currently broken anyway, if a user simply installs flatpak that sets this env
earlier in the boot, so this will do nothing. It implies no-oe relies on thisl
It's a relic from 2007 (bd38d59e11548f160efd0918ca5461536ac72349) that doesn't
make sense now.
BUG: 315452
Test Plan: Compiles
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26537
Vlad Zahorodnii
Cyril Rossi
Méven Car
l10n daemon script
Kai Uwe Broulik
Méven Car
Fabian Vogt
Jonathan Riddell
Aleix Pol
Nate Graham
Tranter Madi
Konrad Materka
David Edmundson
Dan Leinir Turthra Jensen
Christian Muehlhaeuser
Yuri Chornoivan