At the moment we update the clock when we resume from suspend or from
the time KCM.
However the signal from the clock KCM isn't very good as it signals just
after it requests an NTP update or clock change, not necessarily when
that finishes.
Also we miss any external NTP updates which might occur at other times
throughout the day, such as a big change when we connect to the network
This method also avoids needing solid to tell us when we're resuming
from suspend, which is deprecated API and also seems slightly slower.
BUG: 344870
REVIEW: 125028
Energy readings seem quite unreliable - if we only have one battery
it's better just to show the actual percentage which, for whatever reason,
is usually more accurate than energy divided by energyFull.
If the timeout parameter is greater than 0, the notifications server
should honor that setting.
Reviewed-by: Kai Uwe Broulik
BUG: 350164
FIXED-IN: 5.4.0
This contains a temporary fork of the importer, with the main paths
fixed.
The old code spawned a new event loop in the signal QMenu::aboutToShow()
This refetched the menu, even though we had already fetched it, before
calling show.
Spawning new event loops from a QML function, leads to all sorts of
crashes. This
fixes that, and saves some pointless DBus traffic
BUG: 343971
BUG: 345838
BUG: 345933
REVIEW: 123992
According to the UPower specification UPS batteries do not suppliy energy values (Wh)
thus our calculation breaks when there's just an UPS and we start blinking because
we think the total percentage is zero. In case we do have batteries but no energy
just average the percentages. Still not perfect but close enough.
BUG: 348588
FIXED-IN: 5.4.0
This patch makes Plasma always be the Notification service provider if
that option is enabled in the applet settings and/or if the applet is
present somewhere (otherwise the dataengine is not loaded). On startup,
it will get the PID of the current Notifications service, send SIGTERM
to it and register its own service.
REVIEW: 124102
QtQuick's Text with StyledFormat supports only html3.2 subset of stuff.
' is html4 and as such gets removed altogther, which is obviously
unwanted.
Reviewed-by: Kai Uwe Broulik
BUG: 346710
FIXED-IN: 5.3.1
Otherwise there will be a JS exception in the binding causing the battery percentage
to be shown on the screenlocker unconditionally leading to a "0% remaining" on a desktop PC
Use own copy of org.kde.JobView interface file to make it possible to
extend the interface without breaking build.
This also fixes 2 cases where error/errorText would be incorrect in
applicationsjob dataengine.
REVIEW: 123046
Even though the specification makes it perfectly clear that you should
query the notification server and only use supported hints, gnome and
libnotify does not.
Given the specification has changed in a non-compatiable way, this
causes image-data/image-path to break.
This patch supports 1.2 fields
Submitted by: Konstantin
BUG: 344885
Reviewed-by: David Edmundson
Rather than going through the device type enum in reverse where Battery comes second to last
hardcode the order of the device types. Otherwise a device that is both a storage device and
a battery (a phone) will show up as "Battery".
REVIEW: 123256
Modify applicationjobs dataengine so that "error" value
now contains job's error code and "errorText" error message.
This depends on commit 812d0b440e7f08e3acdd1c9bb95779bd871b75b3
to kjobwidgets.
REVIEW: 122928
The service used so far is broken (doesn't resolve latitude and
longitude). Which means we need to switch the service to unbreak.
This change implements support for the Mozilla Location Service [1].
Advantages are:
* free
* open
* supports wifi based locationing
* provided by our FLOSS friends
REVIEW: 122628
[1] https://location.services.mozilla.com/
If there was a vlc engine it got skipped due to a bug in VLC. This
bug seems to be fixed as of VLC 2.1.5 which contains the following
item in the changelog:
"dbus: Upgrade to an mpris2 compliant interface"
Given that the workaround breaks with the fixed VLC (no media control
at all), it's better to drop it and brake VLC installations which
haven't updated for more than half a year.
REVIEW: 122589
Instead of having the media control shortcuts being grouped under
"plasmashell" a dedicated component "Media Controller" is added and all
shortcuts are assigned to it.
This solves the problem if multiple processes include the dataengine, the
shortcuts would be registered in each application.
REVIEW: 122588
l10n daemon script
Igor Poboiko
Yoann Laissus
David Edmundson
Kai Uwe Broulik
Bhushan Shah
Marco Martin
Martin Klapetek
David Edmundson
Luigi Toscano
Burkhard Lück
Eike Hein
Emmanuel Pescosta
David Rosca
Hrvoje Senjan
Martin Gräßlin
Montel Laurent
Jonathan Riddell
Elias Probst