Summary:
Wallpaper plugins were storing their configurations in the same config
group, overwriting each other's values.
Test Plan:
0. Apply revision D11194 (plasma-desktop).
1. Right-click the desktop and click Configure Desktop.
2. Select Wallpaper Type -> Plain Color. Click the chooser button
and select green. Hit Apply.
3. Select Wallpaper Type -> Picture of the Day. Click Background
Color button and select red. Hit Apply.
4. Select Plain Color type again. The color should still be green.
Reviewers: #plasma, mart, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11195
This was an experiment of showing the app menu in a "Menu" submenu but it would complicate
the mapping logic as there's suddenly a menu layer "above" the main menu, so that should
proably go into appmenu applet instead.
Applications could place actions in the main menu bar that do not have a menu.
Also restore the checked binding when clicked to avoid it highlighting even though there is no menu.
This might also fix some spurious highlighting that I've seen when switching between windows.
Differential Revision: https://phabricator.kde.org/D11168
Summary:
As there are only a few QML files in the respective /ui subdir, having the
JS file in the same dir still provides good overview
Test Plan: Applets UI & Config still work as before
Reviewers: #plasma, mart, broulik, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11145
Summary: Used in the minimizeAll plasmoid (see D10019)
Test Plan: Used in applet
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11059
Summary:
Instead of using the action icons to indicate the current state use
the new media playback status icons.
This is an alternative solution to the problem that the mediacontroller applet
icon in the system tray and the play/pause controll in the player are always
the opposite.
While it is still the opposite icon there is now a slight visual difference
to show that these icons mean different things.
This is meant as a solution to the problem discussed in D10032.
{F5741436}
{F5741437}
Reviewers: #plasma, andreask, broulik
Reviewed By: #plasma, andreask, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11056
The window name and user visible name are not used in the app identification heuristic, so a change here cannot result in the icon,
app id, app name, generic name, PID or launcher changing.
Differential Revision: https://phabricator.kde.org/D11096
Summary:
Currently the media controller only works with MPRIS services which support
the PlayPause command. By the MPRIS spec this is an optional feature though.
While most players out there support this, the MPRIS support in Gwenview
currently worked on does not (would need some more rewrite of internals).
Which makes the Media controller applet and/or Gwenview look broken :)
To keep the current design with a central Play/Not Play button, this patch
changes its behaviour depending on the CanPause flag:
CanPause=true -> show either Play or Pause
CanPause=false -> show Play enabled/disabled
Reviewers: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10973
Summary:
* first check CanControl property, as it overrules things
* next check each action Can* property, to spare D-Bus call and app
activation if false
* support CanPause and only call PlayPause is possible,
otherwise use Play
Test Plan:
Vlc can be controlled by keyboard media keys as before,
Gwenview patched to support MPRIS (with CanPause=false) can now be
controlled with the Play/Pause media key.
Reviewers: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10991
Summary:
when the device notifier pops up automatically, leave it open
if there is no user activity, if there is any, close after around
3 seconds. Suspend the countdown if the notifier window either has
focus or the mouse cursor is over it, leaving the user the time to
go interact. if it doesn't have focus and the mouse leaves, resume
the countdown
replaces D10591
Test Plan:
tested for a while in a real world usage, it behaves in a fairly natural
way
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10921
This way we can monitor both appmenu and window menu simultaneously and (theoretically)
switch between one and the other on the fly.
The Menu class is now Window as it encapsulates an entire window with everything that belongs to it.
All DBusMenu-specific code is in Window whereas GMenu-stuff is in Menu and so it's less entangled
CanConvert also happily converts a string to a bool, so explicitly check for type
and for radio buttons we get a string telling us which is the currently checked action
When switching from LibreOffice splash to e.g. Writer, it creates an entirely new
section for us and then replaces the "root" menu with an alias to that new section.
Since we couldn't create new sections in this fashion we would get an alias to a
non-existing menu and break. This addresses this.
appmenu-gtk-module always claims to have a menu even if there is none, so we need to
check that in advance and only write the window property announcing global menu support
if we successfully managed to acquire a menu
l10n daemon script
Алексей Шилин
Friedrich W. H. Kossebau
Kai Uwe Broulik
David Edmundson
Roman Gilg
Jonathan Riddell
Marco Martin