History doesn't use the KlipperPopup at all, it just creates it and
provides it through the ::popup() method. This can also be done by
Klipper directly turning History in a data only class.
Quoting the KIconThemes change that lead to this change:
Revert "Revert "Allow passing custom theme base path together with custom app themes""
This reverts commit 6a75883159bbeb9a9316436d428d2617c3b5fc96.
This was never intended to be pushed, it was a local test for the testcase
in RR119058. Sorry for the mixup.
We're back to good now.
CCMAIL:mklapetek@kde.org
CCMAIL:plasma-devel@kde.org
This is needed to build against KIconThemes 6a75883159bbeb9, which
reverts the commit that adds the path to the addAppDir call. From
looking at the API docs, this *seems* to be the right fix, but I don't
know how to test this properly, so I can't confirm that this actually
works. It builds though, and that's at least a step forward.
If someone can test this, that would be very useful.
CCMAIL:mklapetek@kde.org
CCMAIL:plasma-devel@kde.org
Reviewed-by: Eike Hein on IRC
This reverts commit 30d2489930.
The test results we got indicate that on NVIDIA the problems with the
threaded rendering loop do not exist and at the same time the rendering
result improves a lot. As Qt still disables the threaded rendering loop
for the problematic drivers, it's better to not force the basic rendering
loop.
the scale property is good in theory (and fast) but unfortunately
gives very poor rendering results. it should used only for quick animations
but never for "fixed" elements
BUG:336583
Rename removeDesktop -> removeScreen
Embrace removeScreen as the procedure to disable a screen.
Don't delay destruction of the panels either, the screen could have been
deleted by then.
::shiftViews seemed like a good idea, but it clearly was not. I promise I
was not on drugs when I decided to use it.
Instead, take a recursive alternative, like we did with insertScreen that
will take care about panels and views.
Don't request geometry of disabled outputs.
Set a random screen to a desktop view before destroying it, otherwise it
goes mental.
Fix assert
Improve debug output
when clicking on the plasmoid icon to open or close the popup, save the current open state.
is possible that between mouse down and mouse up the popup has been closed
so don't reopen the popup in this case
CCBUG:336754
We already used to follow it, but we didn't control most use cases.
Now we'll track the position and geometry changes to make sure that when
they change, redundant outputs can stop being redundant.