wilderjds
/
plasma-workspace
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[klipper] Introduce an autotest for History

Browse Source 
There are a few expected fails where the History is not behaving
correctly.
wilder-5.14
Martin Gräßlin 12 years ago
parent 150ebaf2cd
commit 557775562b
3 changed files with 387 additions and 0 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 2
      klipper/CMakeLists.txt
  2. 21
      klipper/autotests/CMakeLists.txt
  3. 364
      klipper/autotests/historytest.cpp

2
klipper/CMakeLists.txt
Unescape View File

@ -66,3 +66,5 @@ install(TARGETS klipper ${INSTALL_TARGETS_DEFAULT_ARGS})
install(PROGRAMS org.kde.klipper.desktop DESTINATION ${XDG_APPS_INSTALL_DIR})
install(PROGRAMS org.kde.klipper.desktop DESTINATION ${AUTOSTART_INSTALL_DIR})
add_subdirectory(autotests)

21
klipper/autotests/CMakeLists.txt
Unescape View File

@ -0,0 +1,21 @@
add_definitions(-DKLIPPER_UNIT_TEST)
include(ECMMarkAsTest)
########################################################
# Test History
########################################################
set(testHistory_SRCS
historytest.cpp
../history.cpp
../historyimageitem.cpp
../historyitem.cpp
../historystringitem.cpp
../historyurlitem.cpp
)
add_executable(testHistory ${testHistory_SRCS})
target_link_libraries(testHistory
Qt5::Test
Qt5::Widgets # QAction
KF5::CoreAddons # KUrlMimeData
)
add_test(klipper-testHistory testHistory)
ecm_mark_as_test(testHistory)

364
klipper/autotests/historytest.cpp
Unescape View File

@ -0,0 +1,364 @@
/********************************************************************
This file is part of the KDE project.
Copyright (C) 2014 Martin Gräßlin <mgraesslin@kde.org>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*********************************************************************/
#include "../history.h"
#include "../historystringitem.h"
// Qt
#include <QtTest/QtTest>
#include <QSignalSpy>
#include <QObject>
class HistoryTest : public QObject
{
Q_OBJECT
private Q_SLOTS:
void testSetMaxSize();
void testInsertRemove();
void testClear();
void testFind();
void testCycle();
};
void HistoryTest::testSetMaxSize()
{
QScopedPointer<History> history(new History(nullptr));
QSignalSpy changedSpy(history.data(), SIGNAL(changed()));
QSignalSpy topSpy(history.data(), SIGNAL(topChanged()));
QVERIFY(history->empty());
QCOMPARE(history->maxSize(), 0u);
QVERIFY(changedSpy.isEmpty());
QVERIFY(topSpy.isEmpty());
// insert an item - should still be empty
history->insert(new HistoryStringItem(QStringLiteral("foo")));
QVERIFY(history->empty());
QEXPECT_FAIL("", "Item is first inserted, then removed, changed signal gets emitted, although not changed", Continue);
QVERIFY(changedSpy.isEmpty());
changedSpy.clear();
QEXPECT_FAIL("", "Item is first inserted, then removed, changed signal gets emitted, although not changed", Continue);
QVERIFY(topSpy.isEmpty());
topSpy.clear();
// now it should insert again
history->setMaxSize(1);
QCOMPARE(history->maxSize(), 1u);
history->insert(new HistoryStringItem(QStringLiteral("foo")));
QVERIFY(!history->empty());
QCOMPARE(changedSpy.size(), 1);
changedSpy.clear();
QVERIFY(changedSpy.isEmpty());
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QVERIFY(topSpy.isEmpty());
// insert another item, foo should get removed
history->insert(new HistoryStringItem(QStringLiteral("bar")));
QCOMPARE(history->first()->text(), QLatin1String("bar"));
QCOMPARE(history->first()->next_uuid(), history->first()->uuid());
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QVERIFY(topSpy.isEmpty());
// two changed events - once added, once removed
QCOMPARE(changedSpy.size(), 2);
changedSpy.clear();
QVERIFY(changedSpy.isEmpty());
// setting to 0 should clear again
history->setMaxSize(0);
QCOMPARE(history->maxSize(), 0u);
QVERIFY(history->empty());
QCOMPARE(changedSpy.size(), 1);
QEXPECT_FAIL("", "Clearing history doesn't emit top changed", Continue);
QCOMPARE(topSpy.size(), 1);
}
void HistoryTest::testInsertRemove()
{
QScopedPointer<History> history(new History(nullptr));
QSignalSpy topSpy(history.data(), SIGNAL(topChanged()));
history->setMaxSize(10);
QVERIFY(history->empty());
QVERIFY(!history->topIsUserSelected());
const QString fooText = QStringLiteral("foo");
const QString barText = QStringLiteral("bar");
const QString fooBarText = QStringLiteral("foobar");
const QByteArray fooUuid = QCryptographicHash::hash(fooText.toUtf8(), QCryptographicHash::Sha1);
const QByteArray barUuid = QCryptographicHash::hash(barText.toUtf8(), QCryptographicHash::Sha1);
const QByteArray foobarUuid = QCryptographicHash::hash(fooBarText.toUtf8(), QCryptographicHash::Sha1);
// let's insert a few items
history->insert(new HistoryStringItem(fooText));
QVERIFY(!history->topIsUserSelected());
QCOMPARE(history->first()->text(), fooText);
QCOMPARE(history->first()->next_uuid(), history->first()->uuid());
QCOMPARE(history->first()->previous_uuid(), history->first()->uuid());
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QVERIFY(topSpy.isEmpty());
history->insert(new HistoryStringItem(barText));
QVERIFY(!history->topIsUserSelected());
QCOMPARE(history->first()->text(), barText);
QCOMPARE(history->first()->next_uuid(), fooUuid);
QCOMPARE(history->first()->previous_uuid(), fooUuid);
QCOMPARE(history->find(fooUuid)->next_uuid(), barUuid);
QCOMPARE(history->find(fooUuid)->previous_uuid(), barUuid);
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QVERIFY(topSpy.isEmpty());
history->insert(new HistoryStringItem(fooBarText));
QVERIFY(!history->topIsUserSelected());
QCOMPARE(history->first()->text(), fooBarText);
QCOMPARE(history->first()->next_uuid(), barUuid);
QCOMPARE(history->first()->previous_uuid(), fooUuid);
QCOMPARE(history->find(fooUuid)->next_uuid(), foobarUuid);
QCOMPARE(history->find(fooUuid)->previous_uuid(), barUuid);
QCOMPARE(history->find(barUuid)->next_uuid(), fooUuid);
QCOMPARE(history->find(barUuid)->previous_uuid(), foobarUuid);
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QVERIFY(topSpy.isEmpty());
// insert one again - it should be moved to top
history->insert(new HistoryStringItem(barText));
QVERIFY(!history->topIsUserSelected());
QCOMPARE(history->first()->text(), barText);
QCOMPARE(history->first()->next_uuid(), foobarUuid);
QCOMPARE(history->first()->previous_uuid(), fooUuid);
QCOMPARE(history->find(fooUuid)->next_uuid(), barUuid);
QCOMPARE(history->find(fooUuid)->previous_uuid(), foobarUuid);
QCOMPARE(history->find(foobarUuid)->next_uuid(), fooUuid);
QCOMPARE(history->find(foobarUuid)->previous_uuid(), barUuid);
QEXPECT_FAIL("", "TopChanged is emitted twice when inserting an existing item", Continue);
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QVERIFY(topSpy.isEmpty());
// move one to top using the slot
// already on top, shouldn't change anything
history->slotMoveToTop(barUuid);
QVERIFY(!history->topIsUserSelected());
QCOMPARE(history->first()->text(), barText);
QCOMPARE(history->first()->next_uuid(), foobarUuid);
QCOMPARE(history->first()->previous_uuid(), fooUuid);
QCOMPARE(history->find(fooUuid)->next_uuid(), barUuid);
QCOMPARE(history->find(fooUuid)->previous_uuid(), foobarUuid);
QCOMPARE(history->find(foobarUuid)->next_uuid(), fooUuid);
QCOMPARE(history->find(foobarUuid)->previous_uuid(), barUuid);
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QVERIFY(topSpy.isEmpty());
// another one should change, though
history->slotMoveToTop(foobarUuid);
QVERIFY(history->topIsUserSelected());
QCOMPARE(history->first()->text(), fooBarText);
QCOMPARE(history->first()->next_uuid(), barUuid);
QCOMPARE(history->first()->previous_uuid(), fooUuid);
QCOMPARE(history->find(fooUuid)->next_uuid(), foobarUuid);
QCOMPARE(history->find(fooUuid)->previous_uuid(), barUuid);
QCOMPARE(history->find(barUuid)->next_uuid(), fooUuid);
QCOMPARE(history->find(barUuid)->previous_uuid(), foobarUuid);
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QVERIFY(topSpy.isEmpty());
// remove them again
history->remove(history->find(foobarUuid));
QVERIFY(!history->topIsUserSelected());
QCOMPARE(history->first()->text(), barText);
QCOMPARE(history->first()->next_uuid(), fooUuid);
QCOMPARE(history->first()->previous_uuid(), fooUuid);
QCOMPARE(history->find(fooUuid)->next_uuid(), barUuid);
QCOMPARE(history->find(fooUuid)->previous_uuid(), barUuid);
QEXPECT_FAIL("", "topChanged not emitted when removing top item", Continue);
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QVERIFY(topSpy.isEmpty());
history->remove(history->find(barUuid));
QVERIFY(!history->topIsUserSelected());
QCOMPARE(history->first()->text(), fooText);
QCOMPARE(history->first()->next_uuid(), history->first()->uuid());
QCOMPARE(history->first()->previous_uuid(), history->first()->uuid());
QEXPECT_FAIL("", "topChanged not emitted when removing top item", Continue);
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QVERIFY(topSpy.isEmpty());
history->remove(history->find(fooUuid));
QVERIFY(!history->topIsUserSelected());
QVERIFY(!history->first());
QVERIFY(history->empty());
QEXPECT_FAIL("", "topChanged not emitted when removing top item", Continue);
QCOMPARE(topSpy.size(), 1);
}
void HistoryTest::testClear()
{
QScopedPointer<History> history(new History(nullptr));
history->setMaxSize(10);
QVERIFY(history->empty());
QVERIFY(!history->topIsUserSelected());
history->slotClear();
QVERIFY(history->empty());
// insert some items
history->insert(new HistoryStringItem(QStringLiteral("foo")));
history->insert(new HistoryStringItem(QStringLiteral("bar")));
history->insert(new HistoryStringItem(QStringLiteral("foobar")));
history->slotMoveToTop(QCryptographicHash::hash(QByteArrayLiteral("bar"), QCryptographicHash::Sha1));
QVERIFY(!history->empty());
QVERIFY(history->topIsUserSelected());
QVERIFY(history->first());
// and clear
QSignalSpy topSpy(history.data(), SIGNAL(topChanged()));
QVERIFY(topSpy.isEmpty());
history->slotClear();
QVERIFY(history->empty());
QVERIFY(!history->first());
QVERIFY(!history->topIsUserSelected());
QEXPECT_FAIL("", "topChanged not emitted on clearing", Continue);
QVERIFY(!topSpy.isEmpty());
}
void HistoryTest::testFind()
{
QScopedPointer<History> history(new History(nullptr));
history->setMaxSize(10);
QVERIFY(history->empty());
QVERIFY(!history->find(QByteArrayLiteral("whatever")));
QVERIFY(!history->find(QByteArray()));
// insert some items
history->insert(new HistoryStringItem(QStringLiteral("foo")));
QVERIFY(!history->find(QByteArrayLiteral("whatever")));
QVERIFY(!history->find(QByteArray()));
const QByteArray fooUuid = QCryptographicHash::hash(QByteArrayLiteral("foo"), QCryptographicHash::Sha1);
QCOMPARE(history->find(fooUuid)->uuid(), fooUuid);
history->slotClear();
QVERIFY(!history->find(fooUuid));
}
void HistoryTest::testCycle()
{
QScopedPointer<History> history(new History(nullptr));
QSignalSpy topSpy(history.data(), SIGNAL(topChanged()));
history->setMaxSize(10);
QVERIFY(!history->nextInCycle());
QVERIFY(!history->prevInCycle());
const QString fooText = QStringLiteral("foo");
const QString barText = QStringLiteral("bar");
const QString fooBarText = QStringLiteral("foobar");
const QByteArray fooUuid = QCryptographicHash::hash(fooText.toUtf8(), QCryptographicHash::Sha1);
const QByteArray barUuid = QCryptographicHash::hash(barText.toUtf8(), QCryptographicHash::Sha1);
const QByteArray foobarUuid = QCryptographicHash::hash(fooBarText.toUtf8(), QCryptographicHash::Sha1);
history->insert(new HistoryStringItem(fooText));
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QVERIFY(!history->nextInCycle());
QVERIFY(!history->prevInCycle());
// cycling to next shouldn't change anything
history->cycleNext();
QVERIFY(topSpy.isEmpty());
QVERIFY(!history->nextInCycle());
QVERIFY(!history->prevInCycle());
// cycling to previous shouldn't change anything
history->cyclePrev();
QVERIFY(topSpy.isEmpty());
QVERIFY(!history->nextInCycle());
QVERIFY(!history->prevInCycle());
// insert more items
history->insert(new HistoryStringItem(barText));
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QCOMPARE(history->nextInCycle(), history->find(fooUuid));
QVERIFY(!history->prevInCycle());
// cycle to next
history->cycleNext();
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QCOMPARE(history->first(), history->find(fooUuid));
QVERIFY(!history->nextInCycle());
QCOMPARE(history->prevInCycle(), history->find(barUuid));
// there are no more next
history->cycleNext();
QVERIFY(topSpy.isEmpty());
// cycle to prev should restore previous state
history->cyclePrev();
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QCOMPARE(history->first(), history->find(barUuid));
QCOMPARE(history->nextInCycle(), history->find(fooUuid));
QVERIFY(!history->prevInCycle());
// there are no more prev
history->cyclePrev();
QVERIFY(topSpy.isEmpty());
// insert a third item
history->insert(new HistoryStringItem(fooBarText));
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QCOMPARE(history->nextInCycle(), history->find(barUuid));
QVERIFY(!history->prevInCycle());
// cycle to next
history->cycleNext();
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QCOMPARE(history->first(), history->find(barUuid));
QCOMPARE(history->nextInCycle(), history->find(fooUuid));
QCOMPARE(history->prevInCycle(), history->find(foobarUuid));
// cycle to next (should be last)
history->cycleNext();
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QCOMPARE(history->first(), history->find(fooUuid));
QVERIFY(!history->nextInCycle());
QCOMPARE(history->prevInCycle(), history->find(barUuid));
// there are no more next
history->cycleNext();
QVERIFY(topSpy.isEmpty());
// and back again
history->cyclePrev();
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QCOMPARE(history->first(), history->find(barUuid));
QCOMPARE(history->nextInCycle(), history->find(fooUuid));
QCOMPARE(history->prevInCycle(), history->find(foobarUuid));
// one more
history->cyclePrev();
QCOMPARE(topSpy.size(), 1);
topSpy.clear();
QCOMPARE(history->first(), history->find(foobarUuid));
QCOMPARE(history->nextInCycle(), history->find(barUuid));
QVERIFY(!history->prevInCycle());
// there are no more prev
history->cyclePrev();
QVERIFY(topSpy.isEmpty());
}
QTEST_MAIN(HistoryTest)
#include "historytest.moc"
Write Preview
Loading…
Cancel
Save