Summary:
KSMServer has two modes, the slightly ancient mode (XSMP), and the
really ancient legacy mode (XSM).
When startup was rewritten in 96a595f1b8
we accidentally dropped the call that invokes restore of the legacy
session as well as the normal mode.
BUG: 404318
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19028
Summary: Service is DBus activated, we don't want to manually restore it.
Test Plan: Code is copied directly from plasmashell
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19026
In 12h system locales (eg: en_US), checked=1 is cast as
Qt::PartiallyChecked=1 which defaults to the system locale (12h).
Since it's no longer a tri-state button, the user can't select
Qt::Checked=2 which forces the 24h state.
BUG: 404292
FIXED-IN: 5.15.1
I got "#define HAVE_X11 TRUE" and errors because of that where #if was
used.
This also obeys the logic that HAVE_X11 is set (in the toplevel
CMakeLists.txt) not only when X11_FOUND but also when XCB is found.
Summary:
During porting to the new KIO::SlaveBase::listEntry() API accidentally
the listEntry(entry, true) was turned into a listEntry(), where it
should have been just removed in favour of an existing finished() call.
See 0853202b0c
Test Plan: applications: and programs: no longer show the last entry twice
Reviewers: #plasma, chinmoyr
Reviewed By: chinmoyr
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18641
Summary:
This patch makes the wallpaper chooser grid view delegates show the wallpaper's
title (if it has a desktop file) or filename (if it doesn't). Authorship information
is shown via a tooltip, if present.
Test Plan:
{F6587535, size=full}
{F6587536, size=full}
Reviewers: #vdg, #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18737
Summary:
QML shadows aren't supported with software rendering, so the white text often has poor readability.
This patch falls back to outlines when using software rendering to ensure adequate readability.
BUG: 398317
FIXED-IN: 5.15.0
Test Plan:
No visual change with hardware rendering of some sort.
When forcing software rendering, I get outlines instead of shadows
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18733
Summary:
Update and improve some old Breeze Look and Feel theme previews (the Breeze Dark previews will be updated in a different revision, because they are in a different repo).
{F6584513}
Test Plan: Open the Look and Feel KCM and the Splash Screen KCM.
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: abetts, ngraham, rooty, #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18681
Summary:
If having the need to use those settings with something else than the
default, one also expects the utils to follow those custom settings.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18625
Summary:
Setting an overlay by name results in a QIcon for it created; OTOH,
this icon is never used to create the final image in case the
main/attention icons are set by name too.
Since KIconEngine supports overlays natively, directly pass the list of
overlays (with just one element -- the overlay set) to it. As result,
main/attention icons by name are created directly with the requested
overlay by name.
Test Plan:
- builds fine
- main/attention icon by name + overlay by name works now, showing the requested overlay
- main/attention icon by name + overlay by pixmap still works as before
- main/attention icon by pixmap is unaffected, no matter whether/which overlay is set
- the system tray icons of juk, and amarok now have the play/pause overlays
Reviewers: apol
Reviewed By: apol
Subscribers: davidedmundson, apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17983
Summary:
PlasmaVirtualDesktop at a protocol level is double buffered.
There's a done() command emitted after property changes. After this the
name might have changed.
Test Plan:
Changed a desktop name (with relevant kwin patch)
Name changed in the pager tooltip
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18512
Summary:
Ran into this gotcha the other day, and it was impossible to resolve
without code debugging.
Reviewers: #plasma, bshah
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18493
Summary:
Before this patch if you had no active menu and configured your plasmoid
it would be invisible.
After this patch a placeholder is shown in that configuration.
BUG: 403232
Test Plan:
* Window with menu - menu shown, no placeholder (as before)
* Window without menu - state is hidden so nothing is shown (as before)
* Window with menu whilst configuring - menu shown (as before)
* Window without menu whilst configuring - placeholder shown (new)
* Compact represenation remains the same
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18481
Summary: setting an icon via i18n makes no sense
Test Plan: Put in vertical panel, had an icon
Reviewers: #plasma, broulik, ngraham
Reviewed By: #plasma, broulik, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18480
Summary:
In the ksmserver porting most code was moved to explicitly calling
logout or shutdown methods rather than a random enum.
A legacy code path remained for compatibility. This path is used by the
containmentactions, in the refactor handling of
KWorkspace::ShutdownTypeDefault was lost.
BUG: 403466
Fixed-in: 5.15.0
Test Plan:
Set different default modes
Logged out using containment actions
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18435
l10n daemon script
David Edmundson
Chris Holland
David Faure
Friedrich W. H. Kossebau
Nate Graham
Tranter Madi
Jonathan Riddell
Bjrn Feber
Pino Toscano
Eike Hein