Summary:
There's an early return before the memory cleanup that happens at the
end of this function.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17561
Summary:
This patch removes the line of code that required that the lock screen use a light font style.
This patch is also closely related to the fixes in D17905, D17906 and D17907.
Test Plan:
Worst case scenario (legibility extremely poor):
{F6520750}
Before and after the patch:
{F6520747}
Reviewers: ngraham, #vdg, #plasma
Reviewed By: ngraham, #vdg
Subscribers: abetts, davidedmundson, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17916
Summary:
BUG: 402223
FIXED-IN: 5.15.0
Test Plan: Added multiple images from the file dialog. They all showed up in the wallpaper grid.
Reviewers: #konsole, broulik, davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17815
Summary:
When a job is terminated, it isn't necessarily removed from the job
owners queue to handle pending requests.
If a service unregisters and the job is already finished, we don't want
to mark it as an error.
Test Plan:
kioclient5 (when running with fixed interactive-ness) quits when there's an error.
We used to always show the client died error.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17711
Summary:
This:
* Makes it work on Wayland.
Depends on D13745.
* Cleans up includes and linkage.
* Fixes some pre-existing bugs like cached actions not updating
to changed desktop names.
Reviewers: mart, davidedmundson
Reviewed By: davidedmundson
Subscribers: zzag, broulik, plasma-devel
Tags: #plasma
Maniphest Tasks: T4457
Differential Revision: https://phabricator.kde.org/D15599
Summary:
This makes it work on Wayland. And probably fixes bugs, the code,
especially the next/prev window stuff, was pretty wonky.
Also some general cleanup.
Depends on D13745.
Reviewers: mart, davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T4457
Differential Revision: https://phabricator.kde.org/D15642
Summary:
Includes, among other things:
* A refactoring towards supporting more than one desktop per window,
for an eventual virtual desktops / activities merge
* A scheme for process-internal window ids on Wayland as DND payload
so DND in and to the Pager works in the shell
* Implemented various previously missing behavior in WaylandTasksModel
such as implicit moves of windows to the current desktop on various
actions
* Expanded VirtualDesktopInfo API so the Pager can better abstract
over windowing systems
* Implicit internal sharing of VirtualDesktopInfo since there are many
more instances now
* Various cleanups
Still missing:
* Fixing the VirtualDesktops data role in the grouping proxy
* The protocol doesn't have desktop creation/destruction yet, so some
of the related logic is still missing
* Some FIXME TODOs in the code when I was unhappy with the current
KWayland API
This code is largely untested and subject to change.
Depends on D12820 and relates to T4457.
Reviewers: mart, mvourlakos, davidedmundson
Reviewed By: davidedmundson
Subscribers: alexde, anthonyfieroni, zzag, ngraham, abetts, plasma-devel
Tags: #plasma
Maniphest Tasks: T4457
Differential Revision: https://phabricator.kde.org/D13745
Summary:
1. Remove the left margin.
2. Change '&' to "and".
Before:
{F6474493}
After:
{F6476224}
Test Plan: Open System Tray.
Reviewers: #vdg, broulik, #plasma, mart
Reviewed By: #vdg, #plasma, mart
Subscribers: fabianr, abetts, loh.tar, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17556
Instead of converting to QVariantMap first.
Also, port code touched as part of this to range for
Differential Revision: https://phabricator.kde.org/D17527
Nested event loops in conjunction with QML are dangerous.
Port to QMessageBox which can be used without exec()
CHANGELOG: Fix crash when deactivating Klipper's URL grabber
BUG: 363771
FIXED-IN: 5.14.5
Differential Revision: https://phabricator.kde.org/D17531
Summary:
In the specific case of having the device notifier opened
and inserting a device that has been configured to be
automatically mounted, the transition animation could be
interrupted resulting in the opacity being wrong.
Test Plan:
In the setup discribed in the summary, you should never
see something like the attached screenshot where the list
of action opacity is not 1.
{F6460038}
See http://doc.qt.io/qt-5/qml-qtquick-viewtransition.html#handling-interrupted-animations
for more information.
Reviewers: #plasma, #vdg, ngraham, davidedmundson
Reviewed By: #plasma, #vdg, ngraham, davidedmundson
Subscribers: broulik, davidedmundson, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17394
Summary:
BUG: 400663
FIXED-IN: 5.15.0
Test Plan:
Before: {F6455075}
After: {F6459462}
(label alignment being a bit off is unrelated to this patch)
Everything still works.
Reviewers: #plasma, #vdg, mart, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: alexde, mvourlakos, abetts, zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17354
Summary:
use QQC2 and FormLayout for alignment
also, qqc2 combobox doesn't suffer from 390801 anymore
BUG: 390801
Test Plan: tried to set all the options
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17333
Summary: No big visible changes, but simplifies and modernizes the code
Test Plan: used all functionality of the systray config dialog
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17212
Summary:
As requested in D16031, tweak the login and lock screens in only fairly non-controversial ways:
- Add a dark background behind the user avatar and a shadow behind the username
- Tweak the clock shadow to make it a tiny bit stronger
- Reduce clock shadow redundancy by moving it into the `Clock` item and out of the clients
- Don't use hardcoded shadow colors anymore
With the existing UI, these are very subtle changes that should barely be visible.
This diff does **NOT** include the following changes from D16031:
- Blur-less login screen
- New icons for the buttons
- Horizontal bar on the bottom to hold the buttons for the virtual keyboard, session chooser, and battery status
Test Plan:
Login screen:
{F6424115, size=full}
Lock screen:
{F6435507, size=full}
{F6435506, size=full}
{F6435519, size=full}
{F6435518, size=full}
{F6435517, size=full}
{F6435516, size=full}
{F6435515, size=full}
{F6435514, size=full}
{F6435513, size=full}
{F6435512, size=full}
{F6435511, size=full}
{F6435510, size=full}
{F6435523, size=full}
{F6435522, size=full}
{F6435521, size=full}
{F6435509, size=full}
{F6424114, size=full}
Reviewers: davidedmundson, #vdg, #plasma
Reviewed By: davidedmundson, #plasma
Subscribers: mart, rooty, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16879
Friedrich W. H. Kossebau
David Edmundson
Krešimir Čohar
Eike Hein
l10n daemon script
Nate Graham
Shubham Jangra
Kai Uwe Broulik
Laurent Montel
Thomas Surrel
Marco Martin