Summary:
This shows all the pictures inside the folders added to the Folders list. I also tried to make single pictures excludable via a checkbox on the thumbnail. This is the first time for me programming with QT/QML/Singals-Slots and I tried to use as much existing code as possible. The thumbnail view is the same as for single images and I simply subclassed the listmodel. However even if I tried to do everything like the code for slidePaths it doesn't work correctly. The checking/unchecking of images only applies on restart of plasmashell. Maybe it's a single mistake that is easily spotted by a more experienced programmer otherwise if the thumbnail view is accepted I can also revert all the checkbox stuff.
FEATURE: 403703
FIXED-IN: 5.16.0
{F6595564}
Reviewers: #vdg, ngraham, davidedmundson
Reviewed By: #vdg, ngraham, davidedmundson
Subscribers: filipf, mart, alexde, davidedmundson, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18809
Summary: This patch improves the appearance of the sddm theme and the lock screen with software rendering in place (QT_QUICK_BACKEND=software) by adding an outline to the action buttons, correcting the error that prevented the username outline from appearing and by adding a background to the action buttons that are otherwise impossible to see on top of a very bright background in software rendering mode.
Test Plan:
Before (white background):
{F6673579}
After (white background):
{F6673580}
Before (Next):
{F6673581}
After (Next):
{F6673582}
Reviewers: #plasma, #vdg, ngraham, filipf
Reviewed By: #vdg, ngraham
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19609
Summary: This patch removes the shadow from the usernames on the login and lock screens. It also restricts the clock shadow to just the opaque (unfocused) versions of each screen.
Test Plan:
{F6648570}
{F6648571}
Reviewers: #vdg, ngraham, filipf
Reviewed By: #vdg, ngraham, filipf
Subscribers: filipf, plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19468
Summary: Added in D16879, the background circle was designed to work on a blurless login screen. Since we have abandoned that idea, it's good to adjust it to our present needs. This patch lowers the opacity of the circle and removes the double border it created.
Test Plan:
Before:
{F6649241}
{F6649240}
After:
{F6649244}
{F6649243}
Reviewers: ngraham, #vdg, #plasma, rooty
Reviewed By: ngraham, #vdg, rooty
Subscribers: abetts, plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19478
Summary: This patch replaces the login button label "Log In" with an icon, places it to the right of the password field, and centers the combination of the password field and the login button. It also adjusts for the button's right border, which has a tendency to extend to the right and beyond the username input field by one pixel.
Test Plan:
Before:(user list screen):
{F6654659}
After (uer list screen):
{F6654661}
Before (user prompt screen):
{F6654662}
After (user prompt screen):
{F6654663}
Reviewers: #vdg, #plasma, ngraham, filipf
Reviewed By: #vdg, ngraham, filipf
Subscribers: davidedmundson, abetts, ngraham, filipf, plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19214
Summary:
Unlike in the logout screen, our action buttons in the SDDM theme currently offer no visual feedback when interacted with. This patch adds a minimal yet effective amount of opacity shifting, as well as a transparent circle behind the button. The same circle is added to logout screen, where it remains always visible to better indicate the chosen option.
BUG: 393048
Test Plan:
Logout:
{F6664346}
Lock:
{F6664347}
Login:
{F6664348}
Reviewers: rooty, ngraham, #vdg, #plasma
Reviewed By: rooty, ngraham, #vdg
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19479
Summary:
This patch fixes the "Unable to assign [undefined] to QColor" and "Unable to assign [undefined] to int" errors that occur in UserDelegate.qml (188:9, 187:9) and Clock.qml (53:13, 52:13, 60:13, 59:13), visible in sddm-greeter's output.
It does so by resetting the label style to Normal (instead of undefined). Once Text.Normal is set, the outline color is set as transparent (but that doesn't matter since there's no outline to begin with).
Test Plan: Works the same, looks the same, no error in output.
Reviewers: #vdg, #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19577
Summary: Due to Qt bug: https://bugreports.qt.io/browse/QTBUG-70138 (KDE bug: https://bugs.kde.org/show_bug.cgi?id=401644) we have label opacity utterly failing when the logout screen is superimposed over a bright background. Even though QtRendering is the inferior renderer, this patch uses it as a workaround for the aforementioned bug since ugly (if it ever would be) text is better than (almost) no text.
Test Plan:
Before:
{F6656331}
After:
{F6656332}
Reviewers: #plasma, ngraham, rooty
Reviewed By: ngraham, rooty
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19510
Summary: Same result as D19433, except not hardcoded anymore (adjusts for the default font size the user sets).
Reviewers: #vdg, #plasma, filipf, ngraham
Reviewed By: #vdg, filipf, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19547
Summary: Minor optimisation, should behave identically.
Test Plan:
Ran krunner
Searched for some apps
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19475
Summary: This patch makes the user avatar that is selected (in focus) larger than the other unselected/deselected avatars surrounding it (provided there is more than one user).
Test Plan: {F6651290}
Reviewers: #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: davidedmundson, abetts, filipf, plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19372
Summary:
This patch changes the logout screen labels to match the labels in the SDDM theme.
Reboot --> Restart
Logout --> Log Out (Title Capitalization)
It also adjusts the corresponding messages that use the verbs.
Reviewers: #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19458
Summary:
This patch tightens the shadows around the clock in the Breeze SDDM theme and lock screen so as to prevent the appearance of a diffuse dark glare that appears around the clock on top of very bright backgrounds.
In addition, it tightens the username/prompt shadows to match the shadows used in desktopcontainment.
Test Plan:
Username shadows, before:
{F6640921}
and after:
{F6640923}
(the new shadows take after the ones in desktopcontainment)
Before (white background):
{F6635960}
After (white background):
{F6641670}
Before (Next):
{F6635964}
After (Next):
{F6641671}
Reviewers: #vdg, ngraham, filipf, mart
Reviewed By: #vdg, ngraham, filipf, mart
Subscribers: mart, plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19325
Summary:
The use of a tri-state checkbox for the three possible states (12hr, 24hr, use locale
default) is not ideal because it violates the convention regarding what tri-state
checkboxes are used for: nested lists where some sub-items can be unselected.
This patch replaces it with a combobox that clearly indicates all three states.
While we're at it, we add a button to open the Formats KCM in case people want to change their region.
BUG: 402487
FIXED-IN: 5.16.0
Test Plan:
Tested functionality with `en_US` locale. Check out the clock in the bottom-right corner of
the following screenshots:
Default state: "Use Region Defaults": {F6645570}
Force 12 hour time: {F6645573}
Force 24-hour time: {F6645574}
Reviewers: #plasma, Zren, #vdg, davidedmundson, ndavis
Reviewed By: #plasma, #vdg, davidedmundson, ndavis
Subscribers: cfeck, totte, ndavis, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19230
Summary:
[copy-pasted from T10500:]
Problems with the current term:
- It's a somewhat severe-sounding technical term that doesn't intrinsically mean much to the average person. To the extent that it does, the connotations may be negative (e.g. when a misbehaving kid is being kept out of school)
- Our two major closed-source desktop competitors (macOS and Windows) both use the term "Sleep", so user familiarity with "Suspend" is low and falling all the time
I'd like to propose that we use "Sleep" instead, to address the above issues. It's a nicer
word in general, and since it's what our competitors use, we benefit from user familiarity.
We also recently adopted a moon icon with Zs for this, which visually connotes sleep. So it
would make sense to update the string too, because then the string and the icon will both
match.
Test Plan:
KRunner, searched for "Sleep": {F6640273}
KRunner, searched for "Suspend": {F6640284}
Kickoff, searched for "Sleep": {F6640309}
Kickoff, searched for "Suspend": {F6640315}
SDDM theme: {F6626026}
Logout screen: {F6626010}
Logout widget, UI: {F6626034}
Logout widget, config: {F6626035}
Reviewers: #vdg, #plasma, davidedmundson, filipf, mart
Reviewed By: #vdg, #plasma, filipf, mart
Subscribers: abetts, filipf, davidedmundson, plasma-devel
Tags: #plasma
Maniphest Tasks: T10500
Differential Revision: https://phabricator.kde.org/D19185
Summary:
The WaylandPrivate::virtualDesktopManagement object is loaded
asyncronously.
It's null until we finish fetching the registry.
A code path could call the desktopNames in that time.
Test Plan:
Had a crash
Couldn't reproduce reliably
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19029
Summary:
load() is called a few times and different states. After the change I
also get the warning on a regular load.
This patch returns early whilst we're in the loading state, but still
prints the warning should kactivitymanagerd fail.
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18922
Summary: Settings are ported to QtQuickControls 2 and now use a Kirigami Form Layout.
Test Plan:
Before:
{F6633459}
After:
{F6633461}
Reviewers: #vdg, #plasma, ngraham, davidedmundson
Reviewed By: #vdg, #plasma, ngraham, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19289
Summary: Currently NoDisplay services are shown, which doesn't make much sense.
Test Plan: Installed and looked through the menu, no excessive or duplicate items anymore.
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19157
Summary: Currently NoDisplay services are shown, which doesn't make much sense.
Test Plan: Installed and looked through the menu, no excessive or duplicate items anymore.
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19157
David Redondo
Laurent Montel
Krešimir Čohar
Filip Fila
l10n daemon script
David Edmundson
Nate Graham
Jonathan Riddell
Chris Holland
Fabian Vogt