Summary:
Instead of a combo box, which is a bit harder on the wording.
Also get more texts from kuserfeedback itself, no reason to translate twice.
Test Plan: Tested manually
Reviewers: #plasma, ngraham, broulik
Reviewed By: #plasma, ngraham, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24470
Summary:
If available, always use 32-bit color. We don't need Composite extension to handle transparency - all client windows are our children and transparency in handled in QML, inside the panel (so no need to composite real windows).
BUG: 356937
FIXED-IN: 5.17.1
Test Plan:
Disable compositor, run:
- pidgin (make sure pidgin-libnotify is NOT installed)
- keepassx
- xchat
- liferea
Before changes: black backgroud
After changes: transparent background
Reviewers: davidedmundson, #plasma_workspaces, #plasma
Reviewed By: davidedmundson, #plasma_workspaces, #plasma
Subscribers: mlaurent, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24530
Original intention was that we would be globally off by default.
When enabling it would have a default setting for Plasma ready
That doesn't quite work out just yet.
See bug for details
This is a precautionary temporary fix just to be extra safe
CCBUG: 412913
Summary: Include duplication, no newline at the end of file and missing argument to the i18n() call
Test Plan: Should work fine but needs a review for i18n() calls
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24580
All the new QML KCMs have their library in kcms/ subfolder
Also improve error reporting a bit by reporting whether the library was not found or its symbol is missing.
Differential Revision: https://phabricator.kde.org/D24557
Summary:
XCB may return null pointer as a response. Add a check to prevent
segmentation fault.
BUG: 409652
FIXED-IN: 5.17.1
Test Plan: It is hard to reproduce, but the reason of the segmentation fault is pretty obvious, thanks to the debug dump from bug 409652
Reviewers: #plasma_workspaces, #plasma, davidedmundson
Reviewed By: #plasma_workspaces, #plasma, davidedmundson
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24514
Summary:
Do not scale up small icons to avoid quality detoriation. For small icons scaling should be done in SystemTray only. Currently XembedSNIProxy scales to 32x32, then SystemTray (usually) scales it down to 24x24.
BUG: 366047
FIXED-IN: 5.17.1
Test Plan:
I've run few applications with small icons:
- keepassx (22x22)
- liferea (16x16)
- tuxguitar (16x16)
It looks much better without scaling in xemebdsniproxy.
Reviewers: davidedmundson, #plasma, #plasma_workspaces
Reviewed By: davidedmundson, #plasma, #plasma_workspaces
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24531
Summary:
If needed, perform resize in each update().
Client window may be too big, it must be resized to a certain reasonable size. Sometimes resizing in the constructor is not enough because it is too early and the client window is not fully initialized. Even if client window is resized, on first update it reverts back to original size (or just ignores the first request - some kind of a race condition).
In addition, I applied some rules from: https://community.kde.org/Policies/Kdelibs_Coding_Style
BUG: 358240
Test Plan:
I tested it using keepass2, now it shows better results (still not perfect). Window is resized to 32x32, but icon is only 24x24 it top-left. Better than 273x273 with tiny dot in the corner. This is a workaround for unsolvable bug in Mono - AFAIK Windows Forms are not longer maintained so it won't be fixed.
I tested this change with several other apps for regressions, no issues:
pidgin
liferea
hexchat
tuxguitar
xchat
keepassx
stardict
and other I don't remember now. No regressions.
Reviewers: davidedmundson, #plasma, #plasma_workspaces, broulik
Reviewed By: davidedmundson, #plasma, #plasma_workspaces
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24529
The inhibition handling (e.g. combining time-based, screen mirrored, etc) is done inside the applet.
The Server knows nothing about it and only reports Inhibited as true when an external application
requested one, not when the user enabled it in the applet.
This patch exposes the NotificationManager.Server as singleton QML type and adds a way for the
applet to tell it the effective inhibition state.
Exposing the server to QML could also be used in the future to provide better error reporting
to the user when the service isn't running and/or owned by someone else (e.g. Dunst)
Differential Revision: https://phabricator.kde.org/D24486
Summary:
Otherwise SDDM has to load all users even if they're not shown.
See https://github.com/sddm/sddm/pull/1017
Test Plan: Using this for several releases downstream to support >1500 users.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: ngraham, davidedmundson, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24333
Summary:
UniqueConnection I dropped as we disconnect the old source model above
regardless, so it seemed superfluous.
Test Plan:
Compiles
Opened N dolphins
They were still grouped
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24268
Summary:
It offers 2 main features:
- Configure the system-wide KUserFeedback kill-switch
- Provide a setting for how much information we want our Plasma to be sending
Test Plan:
Tested it together with Discover, works fine.
{F7497259}
Reviewers: #plasma, vkrause, ngraham
Reviewed By: ngraham
Subscribers: aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24011
l10n daemon script
Aleix Pol
Filip Fila
Konrad Materka
David Edmundson
Yuri Chornoivan
Kai Uwe Broulik
Nate Graham
Konrad Materka
Jonathan Riddell
Shubham Jangra
Fabian Vogt
Guo Yunhe