Summary:
If StatusNotifierItem is registered and then immediately destroyed, it is possible that QDBusServiceWatcher will not emit the serviceUnregistered signal.
Add an additional check to avoid such situations.
BUG: 416652
FIXED-IN: 5.18.0
Test Plan: Telegram should not add empty items.
Reviewers: #plasma_workspaces, #plasma, davidedmundson
Reviewed By: #plasma_workspaces, #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27126
The category was only used for proper Plasma::Applet instances but not unloaded plasmoids from pure metadata.
BUG: 416947
FIXED-IN: 5.18.0
Differential Revision: https://phabricator.kde.org/D27068
The code tried hard to ignore garbage URLs, as Qt is quite lenient, e.g. QUrl("Garbage Url") is still valid.
There is no way to change the strictness of a QUrl after creation,
so the code would enforce it by doing QUrl strictUrl(inputUrl.toString(), QUrl::StrictMode).
However, toString() defaults to PrettyDecoded which avoids percent-encoding and keeps spaces
in tact which is not a valid thing to have in a strict URL.
Effectively, we want to ensure a URL is either a valid path to a local file,
or one of the special applications (for menu ids), or preferred for preferred applications, like web browser,
BUG: 385727
FIXED-IN: 5.18.0
Differential Revision: https://phabricator.kde.org/D26941
Summary:
In Plasma, 5.18, this ishn't a user-facing option anymore. It's still visible in the
context meny configuration dialog though, and it's still referenced in some of the
context menu building code.
This patch removes it from those places
BUG: 416578
FIXED-IN: 5.18.0
Test Plan:
Context menu still looks the same on the desktop and panel, both in and out of edit mode
The action no longer shows up in the configuration UI.
Please review carefully as this code is fairly unfamiliar to me.
Reviewers: mart, #plasma
Reviewed By: mart, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26845
Summary:
We switched to .jpg for Next but SDDM theme's code still points to .png so we got a white screen instead.
Have the code point to .jpg instead.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27018
Summary:
now look and feel packages can specify a default image wallpaper.
when a new containment is created at first plasma start or at activity creation
search for a default wallpaper inthe order:
look and feel package
if fails, from the plasma theme
we are sure to find a default after it as if neither of those specify one,
the wallpaper specified by the breeze plasma theme (Next) will be used
D21225 takes care of setting the wallpaper when a lnf theme is selected by the kcm
Test Plan:
tested to start plasma with an empty config file with different themes
that do or don't include wallpapers
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: kossebau, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21226
Summary:
Fixes a bug, when system tray settings is opened and new application is opened, view is not correctly refreshed and icon is missing. Caused by duplicated role names. Related to: D26586
BUG: 416400
FIXED-IN: 5.18.0
Test Plan:
1. Open system tray settings
2. Open an app with systray icon
Expected:
Icon, title etc are correctly rendered.
Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Reviewed By: #plasma_workspaces, #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26850
Summary:
QTimer::singleShot could dispatch gatherInfo after the next WindowsRunner::match was called in a not-ready state preventing to return match.
prepareForMatchSession will lock the lock, allowing only gatherInfo to run, which will unlock the lock, allowing match() to run.
BUG: 414804
FIXED-IN: 5.18
Reviewers: #plasma, ngraham, mart, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26494
Makes it more obvious that there is an inline reply rather than having a "Reply" button where the user must guess what it'll do.
Differential Revision: https://phabricator.kde.org/D26796
Summary:
Applications which set `Qt::AA_EnableHighDpiScaling` use the DPI of the monitor the window is on to calculate an additional scaling factor.
Plasma sets `QT_SCREEN_SCALE_FACTORS` in the environment for manual specification of per-monitor scale, which combined with the automatic scaling may result in double scaling.
To disable the automatic scaling, `QT_AUTO_SCREEN_SCALE_FACTOR=0` has to be set, even on Qt 5.14.
As a side effect, this works around QTBUG-80967 as well.
BUG: 415421
Test Plan: On X11, with a >144dpi monitor and a scaling factor of 2 set manually, scaling was doubled previously. Now it works as expected.
Reviewers: #plasma, apol, davidedmundson, fvogt
Reviewed By: #plasma, davidedmundson, fvogt
Subscribers: acooligan, fvogt, asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26185
Plasma Browser Integration provides controls for Chrome, so when a player with kde:pid metadata is found, it is preferred over the actual pid it represents.
Differential Revision: https://phabricator.kde.org/D26702
Summary:
Before loading the view, query all plasma processes and show why they're using
KUserFeedback.
Depends on D26569
Test Plan: Manual testing
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: ngraham, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26570
Summary:
- Correct the destination path when downloading images.
- Switch from FileCopyJob to CopyJob to allow showing file overwrite dialog.
BUG: 379469
Test Plan: Drop files from Firefox to the desktop to set the wallpaper successfully.
Reviewers: #plasma, mart, ngraham
Reviewed By: #plasma, mart, ngraham
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26525
Summary:
Combines settings of SNI icons and plasmoids in one list. Ability to disable whole section is removed.
Initial idea was proposed by Nicolas Fella (D22176).
BUG: 360307
FIXED-IN: 5.18.0
{F7880936}
Test Plan:
1. Disable/enable plasmoids
2. Set Shown/Hidden for plasmoid
3. Set shortcut for plasmoid
4. Previously hidden categories are shown
5. Show all icons and revert
6. Set Auto/Shown/Hidden for SNI icons
Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, mart
Reviewed By: #plasma_workspaces, #plasma, ngraham, mart
Subscribers: ahiemstra, mart, meven, nicolasfella, plasma-devel, ngraham
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26586
Summary:
sddm-greeter will have a button for the reveal password button, but due
to sddm-greeter not loading a relevant QPT has no code to force it to
load the breeze icon set.
Without the breeze icon set, the clear button does not show.
There are ways to solve this, but none are trivial or reliable.
I threatened to do a revert in 5.12 (https://phabricator.kde.org/D9040)
but the bug has still not been fixed since.
BUG: 396039
CCBUG: 387418
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26675
Summary:
If the kcm's property changes externally we don't update the slider
after the initial load, which is before KConfigModule::load which actually sets
the property.
Whilst there is an alternative fix calling load() a second time, we need
this anyway for default and reset buttons to work correctly.
I also think the original code was broken, I don't see why we would map
the value back to modeOptions[idx], we want the slider value to be the
index of the array, not the enum value. They just happen to be the same.
Test Plan: Opened KCM changed it, opened KCM repeat
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26678
Summary:
BUG: 415461
FIXED-IN: 5.18.0
Depends on D26510
Right now when you first change the wallpaper plugin to slideshow, no locations are
pre-configured, so you have to add one yourself. This patch adds a
`preferred:wallpaperlocations` token as the default that gets replaced in the user's
config file at runtime with the XDG wallpaper locations.
Test Plan:
Log in as new user > right-click desktop > configure > change to slideshow wallpaper
See that`/usr/share/wallpapers` is already in the list of wallpaper locations; how nice
Reviewers: #plasma, #vdg, ndavis, davidedmundson
Reviewed By: #plasma, #vdg, ndavis, davidedmundson
Subscribers: davidre, broulik, davidedmundson, ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26483
Summary:
Adjust to the string changes in D26551 and improve the presentation
overall to make it more likely that people will feel comfortable
using it and submitting information.
Depends on D26551
Test Plan: How it looks now: {F7875839}
Reviewers: #vdg, #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26552
Summary:
This switches the image plugin to using KNewStuffQuick instead of
launching the widget dialog through that ol' widget dialog hack.
It further uses the big preview mode by default, which just seems
to make a lot of sense for wallpapers.
Test Plan:
Without: Uses the old dialog
With: Uses the new dialog, as seen below
{F7882885}
Reviewers: mart, #plasma, ngraham
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26665
Summary:
We currently have a mouse-wheel action to switch to the previous/next activity,
but it wasn't possible to assign a global keyboard shortcut to these actions.
As discussed on Phabricator, this doesn't define a default key-sequence yet,
but at least gives users the possibility to assign there own ones, which wasn't
possible before.
Reviewers: apol, davidedmundson, #vdg, #plasma, ngraham
Reviewed By: davidedmundson, #vdg, #plasma, ngraham
Subscribers: ngraham, romangg, ivan, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22382
Kai Uwe Broulik
Konrad Materka
l10n daemon script
Nate Graham
Filip Fila
Marco Martin
Méven Car
Fabian Vogt
Jonathan Riddell
Aleix Pol
Tranter Madi
David Edmundson
Dan Leinir Turthra Jensen
Christian Muehlhaeuser