Summary:
At the moment we were merging two different concepts into a same KCM and it was
too confusing.
Simplify making the kcm only about Plasma by removing the kill switch and
making sure the text only affects Plasma components.
Reviewers: #plasma, vkrause, davidedmundson, ngraham
Reviewed By: #plasma, davidedmundson, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24733
when items are moved around due to screen resolution change,
no cell should be considered as taken, because all items will be moved,
otherwise items will be moved and resized in unexpected ways to make
room for "ghost" items.
Clear the bookkeeping before doing the move
BUG:413019
Summary:
At some point there was an effect in kwin to fade to a grey (with a
weird vigenette effect) as one logs out.
This was signalled with a fake offscreen window with a special window
ID.
The kwin effect has gone, deleted in Plasma 5.8 with
af80a546bfe258b54468b159bb8cf78f16ca9ebf
(Kwin still contains an effect called logout, but that's merely for the
logout prompt)
I intend to replace this logout effect but as I'm going to start from
scratch we may as well communicate from ksmserver -> kwin with a new API
that works on wayland and and solves some other issues all in one.
Test Plan: Compiles
Reviewers: #plasma, #kwin, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24759
Summary:
To avoid kwin warnings in ~/.local/share/sddm/wayland-session.log such as :
kwin_core: Could not find the desktop file for "/home/meven/kde/usr/bin/krunner"
kwin_core: Did not grant the interface "org_kde_plasma_window_management" to "/home/meven/kde/usr/bin/krunner" . Please request it under X-KDE-Wayland-Interfaces
Reviewers: apol, #plasma
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24857
Summary:
some optimizations for tablet mode (touch first, but also on
transformable laptops flipped to tablet)
and some for specifically the mobile case (mobile phone)
* hide the top toolbar in phone mode
* in tablet mode (and therefore on phone mode too) don't select text but drag the item laterally to dismiss it
Test Plan:
* on phone form factor for the new behavior
* on touch laptop in tablet mode
* on desktop for its behavior not changing at all
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: nicolasfella, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24765
Since we fixed RunnerManager::teardown to actually be emitted, the runner would throw away its gathered window info and then crash in run().
I couldn't figure out what the proper API was so this is a workaround to keep it from crashing at least.
However, the runner also didn't check whether the window was actually still valid by the time run() was called,
so querying for the window again once it is called and checking validity is a good thing either way imho.
In the future, this probably should be ported to using libtaskmanager :)
BUG: 412386
FIXED-IN: 5.17.1
Differential Revision: https://phabricator.kde.org/D24849
Summary:
edit mode menu action
edit mode dbus property for systemsettings
containmentlayoutmanager goes out of edit mode only when the whole
plasma app loses focus, so the panel controlled doesn't make it go out
of it
Test Plan:
iaction shows in context menu, works
property exposed on dbus works
Reviewers: #plasma, #vdg, ngraham, GB_2, davidedmundson
Reviewed By: #plasma, #vdg, ngraham, GB_2, davidedmundson
Subscribers: GB_2, ngraham, davidedmundson, plasma-devel
Tags: #plasma
Maniphest Tasks: T10190, T11094, T10402
Differential Revision: https://phabricator.kde.org/D24264
Summary:
QSortFilterProxyModel uses std::stable_sort internally which requires that the
comparison function generates a strict weak ordering. Returning true or false
randomly didn't fullfil this requirement causing a crash in some calls to invalidate.
To keep the random order consistent a vector of row indices is used which records
the current random order.
BUG: 413018
FIXED-IN: 5.17.1
Test Plan:
To reproduce the bug use a slideshow in random order with few pictures and a small
time intervall.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: davidedmundson, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24723
Summary:
Adding support for Attention Icon to StatusNotifier tray icons
BUG: 341255
Test Plan: As described in bug report, Konversation can be used for tests.
Reviewers: #plasma, davidedmundson, apol, mart, ngraham
Reviewed By: #plasma, davidedmundson, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24767
Summary:
Use '\0' as separator as '\n' is likely to appear in values.
BUG: 413130
Test Plan:
/etc/profile.d/mc.sh exported an mc() function,
which resulted in "syntax error: unexpected end of file" in the Plasma session.
Now the mc function is correctly set in the environment.
Reviewers: #plasma, apol, davidedmundson, adridg
Reviewed By: #plasma, apol, davidedmundson, adridg
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24750
According to the spec, xesam:artist should be a string array, but
majority of players uses string instead. This patch adds support for
both string array and string options to allow new software development
according to the spec but also maintain compatibility with existing
solutions.
BUG: 405762
FIXED-IN: 5.17.1
Differential Revision: https://phabricator.kde.org/D24740
Summary:
Icon should be highlighted hover, as any other icons in the system tray.
CCBUG: 400295
Test Plan: Hover mouse over over the icon - it should highlight.
Reviewers: #plasma, davidedmundson, #plasma_workspaces, broulik
Reviewed By: #plasma, #plasma_workspaces, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24738
And make it the default.
Kill Switch is only for when you think something off is happening or you
don't feel in control.
Reviewed by David Edmundson (see D24635)
Summary:
Right now windy conditions are not handled at all. I live in an area with very frequent
windy conditions especially during certain times of year so this is annoying because I
see the purple question mark icon a lot, which in the past has made me stop using the
weather widget.
This patch implements handling for windy + clear and cloudy conditions for NOAA. I
don't know how to implement this for Wettercom.
Depends on D24537
Test Plan:
Before: {F7568603}
After: {F7568554}
Reviewers: kossebau, #plasma, spstarr
Reviewed By: #plasma, spstarr
Subscribers: spstarr, plasma-devel, #vdg
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24483
Summary:
I just switched to openSUSE Tumbleweed and noticed that the session names in SDDM's
chooser don't include "X11" or "Wayland" like they do in other distros I've used before. This
makes it impossible to tell which one you're going to boot into.
This patch adds those identifiers into the translated string so it's always clear.
Ideally https://github.com/sddm/sddm/pull/997 would get done first, but even it it doesn't,
it's no big deal.
Reviewers: fvogt, davidedmundson, apol, #plasma
Reviewed By: davidedmundson, #plasma
Subscribers: fvogt, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24666
Summary:
Because this script copies things to /, it needs to be run with `sudo`. But two of the
copy operations also copy things to your home directory, and if you `sudo` the whole
script, this results in those files being copied with root ownership, which can cause
problems later.
This patch prepends `sudo` to just the copy operations that need it so that the ones
that don't aren't run with inappropriately elevated permissions.
Test Plan:
- Run `~/kde/build/plasma-workspace/login-sessions/install-sessions.sh`
- Get prompted for the root password
- Enter it
- See that `plasma-dev-prefix.sh` and `startplasma-dev.sh` in `~/kde/usr/lib64/libexec/` have user ownership, not root ownership
Reviewers: apol, #plasma
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24677
Summary:
SDDM until 0.18.1 appends " (Wayland)" to the name of any session file it
finds in wayland-sessions dir, and Plasma is relying on that behaviour to
distinguish between its X11 and Wayland sessions. This leads to duplicate
"Plasma" entries on any other DM not applying the same hack, e.g. lightdm,
and users are lost without downstream patching.
SDDM in 0.19 only appends " (Wayland)" in case the session name does
not already end with this, to avoid duplicating it.
CCBUG: https://bugs.kde.org/show_bug.cgi?id=368409
See also: https://github.com/sddm/sddm/pull/997
Reviewers: #plasma, davidedmundson, fvogt, ngraham
Reviewed By: #plasma, davidedmundson, fvogt, ngraham
Subscribers: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22210
Fixes erroneously enabling do not disturb mode in some situations when having screens mirrored and then closing the lid.
You'll have two overlapping screens but one of them is disabled so should be ignored.
Depending on the order of outputs this may or may not happen (which is why I didn't notice earlier when I tested with my new laptop).
CHANGELOG: Fixed erroneously entering do not disturb mode when there are overlapping *disabled* screens
Differential Revision: https://phabricator.kde.org/D24679
Summary: It's not visible in the desktop system tray, but it is visible in the Plasma Mobile drawer where it is the only colorful icon. Let's use a monochrome one that actually looks like a battery instead
Reviewers: #plasma, bshah, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24649
l10n daemon script
Aleix Pol
Marco Martin
David Edmundson
Méven Car
Jonathan Riddell
Kai Uwe Broulik
David Redondo
David Faure
Konrad Materka
Fabian Vogt
Denis Sheremet
Nate Graham
Andreas Sturmlechner
Guo Yunhe
Nicolas Fella