This allows to open the location of the folder the wallpaper is in.
BUG: 371247
FIXED-IN: 5.11.0
Differential Revision: https://phabricator.kde.org/D6450
Summary:
Currently the selected wallpaper is deselected when the "Apply"
button is clicked, as if no wallpaper is selected. This patch
fixes that. I didn't understand what the original restoreIndex
thing was trying to do by passing the count, so I gutted it and
wrote code that makes more sense to me.
Reviewers: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5440
Summary:
Whilst using units is generally good, the wallpaper transition time is
way too short. It's a different type of animation to the others,
especially in a slideshow, where the transition is an important part of
the behaviour.
This patch loads it from a hidden configuration option with a duration
of 1000ms, if and only if animations are enabled.
Value determined through brief trial and error.
BUG: 365979
Test Plan:
Opened wallpaper. Clicked next.
Also changed static wallpaper manually, transition looked fine
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4370
Summary:
Currently the we create previews with QPixmapItem from KDeclrarative and
when a wallpaper is set to centered sets it to an enum value that
doesn't exist.
PreserveAspectFit displays the wallpaper in the correct proportions as
when it will be applied, but will still be big enough to make it
actually previewable.
BUG: 375675
Reviewers: #plasma, mart
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4840
Summary:
qml gridview don't have an official way to ensure the
current index is visible when the view is first instantiated,
the only way we have is to do positionViewAtIndex when we know the
proper space has already been allocated (Component.onCompleted
is way too early) we used to do that on onCountChanged, but that
too seems to early sometimes, as the selected wallpaper
is visible only sometimes, attaching it to onContentHeightChanged
seems to be more reliable (for all branches)
Test Plan: proper wallpaper is visible every time the window opens
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4648
Summary:
qml gridview don't have an official way to ensure the
current index is visible when the view is first instantiated,
the only way we have is to do positionViewAtIndex when we know the
proper space has already been allocated (Component.onCompleted
is way too early) we used to do that on onCountChanged, but that
too seems to early sometimes, as the selected wallpaper
is visible only sometimes, attaching it to onContentHeightChanged
seems to be more reliable (for all branches)
Test Plan: proper wallpaper is visible every time the window opens
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4648
Summary:
qml gridview don't have an official way to ensure the
current index is visible when the view is first instantiated,
the only way we have is to do positionViewAtIndex when we know the
proper space has already been allocated (Component.onCompleted
is way too early) we used to do that on onCountChanged, but that
too seems to early sometimes, as the selected wallpaper
is visible only sometimes, attaching it to onContentHeightChanged
seems to be more reliable (for all branches)
Test Plan: proper wallpaper is visible every time the window opens
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4648
Summary:
f6ce91499a replace the height/width property of Image with
targetSize, and phone image configuraiton was not adopted for that
change resulting in broken configuration window for plasma mobile
Test Plan: tested on phone
Reviewers: broulik, #plasma
Reviewed By: broulik, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4528
Summary: And remove some useless debug statements as well
Test Plan: no more useless debug statment
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4529
Summary:
Using the same semantics as the InstallationCommand, makes it possible for the
client to get a kns resource adopted.
Needs further standarization, I have implemented this on Discover and seems
to work just fine.
Reviewers: whiting, leinir, #plasma, mart
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4307
Directly expose "targetSize" as property. The wallpaper is already initialized with
the correct size for some time now but the fact that we had two properties width and height
in there had it still do unneccessary work when it emitted "sizeChanged(2560, 0)" and
then the final "sizeChanged(2560, 1440)" afterwards.
Also, I didn't really see a point in storing the wallpaper size in its config,
it's overwritten by the wallpaper anyway and only used in the wallpaper config dialog
for the aspect ratio. We can just ask the view directly then.
BUG: 374689
FIXED-IN: 5.9.0
Differential Revision: https://phabricator.kde.org/D4001
There is no need to decode the whole image and load it into memory
when we are only interested in the dimensions.
Differential Revision: https://phabricator.kde.org/D3973
l10n daemon script
Kai Uwe Broulik
Eike Hein
David Edmundson
Marco Martin
Bhushan Shah
Aleix Pol
Fredrik Höglund