Previously it would use an on-disk KImageCache which would never be invalidated.
Moreover, it just uses KIO::PreviewJob which does its own more clever (compares mtime and other properties) on-disk caching already.
It is using its own QCache rather than QPixmapCache to not jeopardize other caching for the potentially large wallpaper thumbnails
that are only relevant while the dialog is open.
BUG: 395447
FIXED-IN: 5.15.0
Differential Revision: https://phabricator.kde.org/D16095
org.kde.slideshow is duplicated at compile time, so translations aren't extracted for it.
Setting an explicit domain fixes that.
Differential Revision: https://phabricator.kde.org/D16037
Summary:
10 seconds isn't the best default value for slideshows. 15 minutes is more reasonable, and easier on battery life for laptops, too.
For comparison: macOS and Windows both default to 30 minutes.
Test Plan: {F6287038}
Reviewers: #plasma, broulik, mart, #vdg, abetts, davidedmundson
Reviewed By: #plasma, #vdg, abetts, davidedmundson
Subscribers: abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15785
Summary:
Slideshow wallpapers use the same Blur/Color selector that single image
wallpapers use. However, the Blur config entry was added to the image
xml but not the slideshow xml. The result was that the selection was
never persisted and reverted to the default on restart. This allows the
slideshow blur config to persist.
Test Plan:
Configure the desktop backgrounds.
Select slideshow with one or more images that are smaller than the screen.
Choose fill with solid color. Apply and exit.
Note that the background fill takes on the solid color
Restart
Note that the background fill is still the solid color
Configure desktop background
Choose fill with blur. Apply and exit
Note that the background fill is a blur
Restart
Note that the background fill is still a blur.
Reviewers: #plasma_workspaces, davidedmundson
Reviewed By: #plasma_workspaces, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13555
They are usually hidden for a reason and shouldn't show up in the slideshow.
BUG: 394882
FIXED-IN: 5.12.6
Differential Revision: https://phabricator.kde.org/D13260
Summary:
With slideshow desktop wallpaper plugin, selecting "Open wallpaper Image" from RMB does nothing. It looks like the `action_open` method called by the RMB menu action is using an old field that no longer exists.
The patch updates the code to use the correct field.
BUG: 394035
Reviewers: #plasma_workspaces, ngraham, broulik
Reviewed By: #plasma_workspaces, ngraham, broulik
Subscribers: broulik, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12777
Summary:
update the wallpaper dialog to the same design as the new KCMS
for consistency
Test Plan:
dialog loads with proper wallpaper selected, and both clicking on one
works and the attached toolbuttons work too
Reviewers: #plasma, #vdg, davidedmundson, broulik
Reviewed By: #plasma, broulik
Subscribers: davidedmundson, broulik, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12148
This broke in the transition to StackView as the blur needs a full-size source. Additionally
* put the item into a Loader to avoid needless shader compilation and other work
* only load the blur for image fill modes where the image does not cover the full size
* don't render background color when blur is enabled as you cannot see it anyway
Differential Revision: https://phabricator.kde.org/D11981
Summary:
The image wallpaper is a mess of 4 different fade functions, some not in
sync, and very complicated swapping images about.
This simplifies the whole thing by using a StackView, we just pop our
setup with a new configuration on and it handles deleting old objects
when the transition ends.
Code is 1/3 the size, whilst doing the same thing and should result in
having fewer items about.
In addition with this patch changing the transition effect in future
would be super trivial.
Test Plan:
Set as both image and wallpaper
Renders stuff as before
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11726
Summary:
BackgroundFinder runs in a separate thread, it uses a static QStringList cache
It's perfectly plausible that two BackgroundFinders threads could run at once
Test Plan:
Old code didn't crash, it was a pure hypothetical.
Works as before
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: anthonyfieroni, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11590
Summary:
The "Encoding" entry had been deprecated in 2006
(https://cgit.freedesktop.org/xdg/xdg-specs/commit/?id=6855384d021d88557f80674798c584c15b547f36)
and there is no current workspace known which still requires it being set
(incl. Plasma itself).
Also has the usage been incomplete and sometimes not at the beginning as
required if used (once scripty had sorted all entries in desktop files
alphabetically and it was not restored everywhere).
Removing them altogether creates consistency and avoids further confusion
about and wasted resources for this unused data bit.
Removing those entries also from Plasma/5.12 branch avoid conflicts on
merging to master, given the entries are often next to translated entries,
or generous merging which lets the entries slip back into existance.
Reviewers: #plasma, fvogt, broulik, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11563
Summary:
The wallpaper loading code expects the catalogs to follow the pattern
"plasma_wallpaper_" + pluginid. While in config QML the domain needs
to be explicitly set using i18nd, as the default textdomain is set to
that of the config container, it is not needed in the wallpaper QML.
While using a catalog with plasma_applet_* prefix works if setting
the domain explicitly, the usage goes against the design of the
naming patterns. So to give a good example and also properly marking
the usage of the catalog, the names are switched.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10850
l10n daemon script
Kai Uwe Broulik
Nathaniel Graham
David Edmundson
Yuri Chornoivan
Laurent Montel
Oded Arbel
Friedrich W. H. Kossebau
Marco Martin