This avoids fading the image source, or the fill mode, or the source size on startup while we're still setting things up.
While a Timer is usually a bad idea, this simplifies the code a lot.
Differential Revision: https://phabricator.kde.org/D9762
The delete button changes the currentIndex to something else when deleting the current image but that didn't update cfg_Image.
Just listen to when we become current. Might also fix keyboard navigation (didn't test if that worked before but it certainly does now).
BUG: 388805
Differential Revision: https://phabricator.kde.org/D9818
Wait for m_ready until doing anything. This keeps the slideshow from first showing the default wallpaper,
then a random slideshow image, and then fade to the next slideshow image.
Differential Revision: https://phabricator.kde.org/D9763
Summary:
Related to patch https://phabricator.kde.org/D7047 . Pointed out by @ngraham
Make a new option called "Edge filling". Users can choose either "Blur image" or "Solid color". They are only visible when the image filling mode is "Center" or "Scale and keep ratio".
When it is "Center":
{F5447565}
When it is "Tile":
{F5447053}
Reviewers: ngraham, jensreuterberg
Reviewed By: ngraham, jensreuterberg
Subscribers: jensreuterberg, broulik, ngraham, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8441
Summary:
There's a bunch of code referring to this setting but not such a setting,
so the qml engine is confused and outputs tons of warnings
Reviewers: #plasma, guoyunhe, ngraham, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8807
Summary:
On wayland we're using Qt scaling.
This normally handles most scaling stuff itself, except because we're
explicitly forcing a source size, we need to scale that.
Test Plan:
Loaded a 4k wallpaper from internet
Looked at the tiny pixels
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8826
Summary:
Changes the button in the wallpaper chooser marked "Open..." to say "Add Image..". This matches the text style for the button in slideshow mode, which says, "Add Folder"
Also added ellipses to "Add Folder"; it's now "Add Folder..."
Test Plan:
Tested in KDE Neon.
Before:
{F5473479}
After:
{F5473507}
Reviewers: #plasma, broulik, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: aspotashev, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8658
This allows adding images (for image wallpaper) and folders (for slideshow) by dragging them into the list of images/folder.
Differential Revision: https://phabricator.kde.org/D6568
It is still set for when a source is applied for the next
transistion.
Summary:
This saves evaluating a new paintedSize and doing a bunch of evaluations
which are not used.
More importantly it works round a Qt animation crash.
fadeAnim.running is bound to otherImage.status !== loading
with the intention of delaying animations until the images are really
loaded.
By setting the fill mode and then the source, we go to loading and back,
effectively restarting the animation from within the animation.
This leads to a crash.
CCBUG: 381105
Test Plan:
End user result is the same.
Reviewers: #plasma, broulik, mart
Reviewed By: #plasma, broulik, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7248
Summary:
comment gets converted to summary in appstream data and summaries are
required, without it we'll fail the appstream test.
Reviewers: apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7070
KCMs can be individually disabled by KIOSK if desired but wallpaper configuration cannot (unless you lock down
Plasma completely). Hence, at least honoring the ghns restriction here, until we have a proper solution
(that is a QtQuick equivalent of KNS3::Button).
Also, KNS3::DownloadDialog refuses to open when ghns is restricted *but* this applies only to using open()
or exec() but not a blatant show() we do from QML.
Differential Revision: https://phabricator.kde.org/D7086
l10n daemon script
Laurent Montel
Kai Uwe Broulik
Guo Yunhe
Aleix Pol
David Edmundson
Nathaniel Graham
Marco Martin
Harald Sitter