Summary:
libepub can't handle whitespace url encodings. This is why epub documents containing whitespaces urls aren't
displayed correctly. Since libepub doesn't seem to be maintained anymore, it might be better to fix this issue here.
BUG: 334711
Test Plan: Example epubs are in the ticket.
Reviewers: #okular, aacid
Reviewed By: #okular, aacid
Subscribers: ngraham, aacid, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D14310
Summary:
When save/save as functions are called they internally call the openFile() function, in the open file function the side bar item is set to Table of Contents (ToC) item
```
if ( m_document->metaData( QStringLiteral("OpenTOC") ).toBool() && m_sidebar->isItemEnabled( m_toc ) && !m_sidebar->isCollapsed() && m_sidebar->currentItem() != m_toc )
{
m_sidebar->setCurrentItem( m_toc, Sidebar::DoNotUncollapseIfCollapsed );
}
```
so I just store the sidebar's item before saving and then set this item back if changed.
BUG: 389668
Reviewers: #okular
Subscribers: aacid, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D14740
CCBUG: 391625
Test Plan: I tested the file mentioned in the bug report. Pictures look less blurry
Reviewers: #okular
Subscribers: ngraham, aacid, okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D13766
This fixes the same crash as bug 393334 but in a better way
the old way was setting a variable on destruction and then trying
to use that variable in a slot, but that's obviously wrong since
we were already mid destructing the object.
BUG: 396807
Summary:
This exposes the Okular's functionality of changing the document's colors
through its d-bus interface. This is mainly useful for scripting Okular to
switch to a 'day mode' or 'night mode'.
[Example] Switching themes of two applications with one hotkey:
{F5905771}
Reviewers: #okular, aacid
Reviewed By: #okular, aacid
Subscribers: okular-devel
Tags: #okular
Differential Revision: https://phabricator.kde.org/D13471
This should not be needed, but i can totally reproduce that without it
top is still reporting lots of memory used by Okular when it's really
not (heaptrack reports memory freed correctly)
BUGS: 394834
Summary: This tests the newly added additional widget actions.
Test Plan:
Passes for me. Is my first GUI test, maybe the timing
needs to be slower for slower machines?
Reviewers: aacid
Reviewed By: aacid
Subscribers: okular-devel
Tags: #okular
Maniphest Tasks: T8627
Differential Revision: https://phabricator.kde.org/D13170
Summary:
This adds support for actions associated with form fields
through corresponding annotation widgets.
Test Plan:
Still needs a unit test, only tested manually with
the document attached in the task.
Reviewers: #okular, aacid
Reviewed By: #okular, aacid
Subscribers: okular-devel, aacid
Tags: #okular
Maniphest Tasks: T8627
Differential Revision: https://phabricator.kde.org/D12665
Yuri Chornoivan
Gilbert Assaf
l10n daemon script
Oliver Sander
Albert Astals Cid
Ahmad Osama
Christoph Feck
Laurent Montel
Friedrich W. H. Kossebau
Michael Eden
Aleix Pol
Andre Heinecke