Summary:
This was added for feature-parity with Meson-based projects; but an
individual package is the wrong place for that. To avoid the proliferation
of auto-detected ccache support in kde.org packages please submit such
a proposal to kde-frameworks-devel instead, where it could be added for
the benefit of all the projects using ECM. And more importantly, with a
standard switch to disable it for packaging environments
This reverts commit 007c2a0852.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: kkharlamov, hindenburg, konsole-devel, hiangel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D24805
When creating HotSpot's for local files, create them for files in the
current dir and for files in sub-directories too.
Re-format the code used to build the regex pattern for more readability
(easier for seeing what the regex pattern will look like, I hope).
Use a static QRegularExpression object, so as to only construct it once,
the pattern doesn't change and this should help with performance. Also
make createFileRegex() not static.
Don't convert QList<QString> to QSet<QString>, without actual benchmarking
it could be that QList is actually efficient here.
Use const where appropriate.
BUG: 416376
Current version of Konsole allows to select the custom color of the
cursor (Settings -> Edit Current Profile -> Appearance -> Cursor ->
Custom cursor color). This works well for I-Beam and Underline cursor
shapes. But for block-shaped cursors the text under the cursor is often
hard to read, e.g. bright text under the bright cursor or dark text
under the dark cursor.
This patch adds an ability to select the custom color of the character
under the cursor. The character uses this color only when the cursor
shape is Block and Konsole window is focused. Otherwise the character
uses its foreground color as usual.
FEATURE: 407915
FIXED-IN: 20.04
This breaks the logic for the KDBusService crash fix. If this (using
unique_ptr) needs to be done it needs to carefully release() and reset()
at every step, and then it's just easier to manually delete it where
appropriate IMHO.
This reverts commit d5d8496cd2.
Differential Revision: https://phabricator.kde.org/D26764
The actions are destroyed during a focusIn / focusOut, and recreated
with the same content but different memory positions, and that
killed the QActions inside of the menu.
To trigger this is simple, open the search bar, type some url in
konsole, and right click on it: you will not see the actions
to copy and go to url.
moving the related code to QSharedPointer fixes this by delaying
the destruction of the pointer untill the menu is closed.
Summary:
Konsole already responds to background color status report
requests, but ignores requests for the foreground color.
This adds the support and makes Konsole behave like other xterm /
VTE-based terminals.
Test Plan:
Run 'printf "\033]10;?\a"' in a bash shell and Konsole should
respond with the current foreground color setting on stdout.
Summary:
The `_colorRandomization` property is new in 19.12, and should be
copied by the copy constructor as well.
This fixes the problem that it was not possible to disable the
"Randomly adjust colors for each session" option again once it was
enabled.
CCBUG: 415242
FIXED-IN: 19.12.1
Test Plan:
In the color scheme editor:
Choose "Black on Random Light" and click on Edit, disable
"Randomly adjust colors for each session", and click OK.
It's saved correctly now, previously it stayed on.
Alternatively, select some other color scheme, enable the option and
click OK. Then try to disable it again. This works now, previously it
also stayed on.
Select an existing colorscheme and click on New, the new color scheme
still properly inherits the "Randomly adjust colors for each session"
setting.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D26439
(cherry picked from commit 771c1733fd)
Summary:
The `_colorRandomization` property is new in 19.12, and should be
copied by the copy constructor as well.
This fixes the problem that it was not possible to disable the
"Randomly adjust colors for each session" option again once it was
enabled.
CCBUG: 415242
FIXED-IN: 19.12.1
Test Plan:
In the color scheme editor:
Choose "Black on Random Light" and click on Edit, disable
"Randomly adjust colors for each session", and click OK.
It's saved correctly now, previously it stayed on.
Alternatively, select some other color scheme, enable the option and
click OK. Then try to disable it again. This works now, previously it
also stayed on.
Select an existing colorscheme and click on New, the new color scheme
still properly inherits the "Randomly adjust colors for each session"
setting.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D26439
This reverts 0995c1dc95bb0df2a04aa84e1034044448ab542e; it is needed
to allow KBookMarks to know we supports tabs and thus show 'Open
folder in tabs' menu item.
FIXED-IN: 19.12.1
BUG: 415549
This reverts 0995c1dc95bb0df2a04aa84e1034044448ab542e; it is needed
to allow KBookMarks to know we supports tabs and thus show 'Open
folder in tabs' menu item.
FIXED-IN: 19.12.1
BUG: 415549
Mariusz Glebocki
l10n daemon script
Andreas Sturmlechner
Ahmad Samir
Laurent Montel
Albert Astals Cid
Christoph Feck
Andrew Hou
Rajeesh K Nambiar
Arthur Kasimov
Manuel Rüger
Kurt Hindenburg
Martin T. H. Sandsmark
Tomaz Canabrava
Carl Schwan
Christian Muehlhaeuser
Wolfgang Bauer