Summary:
The `_colorRandomization` property is new in 19.12, and should be
copied by the copy constructor as well.
This fixes the problem that it was not possible to disable the
"Randomly adjust colors for each session" option again once it was
enabled.
CCBUG: 415242
FIXED-IN: 19.12.1
Test Plan:
In the color scheme editor:
Choose "Black on Random Light" and click on Edit, disable
"Randomly adjust colors for each session", and click OK.
It's saved correctly now, previously it stayed on.
Alternatively, select some other color scheme, enable the option and
click OK. Then try to disable it again. This works now, previously it
also stayed on.
Select an existing colorscheme and click on New, the new color scheme
still properly inherits the "Randomly adjust colors for each session"
setting.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D26439
(cherry picked from commit 771c1733fd)
This reverts 0995c1dc95bb0df2a04aa84e1034044448ab542e; it is needed
to allow KBookMarks to know we supports tabs and thus show 'Open
folder in tabs' menu item.
FIXED-IN: 19.12.1
BUG: 415549
This reverts commit f96deb39aa.
This was anti-optimization.
QStringLiteral is a QString created at build time. Initialization of
QString with it has no overhead.
QLatin1String is 8 bit C string wrapper which needs run-time conversion
to 16 bit encoding used in QString.
Fixes warning:
"kf5.kxmlgui: 0xXXXXXXXXXXXX deleted without having been removed from
the factory first. This will leak standalone popupmenus and could lead
to crashes."
When pasting urls of local files, remove the the scheme part, "file://",
and paste the urls as a space-separated list of local file paths, which
are quoted as needed.
Commands such as cp, mv, ls... etc, don't understand/parse the file://
bit of local urls, therefore it's more useful to strip the scheme for local
files.
CCBUG: 408813
Konsole was not opening a new tab when --new-tab is specified.
Even if we change the konsole settings to open in a unique PID,
we could open a new window sometimes.
See https://phabricator.kde.org/D25084 for KDBusAddons patch
discussion.
The old code was filtering things like characters from Private Use Area
and surrogates (used to represent code points > 0xFFFF, e.g. emojis). In
worst case, when pasted, they appear as <?>. The filter is now limited
to all control characters except TAB, CR, LF.
Summary:
This fixes the bug with tabs not indicating terminal activity.
When the tab is split and has multiple child terminals, activity in any
of the child terminals will be indicated.
BUG: 406828
FIXED-IN: 19.12.0
Test Plan:
Open two tabs, run `sleep 2` in the first one and switch to the other.
After the sleep ends, the tab activity is indicated just as it was before
the bug was introduced.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, anthonyfieroni, nucleo, konsole-devel, #konsole
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D25151