Summary:
In Qt 4, the compiler detection macros have no value, so they can't be compared
against. So just use the compiler-specific ones.
It also makes use of the fact that undefined tokens evaluate to 0 in
comparisons.
Test Plan: jriddell built it with GCC 5 and 7 against Qt 4 and 5.
Reviewers: #breeze, davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12277
Summary:
With this changes it's more clear where shadow tiles are created, also it
fixes one possible bug. For example, right now, there are two shady actors
who trigger creation of the shadow tiles:
* the first one lays inside of Style::loadConfiguration(). It creates
shadow tiles as a side effect of configuration of _mdiWindowShadowFactory
* the second one lays inside of ShadowHelper::createPixmapHandles()
Please note, ShadowHelper::createPixmapHandles() is invoked only for X11 not Wayland!
Reviewers: #breeze, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11533
Summary:
Qt has its own macro to tell the compiler that the lack of the break
statement is intentional. One of the advantages of using Q_FALLTHROUGH
is that it explicitly says other developers that the break statement is
missing on purpose. Another advantage is that we can use directives,
see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77817
Test Plan:
Compiled Breeze with GCC 7 and Clang, no "this statement may fall
through" warnings whatsoever.
Reviewers: #breeze, davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11860
Summary:
All these return statements are at the end of functions which return
nothing.
Reviewers: #breeze, mart
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11638
Summary:
The old null pointer constants(NULL, 0, etc) are converted to the
the new C++11 nullptr keyword with clang-tidy.
Reviewers: #breeze, mart
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11635
Summary: Icons are not a part of this repo anymore so delete corresponding COPYING file.
Reviewers: #breeze, mart
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11639
Summary:
QIcon::pixmap doesn't know anything about the paint device currently
being used so uses qApp->devicePixelRatio.
This works in systemsettings, but not in kwin and we get a standard
resolution pixmap returned.
We can't manually multiply by painter->device->dpr because then system
settings would get scaled twice.
QIcon::paint solves that in a way that won't break should kwin's
qApp->dpr change. Also it's IMHO cleaner as it does the alignment
internally.
BUG: 390639
Test Plan:
System settings look the same
Icon in kwin deco is crisper than before
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10713
Summary:
When a menu doesn't have any icons, space between check boxes and
text is twice as big as it should be.
Before
{F5714217, layout=center, size=full}
After
{F5714219, layout=center, size=full}
Test Plan: * open menu which has at least one checkbox and doesn't have any icons
Reviewers: #breeze, #vdg, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10584
Summary:
Added option to set transparency and blur behind menu frames such as right click context menu, toolbar menu, etc.
Transparency and blur is disabled by default.
Test Plan: {F5680253}
Reviewers: hpereiradacosta, #plasma, colomar, alake
Reviewed By: hpereiradacosta, #plasma
Subscribers: fredrik, alake, januz, abetts, colomar, andreask, zzag, ngraham, plasma-devel
Tags: #plasma, #breeze
Differential Revision: https://phabricator.kde.org/D10170
Summary:
Before
{F5714193, layout=center, size=full}
After
{F5714196, layout=center, size=full}
Test Plan: * open a context menu with icons and check boxes
Reviewers: #breeze, #vdg, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10480
Summary:
At a given moment, menu items do not have empty space on the left side.
This feels not really comfortable or "natural"(I don't know how to
express this feeling).
This revision tries to solve the problem above by reserving space for checkable
widgets. Also, it achieves consistency with macOS/Windows/Unity/etc.
Before
{F5704700, layout=center, size=full}
After
{F5708012, layout=center, size=full}
Context menus with checkable widgets(e.g. radio buttons or checkboxes) look the same
{F5708014, layout=center, size=full}
Test Plan: * open context menu
Reviewers: #breeze, #vdg, ngraham, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: januz, fabianr, mmustac, abetts, anemeth, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10438
Summary:
with the new very slim scrollbars, the rounded rectangle could
go to have a radius more than half their width, making them look
"pointy", this ensures they stay properly round
Test Plan: slim scrollbars still round, bigger ones are unaltered
Reviewers: #plasma, #vdg, hpereiradacosta, hein
Reviewed By: #plasma, hein
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10080
Summary:
the scrollbar handle will be very slim normally, and grow a bit on mouse
over, this makes it work better with QtQuickControls2 listviews where
the contents overlap the scrollbar (as other platform are going in
this direction since they all have scrollbars visible only on scroll
or mouse over)
this makes scrollbars appear more light but still always visible to
convey information
right now follows animations enabled to use this, as the scrollbar groove already did that, tough a "slim scrollbars" settings may make sense
Test Plan: works both as qwidget and with the qstyle-based qqc2-desktop-style
Reviewers: #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Reviewed By: #plasma, #vdg, hpereiradacosta, abetts
Subscribers: davidedmundson, ngraham, colomar, abetts, plasma-devel
Tags: #plasma, #kirigami
Differential Revision: https://phabricator.kde.org/D9792
Jacopo De Simoi
l10n daemon script
Ken Vermette
Fabian Vogt
Vlad Zagorodniy
David Rosca
Hugo Pereira Da Costa
Friedrich W. H. Kossebau
David Edmundson
Jonathan Riddell
Alex Nemeth
Albert Astals Cid
Bhushan Shah
Marco Martin