QTreeView animates expanding/collapsing of branches. It renders the widget into a temporary pixmap for speed
which is then animated. The pixmap's background, however, is unconditionally filled with the widget's palette's
base color which is different from the window background color onto which we paint when side panel frames are disabled.
This leads to flickering as the background is different during the animation. Depending on the colorscheme
this can be quite noticeable (e.g. Honeycomb).
Differential Revision: https://phabricator.kde.org/D7089
Summary:
With both Qt devicePixelRatio > 1 and Qt::AA_UseHighDpiPixmaps set
QIcon.pixmap() will return a bigger image than the size requested, with
the relevant devicePixelRatio set.
This code is trying to center an icon within a bounding rect, (like
QStyle::drawItemPixmap) and so positioning should use normalised pixels,
not actual pixmap pixels.
This affected Systemsettings previews but not kwin.
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6763
Surface::fromWindow are shared! By deleting the Surface pointer copies in
other areas are getting deleted as well. This breaks e.g. KWin in various
ways.
Summary:
KWin has a problem that breeze crashes it on tear down if the shadow was
created. This is due to breeze destroying the Wayland connection after
KWin destroyed it which triggers a crash in libwayland.
D6571 addresses this problem by deleting the ConnectionThread created by
plugins prior to destroying the Wayland server.
By changing the ownership of the registry and the interfaces to be
children and grandchildren of the ConnectionThread we can ensure that
KWin can clean up this area properly. For non KWin cases this doesn't
change anything, everything is still deleted as a child of ShadowHelper.
Test Plan: Ensured that the Registry gets deleted before KWin's own connection
Reviewers: #kwin, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6572
A fix I did for the focus line being drawn outside item boundaries resulted
in the item selection rectangle being "cut off" by the focus line.
The selection rectangle is enough of an indication anyway.
Differential Revision: https://phabricator.kde.org/D6544
Summary:
since from Qt 5.8 QtWayland destroys its surfaces every time
a window gets hidden and recreates them again when is shown
(that's how the protocol is defined) install the shadows
every time the window is shown, using a map to keep track of surfaces, in order to delete them on window hide and avoid leaks
Test Plan: popup menus have correct shadows on wayland now
Reviewers: #plasma, hpereiradacosta
Subscribers: anthonyfieroni, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5910
Summary:
The patch fixes progress bar color which now is always `QPalette::Highlight`. This leads to invisible bar contents for selected view items when we use `QStyleOptionProgressBar` inside item delegates. New version fixes this issue with setting `QPalette::Window` color if current state has `QStyle::State_Selected` flag.
Old version:
{F780631}
{F780630}
New version:
with `QPalette::Window`
{F780638}
with `QPalette::HighlightedText`
{F2673473}
with `QPalette::Window`
{F780637}
with `QPalette::HighlightedText`
{F2673474}
Delegate code should set correct state:
```
void MyDelegate::paint(QPainter* painter, const QStyleOptionViewItem& option, const QModelIndex& index) const
{
// ...
QStyleOptionProgressBar progressBarOption;
progressBarOption.state = option.state;
// ...
}
```
Test Plan: Tested on linux system (Arch x86_64) with Qt 5.7.0
Reviewers: #breeze, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: plasma-devel, andreaska
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3697
On a desktop with 1.5 scaling the cursor sizes 24 (factor 1) and 48 (factor 2)
are both not very well suited. Therefore add a 1.5 scaled cursor, since it's a
common scaling factor.
For that I edited the build script and rebuilt everything with it, which also
replaced some unnecessary file duplicates with symlinks.
BUG: 348603
Reviewers: #plasma
Subscribers: plasma-devel, broulik
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4358
l10n daemon script
Christoph Feck
Hugo Pereira Da Costa
Ken Vermette
Jonathan Riddell
Kai Uwe Broulik
David Edmundson
Martin Flöser
Marco Martin
Pino Toscano
Montel Laurent
Anton Anikin
Roman Gilg