- use std::unique_ptr
- removed XournalType.h
- fixed many clang-tidy warnings.
- consistently use fs::path
- mark functions override instead of virtual
This will turn recent files into a dumb list that only remembers the
chosen paths, making it more consistent with the behaviour of other
applications. Files that are removed will throw an error when opened,
reminding the user and removing them from the recents list. Files
that are not available when the application starts can be available
later [1].
[1] https://github.com/xournalpp/xournalpp/pull/2304#issuecomment-719408128
- Only update the toolbar SelectedTool's color if the Button tool is
the eraser
- set the color in the ButtonConfig also when the Eraser is triggered
(for correct highlighting of selected color in toolbar)
- rename restoreFromToolbarSelectedTool() to
pointCurrentToolToToolbarTool()
- rename setToolbarSelectedTool() to pointCurrentToolToButtonTool()
- remove class LastSelectedTool
- rename member lastSelectedTool -> toolbarSelectedTool
in class ToolHandler
- simplify logic of restoreFromToolbarSelectedTool and
setToolbarSelectedTool
- delete applyFrom from ToolBase as no used anymore
Additional Improvement:
The color and the tool type can be changed while a stylus activated temporary tool
is currently set. 🎉
New Behaviour:
- Eraser selected from toolbar:
No change of color possible anymoer as eraser does not have color and
it's not obvious for which other tool to set the color
- Eraser selected via stylus:
Allow change of color in the toolbar. This color will actually set
the tools color which was active before the button press. This makes
sense as upon release of the eraser button this tool will be selected
again.
rolandlo
Reed A. Cartwright
Azure Pipelines
Febbe
hashworks
duncan
idotobi
Roland Lötscher
pktiuk
pktiuk
Ari Breitkreuz
Archisman Panigrahi