When xmp is _running_ in the background, and then is brought to the
foreground, the program will not necessarily be notified of this state
change from external sources, as shells generally do not seem to send
gratitious SIGCONTs.
Therefore, to get keyboard input and status updates working again once
xmp is in the foreground, xmp actively needs to monitor the pgrps
itself, which this patch implements. (rsync does it the same way.)
The "foreground" variable had a double meaning (namely, whether stdin
is a tty). The state of stdin however is irrelevant for output, so we
also need to see if output is a tty. Since the status update goes to
stderr, we have to test STDERR_FILENO.
XMP misdetects who is in foreground. The parent may be an arbitrary
process within the process group and thus does not make sense to
compare to. To demonstrate the issue:
$ perl -e 'system "perl -e \"system \\\"xmp Dreamer.it\\\"\""'
XMP will not print the time status, even though there is no background
involved here. The process structure is:
$ ps f -o pid,pgrp,pgid,tpgid,command
PID PGRP TPGID COMMAND
16095 16095 19847 bash
19847 19847 19847 \_ perl -e system "perl -e \"system \\\"xmp Dreamer.it\\\"\""
19848 19847 19847 \_ perl -e system "xmp Dreamer.it"
19849 19847 19847 \_ xmp Dreamer.it
OSS does not offer software volume control, which means people always
get the maximum volume with it on sufficiently dumb hardware. Prefer
the ALSA output, which has appropriate defaults configured.
Misty De Meo warns that there's no uint8 in OSX 10.6 and earlier. Using
plain unsigned char instead.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Reported by Emanuel Haupt:
Here is a small patch for the pulseaudio option. Without it the linker
fails to find sound_pulseaudio.o.
sed -e 's|\(pulseaudio\.o\)|sound_\1|' configure
sed -e 's|\(pulseaudio\.o\)|sound_\1|' configure.ac
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
As pointed out by Jan Engelhardt, many files are missing a license notice.
Add the standard license notice to these files.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Add the --norc option to bypass configuration files. When parsing lines
in the configuration file, disable paramter matching if we're not in the
section that match the current file's MD5 sum.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Add this option from xmp 3.5.0 to handle bugs in Protracker 2.x set sample
offset command.
From: Martin Willers <y0000121@rzbcosv1.rz.tu-bs.de>
Subject: Incorrect Protrack-effect 0x09
To: xmp-bugs@helllabs.org
Date: Mon, 21 Dec 1998 05:28:48 +0100 (MET)
Reply-to: M.Willers@tu-bs.de
I've downloaded and installed the xmp-snapshot from Sun, Dec 20 today.
Don't know just how good the protrack-emulation is planned to get, but
there's a bug in the interpretation of Protracker's handling of effect 0x09
(SetSampleOffset), that causes some MODs to play incorrectly.
Original Protracker-source has some bug in handling effect 09, in that
the sample offset given in the effect byte is added +twice+ to the current
sample offset, once before playing this instrument (as is expected), and
once again after this instrument has been played! So, if on the same channel
the same instrument is played again without resetting the instrument's
parameters (eg. when just a note period is specified, but not the instrument
number again? or the other way round? :), the offset is twice as high
as one would expect.
This can be heard very easy eg. in the (very popular) song "No Mercy" by
Alf/VTL, Position #2-#3 in the sequence.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
This option passes XMP_FLAGS_FIXLOOP to the library. See README.fixloop
in the library documentation for more details.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Certain modules need specific adjustments to play correctly. It's not
possible to automatically detect these modules, so a module-specific
configuration file was added. Adjustments include: workaround for
module conversion errors, differences between protracker versions,
and custom replay parameters for specific modules.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Use the --vblank command-line option to force vblank-based timing instead
of CIA tempo setting. Needed by some modules such as Klisje paa klisje.
Needs new timing API.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Configuration file support was removed during the library conversion.
Re-add it in the player front-end, but remove module-specific config
file for now.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Make naming consistent for API calls, so:
xmp_player_start -> xmp_start_player
xmp_player_end -> xmp_end_player
xmp_player_get_info -> xmp_get_frame_info
xmp_mixer_set -> xmp_set_mixer
xmp_mixer_get -> xmp_get_mixer
Also renamed:
xmp_module_info -> xmp_frame_info
because its information is mostly about frame-specific data.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
The previous stable release of the player (xmp 3.5.0) had option -r
to reverse stereo channels. This option was temporarily removed during
libification to simplify the code base.
Reverse channels option was reimplemented by simply accepting negative
mixing parameters.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Port the configuration file reader from xmp 3.5 to 4.0. Module-specific
configuration still not ported.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Default interpolation algorithm set to cubic spline. Also remove direct
option --nearest/-n to set nearest neighbor interpolation.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Follow Mirko Buffoni's advice to add extra mixers with better interpolation
algorithms. Start adding cubic spline based on Storlek's implementation, still
need to fix sample allocation values to prevent violations when reading
the -1 PCM data.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Add DSP flags to mixer and generalize the existing lowpass filter as a
DSP effect. Reverb and chorus effects (used in e.g. IMF) can be added
to the list later.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Jan Engelhardt
Claudio Matsuoka