This yields several benefits:
- The action automatically goes into the header in the system tray
representation, which improves the presentation
- We get a context menu action for it for free, which is a nice
accelerator for experts
Commit bcaf3886 removed the property `m` in UserDelegate.qml, but it is still used by
`userListCurrentModelData` in SessionManagementScreen.qml at least.
This broke switching to an existing session via the "Switch User" button on the lock screen or the
application launcher/menu, it just hung with an empty screen and this runtime error in the logs:
file:///usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/LockScreenUi.qml:444: TypeError: Cannot read property 'vtNumber' of undefined
Adding it back makes switching work again (and gets rid of the runtime error).
CCBUG: 423526
FIXED-IN: 5.20.3
the comboboix of a very rarely used feature right
in the header area is super noisy, looks misaligned and puts the feature
in a too much prominent role.
Put everything under a popup menu, mustually exclusive actions will be
shown as radiobuttons
The test for whether "/auto" is supported was bogus.
QDBusAbstractInterface::isValid effectively just confirms the service
exists and the path is a legally valid name, not that it has any
interfaces there.
This means the fallback path is not run appropriately.
BUG: 423526
The code is meant to add the entry if it's valid, then watch for
changes. Somehow we end up only monitoring if it was valid initially.
This doesn't make sense.
This means if the menu loads before the backend we don't update
correctly when it does load.
CCBUG: 423526
BUG: 427779
In the past, this applet naively passed the URL to KRun when clicked on
or something was dragged on top of it. However during porting away from
KRun, it was ported to KIO::ApplicationLauncherJob, which only handles
applications, not other types of URLs.
This commit fixes that by making it use KIO::OpenURLJob (which can
handle applications as well as arbitrary URLs) when it's clicked on. We
also short-circuit the application-specific logic when something is
dragged on it and it's not an application, which allows the
non-application logic to be reached.
BUG: 427797
FIXED-IN: 5.20.3
So one can, for instance, quickly delete an unwanted screenshot.
It follows the usual Trash context menu actions, i.e. move to trash is only
shown for local files and locations that support moving, Delete is shown for
remote locations or when enabled in settings.
Swapping of the action when holding Shift is not implemented.
BUG: 428159
FIXED-IN: 5.21.0
This reverts commit 5926da56e5.
This commit breaks configuration with a CMake error. Please test your
changes before pushing.
CCMAIL: butirsky@gmail.com
We want to last until all jobs are finished and the notification sound
thread has finished. The design intention was to let QEventLoopLocker
handle all of it implicitly, but that doesn't work when we call quit
explicitly.
BUG: 422948
The old code took a pointer to an opaque object then tried to find
matching properties.
Use of aliases makes things clearer. It should also help if someone adds
a property to OSDItem again.
Mikel Johnson
l10n daemon script
Nate Graham
Thiago Sueto
Wolfgang Bauer
Niccolò Venerandi
Marco Martin
David Redondo
David Edmundson
Aleix Pol
Miklós Máté
Fabian Vogt
Michail Vourlakos
David Faure
Kai Uwe Broulik
Benjamin Port
Laurent Montel
Andrey Butirsky
Lamarque V. Souza
Alexander Lohnau
Konrad Materka