Summary:
Currently the avatar in the logout screen is noticeably smaller than the avatar in the lock and logout screens.
This patch roughly bases the size value on what is produced in the lock and logout, and then applies it to the logout screen.
Test Plan:
Before (logout screen):
{F7680624}
After (logout screen):
{F7680632}
Before (lock screen):
{F7680634}
After (lock screen):
{F7680635}
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: davidedmundson, ngraham, plasma-devel
Tags: #plasma
Maniphest Tasks: T11093
Differential Revision: https://phabricator.kde.org/D25024
Summary:
The file path of the main script is hard-coded to ui/main.qml, so setting
X-Plasma-MainScript is pointless.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25201
In b7b25010aa the import line was changed
but nothing else was, causing errors in QML loading which ultimately
prevented SDDM from loading the theme.
BUG: 414252
CCMAIL: i@guoyunhe.me
Summary: Lower QQC2 version to minimum requirement. Add context to i18nc function. Cannot use `i18ncp` because the number isn't integer.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25319
Summary:
The TableView in digital clock widget time zone configuration is replaced with ListView. Other UI didn't change.
{F7635385}
Reviewers: #plasma, #plasma_workspaces, ngraham
Reviewed By: ngraham
Subscribers: GB_2, ahiemstra, broulik, kmaterka, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24798
Summary:
Most group have icons, this one did not. A new icon just got created for
all applications, it makes sense to be consistent.
This has no effect in the kicker-dash as that does not show icons, nor
kicker/kickoff as they don't show the all applications group.
Only third party menus will be affected.
Test Plan:
Looked at my custom menu
Looked at kicker-dash
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25294
Summary:
QQC2 StackView has a major behavioural difference
QQuickStackViewPrivate::setCurrentItem
item->setFocus(true);
This as a general rule makes sense, especially if you're pushing a whole
focus scope onto the stackView, it would automatically select the right
element. However as our base was not a focus scope the
SessionManagementScreen instance itself got focus, taking it away from
the child password box.
LockScreenUi has to be changed so that it sets the initial focus the
same even though the stackview is on QQC1.
Test Plan:
qmlscene in the sddm-theme directory with the dummydata setup
locked the screen regularly
Lots of gammaray
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: davidre, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25261
Summary:
--when the containment background hints are updated then the
panel shadows should be also. In case the background hints
point to NoBackground the panel shadows should be removed
and in case they point to DefaultBackground they should be
drawn again
--PanelShadows::removeWindow has no place in updateEnabledBorders
because the window still lives. When removeWindow was executed
before it was faulty unregistered from PanelShadows and in order for
setEnabledBorders to work again we should need
to execute from start the PanelShadows::addWindow function
Test Plan:
--I have created an applet which a PlasmaComponents.Switch button
and toggles panel transparency on user demand easily
Reviewers: #plasma, davidedmundson, mart
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25121
Summary:
Adding support for Attention Icon to StatusNotifier tray icons.
Binding is working correctly only when "Status" is used, not derived "status".
BUG: 341255
Test Plan: As described in bug report, Konversation can be used for tests.
Reviewers: #plasma, broulik, #plasma_workspaces
Reviewed By: #plasma, broulik, #plasma_workspaces
Subscribers: lbeltrame, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24865
Summary: This failed for me on FreeBSD where env doesn't support -0. Fall back to genv which does.
Reviewers: fvogt, adridg, apol
Reviewed By: fvogt, apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25124
Summary:
This allows devs to run: "make clang-format" and format all files easily
using the preset KDE clang format style
This patch adds support so devs can easily test the intended formatting
now, it doesn't change the code yet..
If this patch is accepted I'll treat it as being accepted for all Plasma
repos. Doing an initial run to commit everything will happen later.
Test Plan:
Ran script
git diff was full of amazingly cleaned code
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25134
Summary:
Currently the code that draws plasmoid popups utilizes an anchor based approach.
I think layouts are a more elegant solution so this patch makes use of them.
Test Plan:
{F7616902}
{F7616901}
{F7640510}
Reviewers: #plasma, #vdg, ngraham, mart
Reviewed By: #plasma, #vdg, ngraham, mart
Subscribers: safaalfulaij, manueljlin, ognarb, ngraham, kmaterka, mart, GB_2, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24720
Summary:
Kwin had to have two ICE connections in order to track state
indepdendently of it's session saving.
This replaces that with a more direct DBus protocol allowing for both
simplification on the kwin side as well as comunicating the logout state
better for effects.
Whilst this code temporarily complicates things, now we have this
interface the next step is drop all the isWM() stuff and do kwin
specific session management also over this interface. See T11882
Test Plan:
Added qdebug into kwin
started logging out with an unsaved file, cancelled shutdown
started logging out with, discarded file
Reviewers: #kwin, apol
Reviewed By: apol
Subscribers: broulik, apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24945
Especially for the custom one it's useful to have a live preview rather than trial and error with the Apply button.
Differential Revision: https://phabricator.kde.org/D25091
Summary: It may be used through KNotifications
Test Plan: Builds
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25093
Summary:
It was written with properties and signals intended for direct QML use.
This should be a step towards removing the plugins in the session
applets in kdeplasma-addons.
Test Plan: Used in a qml file
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25048
Summary: "Edit Panel..." already enters the edit mode, so there's no need to clutter the context menu with another "Customize Layout..." menu item.
Test Plan: Open the panel context menu.
Reviewers: #plasma, #vdg, mart, ngraham
Reviewed By: #plasma, #vdg, mart, ngraham
Subscribers: mart, #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25053
Summary:
There was a concious decision that when we add a new wallpaper we should
append to the existing random order collection, rather than shuffle
existing ones.
The logic is fine but if we start with 0 wallpapers and then add 20 new
ones we don't shuffle anything.
This patch changes it so when a new batch of N wallpapers is added,
those N are shuffled when appending to the existing sort order.
BUG: 413463
FIXED-IN: 5.17.2
Test Plan: qDebug + ran a few times
Reviewers: #plasma, ngraham, davidre
Reviewed By: ngraham, davidre
Subscribers: davidre, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24986
Summary:
Otherwise when we randomise the wallpaper order we will always get the
same results.
CCBUG: 413463
Test Plan: qDebug + ran twice
Reviewers: #plasma, ngraham, davidre
Reviewed By: ngraham, davidre
Subscribers: davidre, apol, anthonyfieroni, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24985
Summary: Not needed for normal users with the new edit mode system.
Test Plan: Lock the widgets before compiling this patch. Then compile with it, unlock widgets and see that there is no lock option in the panel context menu.
Reviewers: #plasma, #vdg, ngraham, mart
Reviewed By: #plasma, #vdg, ngraham, mart
Subscribers: broulik, mart, ngraham, #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24839
Summary:
Fixed issue when time zone configuration page was not scaling corrently. As a result two
srollbars were rendered.
Fixed few QML layout warnings and undefined references.
Test Plan:
Open Time zones configuration page and shrink window - two scrollbars are rendered.
Expected: table is scalled correctly and only one scrollbar in table is rendered.
Reviewers: #plasma, #plasma_workspaces, ngraham
Reviewed By: ngraham
Subscribers: ngraham, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24853
Filip Fila
l10n daemon script
Vlad Zahorodnii
Luca Beltrame
Guo Yunhe
David Edmundson
Laurent Montel
Kai Uwe Broulik
Michail Vourlakos
David Redondo
Konrad Materka
Fabian Vogt
Aleix Pol
Björn Feber
Nate Graham
Jonathan Riddell
Marco Martin