Summary:
Also set a consistent naming structure and to be only Info+ by default.
This may mean you need to update your logging rules if you want debug
output.
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: graesslin, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1956
Summary:
Width should not include top and bottom margins
BUG: 364543
FIXED-IN: 5.7
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1966
Rather than showing the generic calendar icon the day number is shown there instead.
There is also an option to have it show the week number instead.
FIXED-IN: 5.7.0
BUG: 343467
Differential Revision: https://phabricator.kde.org/D1867
There's no point in loading a massive album art (I've seen music files having
sizes of up to 1500x1500) just to show it scaled down again.
Also changes the binding from playerCombo.visible to playerCombo.count so it doesn't
change the sourceSize causing a reload of the image whenever the applet gets hidden/shown
since visible propagates recursively
When you click an item it might show a menu of some sort which will grab the mouse
and the ToolTipArea never gets a leave event causing the tooltip to show up above
the menu.
Differential Revision: https://phabricator.kde.org/D1847
Instead of having a bunch of handlers in various places messing with various settings,
try to use declarative bindings where possible.
* Remove separate passive timer, instead re-use the pendingDelegateRemoval property
which has its own timer. This way, when a device is unmounted, device notifier stays
active until the notification has cleared, however, when the device is yanked out manually,
it disappears right away
* Don't break binding on Plasmoid.active to ensure its state is always proper depending on
whether a device or not is present (the linked bug)
* Create tooltip declaratively rather than imperatively
BUG: 362992
FIXED-IN: 5.7.0
Differential Revision: https://phabricator.kde.org/D1793
Summary: Not sure how to trigger it, but gdb was clear about the issue.
Reviewers: mart, davidedmundson
Reviewed By: mart, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1826
181869e636b415cdf84eeeb98a5359186721b368 in plasma-framework removed
compatibility code for loading plugins. This was apparently still used
by the notification plasmoid, which caused it not to be loaded.
Removing the stray entry makes it load (test plan: plasmoidviewer -a
org.kde.plasma.notifications).
CCMAIL: faure@kde.org
An enum value is used that does not exist in the current release.
We only need to show that it is neither a Panel nor Desktop, so
hardcoding the upcoming value will work.
Reviewed by Marco Martin.
don't hardcode -a as the internal systray screen anymore.
give it the new customembeddedcontainment containment type,
and ignore those in panel creation.
the old systray logic in containmentforscreen gets reused.
The change back to a MouseEventListener broke notification actions because
its onClicked handler would fire before the action buttons closing the
notification before it had a chance to trigger the action.
Differential Revision: https://phabricator.kde.org/D1578
This avoids picking a black and white icon like it would for KMail.
Neither Task Manager nor Kickoff use plasma theme icons for applications.
Differential Revision: https://phabricator.kde.org/D1745
Instead of allocating a temporary list just to iterate over it and then
performing a value() lookup, just use iterators instead.
Differential Revision: https://phabricator.kde.org/D1705
Changing calendar plugins and holidays regions now enables Apply
button in configuration and correctly saves it.
Differential Revision: https://phabricator.kde.org/D1651
With KIOSK restrictions it can happen that a context menu would be empty.
In this case just a shadow would show up. Do nothing then.
Differential Revision: https://phabricator.kde.org/D1627
This fixes showing "0% charging" on a desktop computer which has a
wireless mouse/keyboard. If there is no battery whatsoever it continues
to show "No batteries available" but for the aforementioned case the
generic "Battery and brightness" is shown in order not to lie to the user :)
CHANGELOG: Battery tooltip no longer shows "0% charging" for computers with wireless mouse/keyboard
BUG: 362924
Reviewed-By: mgraesslin
This fixes the battery icon errorneously showing an empty red battery on a desktop
computer with a wireless mouse/keyboard; instead the "no battery" icon with a
red cross is shown.
CHANGELOG: Battery icon no longer errorneously reports an empty battery if computer has none
CCBUG: 362924
Reviewed-By: mgraesslin
The model has changed and is now created in JS but the code that changes the shortcuts was never adjusted
Differential Revision: https://phabricator.kde.org/D1567
Fills the big block of empty space with some nice string.
"No events for today" when today is selected and "No events for this
day" when other day is selected.
REVIEW: 127818