Summary:
Also set a consistent naming structure and to be only Info+ by default.
This may mean you need to update your logging rules if you want debug
output.
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: graesslin, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1956
Summary:
Width should not include top and bottom margins
BUG: 364543
FIXED-IN: 5.7
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1966
This is a pretty big behavior change vs. libtm-old, and upon reflection
probably better done early in the 5.8 cycle to find out how deeply users
expect the old behavior.
This reverts commit f542116cc2.
We don't show a startup notification if we already have a matching
window -- however, this test was done against all window tasks, even
if some of them are being filtered out (e.g. by virtual desktop).
Now "do we have a window?" is checked against the filtered window
tasks, so a startup notification for $app is shown even if $app
already has a window on a different desktop.
When a launcher was removed, the cache was invalidated at the time the
top-level proxy removes the row for it. However this happens in
response to rowsAboutToBeRemoved from the source model, at which time
launcherList() still contains the launcher at the row about to be
removed. While invalidating the cache in response to rows being removed
from the top-level proxy is correct (for the case where a window task
shadowing a launcher is removed), to handle a launcher removal we also
need to invalidate it when the launcher list changes.
CCBUG:364537
This is an unfortunate regression that crept in via 7eff45a98f the
just the other day: Legacy config can have query items other than
iconData in launcher URLs, which also need to be stripped before doing
the equivalence test matching up launcher-backed window tasks with
launcher URLs. Back to venerable launcherUrlsMatch() as originally --
the real speed optimization is in fetching the right role, anyway, and
as it turns out we really can't save that one call to adjusted() as it
was necessary.
BUG:364492
Summary:
Changes the test from "client rect intersects with screen rect"
to "screen that contains the center of the client+deco rect or
screen this point is cloest to".
This is a behavior change also vs. libtaskmanager-old and should
address user bug reports like bug 364280.
BUG:364280
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1925
Summary:
Makes the API more complex, but it's worth it as it allows
knowledgable users to opt into avoding costly work and/or
data copies in very common use cases.
Significantly speeds up a lot of work in the models in the
presence of X apps that can't be identified and fall back to
the window icon.
Based on profiling by David.
Reviewers: dfaure, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1920
We are told the start and end date but we didn't actually add the event to the other days.
BUG: 364345
Differential Revision: https://phabricator.kde.org/D1891
Summary: Second half of the merge of the functionality found in Netrunner's EITM fork.
Reviewers: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1895
"new KRun" is only meant to run absolute file paths and so breaks when we get a
service with relative entryPath() like when finding a KCModule.
The tempFile argument causes this call to be asynchronous as to not block the UI
Summary:
qDeleteAll will iterate through containments() however this is
dynamically changing the list we're iterating through.
Particularly bad is deleting the panel might delete the system tray
containment, leading to a double delete on a now dangly pointer.
Test Plan: kquitapp5 plasmashell. No crash
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1890
Rather than showing the generic calendar icon the day number is shown there instead.
There is also an option to have it show the week number instead.
FIXED-IN: 5.7.0
BUG: 343467
Differential Revision: https://phabricator.kde.org/D1867
There's no point in loading a massive album art (I've seen music files having
sizes of up to 1500x1500) just to show it scaled down again.
Also changes the binding from playerCombo.visible to playerCombo.count so it doesn't
change the sourceSize causing a reload of the image whenever the applet gets hidden/shown
since visible propagates recursively
Summary:
On Wayland we need special glue code to make KWin aware of the position
the DesktopView wants to be. This change ensures that DesktopView calls
setPosition on the PlasmaShellSurface on creation and whenever the screen
geometry changes.
With this change DesktopViews are properly positioned in a multi-screen
setup on Wayland.
Reviewers: #plasma_on_wayland
Subscribers: plasma-devel
Tags: #plasma_on_wayland
Differential Revision: https://phabricator.kde.org/D1889
Summary:
When grouping inline, the group subtrees are flattened out into
the top-level list, parents removed, and move() treats groups as
singular entities.
This functionality was previously found in Netrunner's Expanding
Icons Task Manager fork.
This is the first half of the EITM functionality merge.
Reviewers: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1881
We only show the "Remove this applet" option when the panel controller is opened
to prevent the user from accidentally messing up his setup.
However, the "Remove this panel" option, albeit in a submenu, was always there and
is even more destructive.
BUG: 360300
Differential Revision: https://phabricator.kde.org/D1869
The check was supposed to check whether kinit would start and exit otherwise.
By adding the qdbus call inbetween, it would check for that one instead and if
no ksplash was running the exit code would be non zero aborting startup.
Differential Revision: https://phabricator.kde.org/D1888
When rendering SVGs through Image you need to provide a sourceSize.
This sourceSize needs to be scaled with device pixel ratio to ensure crisp rendering.
David Edmundson
Eike Hein
l10n daemon script
Kai Uwe Broulik
Alexander Potashev
David Faure
andreas kainz
Martin Gräßlin