setGlobalShortcut sets the default shortcut and binds the current shortcut
to the action. It will not overwrite the current shortcut if the user configure
a different one.
(cherry picked from commit 78ca6af183)
- Increase the size of next/previous media toolbuttons. I didn't think there was enough padding around the buttons here.
- Set a default width and height of LockScreen.qml. This makes it start with a sane default size when run with qmlscene.
(cherry picked from commit 99475b09a5)
same as 5a648c56eb for the service runner.
Kservice internally will hold a KDirWatch instance through KSycoca and
that instance has an inotify instance. Since inotify instances have a
per-user limit we mustn't be wasteful with them. Since our runner
threads do not actually need automatic ksyscoca reloading (reloading
on-demand as we use ksyscoca is perfectly reasonable) we need to
explicitly disable this feature so the internal inotify instance can be
freed.
CCBUG: 423818
(cherry picked from commit 783e856ea0)
I apparently forgot to add some other changes...
Also show it only when threshold is > 0 %
BUG: 426743
FIXED-IN: 5.20.0
(cherry picked from commit 27e3cfcac0)
Calling a V2 method when our proxy is just at V1 is a fatal error.
This wasn't guarded. V2 isn't implemented fully anyway.
BUG: 424709
(cherry picked from commit 97f4599ac1)
Right now it is deliberately setting the margins to zero, which causes
all of its UI controls and framed areas to touch the window border,
which looks bad and is just an incorrect thing to do in general for a
thing that does not deliberately provide its own margins for content.
Let's not do that anymore, so the window looks better.
BUG: 426661
FIXED-IN: 5.20
(cherry picked from commit 42e2078cfd)
At the moment, in the battery widget, the slider displays the brightness of the screen, but
it doesn't have text labels, so it's quite difficult to determine the brightness of the
screen. Adding a label over the slider that will display the current screen brightness as a
percentage will make this applet more descriptive and handy.
The connection to the lambda persists, so when it's called a second time,
the lambda is also called twice, eventually resulting in a nullptr deref as
m_restoreSessionCall is empty.
Commit 19c06e7293 removed setting dpy,
but it is still used in the NewKDM and OldKDM code branches.
So set it again, and add a check that it's not empty where relevant.
this frees the internal per-thread inotify instance used to watch
database changes meaning runner applications no longer claim N inotify
instances (N=size of threadweaver pool).
the database is still reloaded by ksyscoca internally if it finds the
backing file has changed.
CCBUG: 423818
Some users reported this button becoming too small after KF5.74 was released, but I could not reproduce it myself. However, this code did look suspicious. Hopefully this fixes the issue.
- Use range-for/for_each algorithim
- Less implicit casting from ASCII
- Use string comparision instead of QRegExp, the former is usually faster
- Replace one letter var names with slightly longer ones
ShellCorona is a messy class doing mulitple functions.
This patch splits out all telemetry code into a new class, meaning it's
easier to extend. Code remains the same.
kcms are handy but not nearly as handy as an actual application. this is
particular notable with the test case where the user could type 'virt'
but that wouldn't have pushed virtualization software to the top but kcms
since kcms are kde things so they always get a .09 bump to
relevance.
the revised scoring excludes kcms from the bump and further reduces the
relvance by the tiniest fraction. this results in all applications that
match at least as well as the KCM to outscore the KCM
When we moved fonts kcm to this repository this find_package call was
missing appearantly since this was not in top-level KCM(!).
Add this find_package call here, so it finds it correctly and fonts kcm
and kfontinst gets built correctly
Currently when we invoke KRunner and it is already running we will start binary,
KDBusService will check if it is already registered and then call
org.freedesktop.Application.Activate. Cutting the middle out should improve the
time that it takes to show KRunner and make it less likely that key strokes are
lost. If KRunner is not running we, can rely on dbus activiation to start KRunner.
Unfortunately we cannnot call Activate with dbus-send because it doesn't support
it's argument type. Instead we can just use the existing display method.
CCBUG: 416145
Aggregate text for KRunner in DesktopView to prevent eating fast-typed characters.
CCBUG: 416145
partial solution: resolved for DesktopView, not resolved for running KRunner from shortcut
Test Plan:
When DesktopView is focused, typed characters show KRunner query.
All fast-typed characters should now appear correctly in KRunner window,
instead of only first typed character.
Simplifies the logic of the busy indicator since now it will already
fade out when it's not running.
Also addresses the logic of the timer which was off.
This made krunner freak out on Wayland for some reason to investigate,
both opacity animations were triggering a repaint and we tried to render
too often making the process block. With this change it works fine
again.
David Redondo
l10n daemon script
Noah Davis
Harald Sitter
Kai Uwe Broulik
David Edmundson
Fabian Vogt
Nate Graham
Alexander Lohnau
Bart Ribbers
Bhushan Shah
Eugene Popov
Niccolò Venerandi
Wolfgang Bauer
Ahmad Samir
Piotr Henryk Dabrowski
Aleix Pol
Yuri Chornoivan