Summary:
Restore the previous hack we had in old themes; but now it's
investigated properly.
Interestingly, a completely different bug to the lock screen.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2559
Focus is drawn away from the TextField when requesting unlock to work around a Qt bug.
However, when unlocking fails, the focus is not restored to the TextField.
Also, select all in the TextField in this case so you can quickly type anew and disable it
while grace locked.
Differential Revision: https://phabricator.kde.org/D2558
Summary:
loader is a focus scope, so within the root items focusscope, there
is no item with focus. So the initial focus doesn't get set on anything.
Test Plan:
QT_LOGGING_RULES=qt.quick.focus.debug=true
and gammaray
also tested by actually locking the screen
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2556
Summary:
Currently ksmserver sends DBus calls to klauncher to autostart services.
This patch brings all autostarting into the ksmserver process, putting
all autostart code together, and improving Plasma/Frameworks separation
(change requested by David Faure) with the long term goal of removing
this from klauncher; with a longer term goal of maybe even killing
klauncher.
We don't get two things autostarting as without ksmserver sending the
signals, klauncher does nothing.
Autostart.cpp code is copied verbatim so there's no breakage.
Test Plan: Logged in, got plasma and krunner and so on.
Reviewers: #plasma, graesslin
Reviewed By: #plasma, graesslin
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2544
Summary:
Positions the shutdown dialog in the absolute space if there is the
PlasmaShell interface.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2445
The function doesn't use it and it's not called that way in the onAccepted handler of the TextField.
Differential Revision: https://phabricator.kde.org/D2548
Summary:
We are providing the parent if it is a QWidget, but still,
there is no need to have this window remain in memory
after closing.
If the parent is not a QWidget, this is a memory leak.
Reviewers: mart, #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2549
Summary:
Leave action is checking on canLockScreen to enable the action instead of Lock action.
Fix the mistake so now Lock action is checking for canLockScreen and Leave action not anymore.
Test Plan: Lock action is now checking for canLockScreen and Leave action not anymore.
Reviewers: #plasma, sebas
Reviewed By: #plasma, sebas
Subscribers: plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2529
Summary:
Leave action is checking on canLockScreen to enable the action instead of Lock action.
Fix the mistake so now Lock action is checking for canLockScreen and Leave action not anymore.
Test Plan: Lock action is now checking for canLockScreen and Leave action not anymore.
Reviewers: #plasma, sebas
Reviewed By: #plasma, sebas
Subscribers: plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2529
Summary:
The previous approach of having an array of object that
hold information about the current config group and the config keys
and values was not really scalable nor intuitive.
Now, the config is an object that has the group names as keys,
and each group has its own configuration (key, value) pairs.
The config groups are identified as a unix-like path
Reviewers: #plasma, mart
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2516
Summary: change the logout screen to the new design: user avatar and action buttons shared with SDDM, old custom files removed
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2502
Instead use QImageReader to get the glob patterns of all supported formats,
similar to what the "Open image" dialog in the regular image wallpaper did.
Also, make use of QDir::setNameFilters rather than manually filtering out non-matching files.
Differential Revision: https://phabricator.kde.org/D2511
Summary:
This means if it's used elsewhere (for example the logout screen) we
don't create a pointless attached QObject.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2503