Summary:
Connecting to QObject::destroyed with Qt::QueuedConnection *should*
crash, when you use the object that's been deleted. it doesn't make any
logical sense.
The only reason it doesn't is because of another hack in Plasma-
framework where containment.cpp where containment emits
QObject::destroyed (yes really) before the actual destruction.
Unfortunately we can't fix the hack in frameworks till we fix this hack
round the original hack here.
This patch ports it to a different signal, which is emitted before
object teardown without hacks.
Test Plan: checked debug appeared when deleting a panel
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2570
Summary:
Otherwise Solid ejects a device
Plasma removes the device from the notifier
The notifier kills SolidDeviceService (directly)
That kills the SolidDeviceJob
This leaves SolidDeviceJob still in the middle of SolidDeviceJob::start() with "this"
now referring to a dangling pointer.
BUG: 361450
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2623
internalSystray is (for some reason) only set in Component.onCompleted.
This fixes the warning this causes.
Differential Revision: https://phabricator.kde.org/D2608
Set avatarPath to the user avatar and iconSource to the fallback icon.
With the different margins it became apparent that it was rendering the avatar through IconItem.
Differential Revision: https://phabricator.kde.org/D2612
Summary:
Commit d7c230ab19 changes the window to
fill the screen.
However it left dead code in shutdown dialog which was also
repositioning it - and worse...positioning it in a different place
which is just a mess.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2619
Summary:
This (optionally) appends an entry to the SessionsModel to append a "New
Session" option. The lock screen / user switcher are then modified to
use it.
Messages.sh is modified so all components are covered by the same pot.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2594
SessionManagementScreen already has this very same label and the notificationMessage populates it.
The one in the Lock Screen was unused.
Differential Revision: https://phabricator.kde.org/D2572
This prevents a wide notification message (like caps lock on while unlocking failed)
to affect the controls below it.
Differential Revision: https://phabricator.kde.org/D2573
Summary:
This is clearly some upgrade code from many years ago - before Plasma 5.
Gets rid of a whole lot of deprecated function calls (and a unsigned vs
signed int wraning
Test Plan: make
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2579
Summary:
KWin starting with 5.7 supports struts on panels between screen edges.
Thus we can start setting struts on such panels, it won't exclude a
complete screen. But we don't know how other window managers handle it
and it's in general a rather "dangerous" change.
Thus to not affect other window managers, we check whether KWin is
running and only allow struts on thus panels if KWin is running.
Unfortunately we need to test this every time we go into the code path
as the WM might have changed.
In case the user replaces the window manager at runtime this still can
result in a bad situation.
BUG: 94470
FIXED-IN: 5.8.0
Test Plan:
Tested whether it works in general in X11. Further testing
needed by X11, multi-screen users.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2164
Summary:
Restore the previous hack we had in old themes; but now it's
investigated properly.
Interestingly, a completely different bug to the lock screen.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2559
Focus is drawn away from the TextField when requesting unlock to work around a Qt bug.
However, when unlocking fails, the focus is not restored to the TextField.
Also, select all in the TextField in this case so you can quickly type anew and disable it
while grace locked.
Differential Revision: https://phabricator.kde.org/D2558
Summary:
loader is a focus scope, so within the root items focusscope, there
is no item with focus. So the initial focus doesn't get set on anything.
Test Plan:
QT_LOGGING_RULES=qt.quick.focus.debug=true
and gammaray
also tested by actually locking the screen
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2556
Summary:
Currently ksmserver sends DBus calls to klauncher to autostart services.
This patch brings all autostarting into the ksmserver process, putting
all autostart code together, and improving Plasma/Frameworks separation
(change requested by David Faure) with the long term goal of removing
this from klauncher; with a longer term goal of maybe even killing
klauncher.
We don't get two things autostarting as without ksmserver sending the
signals, klauncher does nothing.
Autostart.cpp code is copied verbatim so there's no breakage.
Test Plan: Logged in, got plasma and krunner and so on.
Reviewers: #plasma, graesslin
Reviewed By: #plasma, graesslin
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2544
l10n daemon script
David Edmundson
Marco Martin
Kai Uwe Broulik
Burkhard Lück
Eike Hein
Ivan Čukić
Martin Gräßlin
Yuri Chornoivan
Heiko Becker