Summary:
If a slot or Q_INVOKABLE has a QVariant as parameter and gets called
from a QJSEngine's script, it receives a QJSValue wrapped as QVariant.
To get a QVariant with the actual value wrapped, calling QJSValue::toVariant
is necessary.
I'm not entirely sure whether this is intentional behaviour of QJSEngine, but
even if it's a bug we'll have to workaround it.
BUG: 397338
Test Plan: I have favorites in kickoff again.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D14822
Since we have a unified screen for logging out and shutting down, the hint is always shown as the user could click on "Logout"
but then shut down anyway.
Differential Revision: https://phabricator.kde.org/D14905
If a destination file name is present, it is a better label for a job
than the source file name. This is particularly true for web downloads
where the source file name may be a gibberish base64 string while the
destination file name would be selected by the user.
If there is no destination file name, we fall back to using the source
file name.
BUG: 396744
Differential Revision: https://phabricator.kde.org/D14857
It takes almost 30ms here to create the engine and then we usually don't end up using
it as all update scripts had already been processed in the past.
Differential Revision: https://phabricator.kde.org/D14751
On teardown with the popup expanded, the cleanup handler might fire with us already having been deleted.
BUG: 397105
FIXED-IN: 5.12.7
Differential Revision: https://phabricator.kde.org/D14651
For KCMs we get a relative entryPath() for our KService resulting in an invalid URL being created.
CCBUG: 397070
Differential Revision: https://phabricator.kde.org/D14546
Summary: The Qt bug that makes `Text.NativeRendering` look terrible with non-integer scale factors (https://bugreports.qt.io/browse/QTBUG-67007) is still a problem, so we need to apply the same workaround here that we previously applied to all the PlasmaComponents.
Test Plan:
No visual change at 1x scale. Looks much better at 1.5x scale.
1.5x scale, before:
{F6136688}
1.5x scale, after:
{F6136691}
Reviewers: #plasma, davidedmundson, broulik
Reviewed By: #plasma, davidedmundson, broulik
Subscribers: broulik, svenmauch, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D14347
We don't merge URLs and it probably doesn't make sense with the way grouping is currently implemented.
BUG: 396741
FIXED-IN: 5.12.7
Differential Revision: https://phabricator.kde.org/D14287
Summary: Use Breeze's new broom-style icon for the {nav Clear History} buttons in the Klipper and Notification plasmoids.
Test Plan:
With Frameworks 5.48, the broom-style icon will be shown:
{F6100570}
{F6103810}
With an earlier Frameworks version or a different icon theme, a backspace-style icon will be displayed:
{F6100573}
Reviewers: broulik, Fuchs, #plasma, davidedmundson
Reviewed By: Fuchs, #plasma, davidedmundson
Subscribers: Zren, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D14105
The circular avatar is a custom ShaderEffectItem and as such does not work with software rendering.
This is only used as a fallback for when the lock screen crashes because of e.g. graphics drivers anyway
Differential Revision: https://phabricator.kde.org/D14051
KDisplayManager::bootOptions only worked with "NewKDM" but KDM is obsolete in Plasma 5.
Creating an instance of KDisplayManager does DBus stuff to find out the DM being used.
Also, kdmrc is dead and this code always returned None anyway.
Differential Revision: https://phabricator.kde.org/D13998
Solid's UDisks backend never emits the Solid::OpticalDrive::ejectPressed signal.
It is only present in HAL whereas Linux uses UDev these days.
Differential Revision: https://phabricator.kde.org/D13752
Summary:
This change allows users to scroll through krunner output using their homerow.
- Ctrl+j: Scroll Down
- Ctrl+k: Scroll Up
This makes scrolling easier for those familiar with this convention but doesn't inhibit users who aren't.
Reviewers: broulik, #plasma_workspaces, davidedmundson
Reviewed By: #plasma_workspaces, davidedmundson
Subscribers: davidedmundson, #plasma_workspaces, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13686
Summary:
On X, this is entirely useless.There's a special code path in create for
windowType == Desktop and in ::setGeometry it doesn't seem to help/hinder.
It's not like we need WM_NORMAL_HINTS for a WM to resize us.
On wayland it's downright destructive.
On the second setGeometry call the QPA bounds the new geography to the
current min/max (from our previous screenGeometryChanged). But updating
the min/max doesn't update our geometry. End result is our screen is
off.
Test Plan:
Resized screen on Wayland. Wallpaper now filled exactly instead of being broken
Resized screen on Xcb. Wallpaper still filled the screen precisely
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13850
l10n daemon script
Fabian Vogt
Kai Uwe Broulik
Karthik Periagaram
Jonathan Riddell
Nathaniel Graham
Laurent Montel
Bhushan Shah
Michael Eden
Алексей Шилин
David Edmundson