Summary:
This patch makes the wallpaper chooser grid view delegates show the wallpaper's
title (if it has a desktop file) or filename (if it doesn't). Authorship information
is shown via a tooltip, if present.
Test Plan:
{F6587535, size=full}
{F6587536, size=full}
Reviewers: #vdg, #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18737
Summary:
QML shadows aren't supported with software rendering, so the white text often has poor readability.
This patch falls back to outlines when using software rendering to ensure adequate readability.
BUG: 398317
FIXED-IN: 5.15.0
Test Plan:
No visual change with hardware rendering of some sort.
When forcing software rendering, I get outlines instead of shadows
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18733
Summary:
Update and improve some old Breeze Look and Feel theme previews (the Breeze Dark previews will be updated in a different revision, because they are in a different repo).
{F6584513}
Test Plan: Open the Look and Feel KCM and the Splash Screen KCM.
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: abetts, ngraham, rooty, #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18681
Summary:
If having the need to use those settings with something else than the
default, one also expects the utils to follow those custom settings.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18625
Summary:
Setting an overlay by name results in a QIcon for it created; OTOH,
this icon is never used to create the final image in case the
main/attention icons are set by name too.
Since KIconEngine supports overlays natively, directly pass the list of
overlays (with just one element -- the overlay set) to it. As result,
main/attention icons by name are created directly with the requested
overlay by name.
Test Plan:
- builds fine
- main/attention icon by name + overlay by name works now, showing the requested overlay
- main/attention icon by name + overlay by pixmap still works as before
- main/attention icon by pixmap is unaffected, no matter whether/which overlay is set
- the system tray icons of juk, and amarok now have the play/pause overlays
Reviewers: apol
Reviewed By: apol
Subscribers: davidedmundson, apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17983
Summary:
PlasmaVirtualDesktop at a protocol level is double buffered.
There's a done() command emitted after property changes. After this the
name might have changed.
Test Plan:
Changed a desktop name (with relevant kwin patch)
Name changed in the pager tooltip
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18512
Summary:
Ran into this gotcha the other day, and it was impossible to resolve
without code debugging.
Reviewers: #plasma, bshah
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18493
Summary:
Before this patch if you had no active menu and configured your plasmoid
it would be invisible.
After this patch a placeholder is shown in that configuration.
BUG: 403232
Test Plan:
* Window with menu - menu shown, no placeholder (as before)
* Window without menu - state is hidden so nothing is shown (as before)
* Window with menu whilst configuring - menu shown (as before)
* Window without menu whilst configuring - placeholder shown (new)
* Compact represenation remains the same
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18481
Summary: setting an icon via i18n makes no sense
Test Plan: Put in vertical panel, had an icon
Reviewers: #plasma, broulik, ngraham
Reviewed By: #plasma, broulik, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18480
Summary:
In the ksmserver porting most code was moved to explicitly calling
logout or shutdown methods rather than a random enum.
A legacy code path remained for compatibility. This path is used by the
containmentactions, in the refactor handling of
KWorkspace::ShutdownTypeDefault was lost.
BUG: 403466
Fixed-in: 5.15.0
Test Plan:
Set different default modes
Logged out using containment actions
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18435
Summary:
BUG: 400549
FIXED-IN: 5.15.0
Test Plan:
On the lock screen KCM at 1.2x scale, before: {F6554037}
After: {F6554040}
All functionality continues to work on the lock screen and SDDM KCMs and desktop containment window.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18343
Test Plan: cmake lists kirigami as a found dependency
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18362
Summary:
While I think mixing IPC systems in this class is not the way to go
long-term, we have a strong desire to ship a complete user experience
for virtual desktops on Wayland in 5.15. As D17691 has been delayed
and did not make the Frameworks 5 release we can depend on for 5.15,
this is Plan B.
Reviewers: #plasma, davidedmundson, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18290
Summary: This patch improves the up/down display for the Monitor widgets
Test Plan:
Before, no activity: {F6549441}
After, no activity: {F6550787}
Before, some activity: {F6549443}
After, some activity: {F6550788}
All the other ones still look good or are improved: {F6550789}
Reviewers: #plasma, #vdg
Subscribers: abetts, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18255
Summary:
Without specifying it the default is phase 2.
Phase 2 is run in parallel with session restore.
BUG: 384392
Test Plan: None.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18240
Adds a new customDateFormat config key which is used when the dateFormat "StringEnum" is set to custom.
Shows a link to the Qt time formatting documentation next to the text field.
Qt doc link and text field are hidden when not set to custom date format.
CCBUG: 340982
Differential Revision: https://phabricator.kde.org/D18019
Summary:
KWorkSpace::detectPlatform among others use that, so make sure it's set.
On 5.12 it has export QT_QPA_PLATFORM=wayland already, so it's not necessary (?).
Test Plan: I had that patch applied locally for basically ever, works fine.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18233
Summary: This patch aims to add padding to the notification widget and fully remedy the issues that arise once it is applied.
Test Plan:
Before:
{F6533139}
After:
{F6533140}
(More padding, and margins as even as can be)
Reviewers: #vdg, #plasma, ngraham, davidedmundson
Reviewed By: #vdg, #plasma, ngraham, davidedmundson
Subscribers: broulik, Codezela, abetts, filipf, davidedmundson, hein, ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17975
Summary: makes sure the flag is set on time
Test Plan: can't get the panelcontroller in the taskbar anymore
Reviewers: #plasma, hein, broulik
Reviewed By: #plasma, hein, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18186