something really wrong is going on on the proxymodel updates
the wrong item gets removed from the list.
it may be a wrong mapping between source and dest model
(doesn't seem so)
or may have been some misguided attempt by QML to recycle delegates
anyways resetting the model in some conditions even if expensive
seems to be the only way to workaround this.
Anyways this systray implementation is beyond any repair and
the rewritten version won't have to rely on so many models
and proxymodels
BUG:357627
CCBUG:352055
something really wrong is going on on the proxymodel updates
the wrong item gets removed from the list.
it may be a wrong mapping between source and dest model
(doesn't seem so)
or may have been some misguided attempt by QML to recycle delegates
anyways resetting the model in some conditions even if expensive
seems to be the only way to workaround this.
Anyways this systray implementation is beyond any repair and
the rewritten version won't have to rely on so many models
and proxymodels
BUG:357627
CCBUG:352055
As in "panel options" when systray is in the panel.
Only one of the formerly two (see
https://git.reviewboard.kde.org/r/125973/) methods did this, so I think
it's safe to remove from the one I'm keeping.
REVIEW: 125972
Remove almost completely duplicated function.
One was used for right clicking on expanded items, the other for full
compact items.
A missing action for expanded items is added so the two menus are now
consistent.
Global co-ordinates are used as args for menus everywhere so we can
share the mapping code SNIs currently use.
REVIEW: 125973
If an applet fails to load properly m_applet will be null which is a
valid state to be in when we destruct the plasmoid task object.
BUG: 356470
REVIEW: 126497
As describled in 'Self-hiding plasmoid' requirement
https://forum.kde.org/viewtopic.php?f=83&t=39501
I added Plasma::Types::HiddenStatus, then when the plasmoid's status is
SystemTray.Task.HiddenStatus, the plasmoid is just self-hiding.
REVIEW: 126298
QTimer::singleShot(time, QObject*, char*)
QTimer::singleShot(time, QObject*, PointerToFunction)
behave differently when time == 0
So the porting had an effect
This patch migrates to QMetaObject::invokeMethod which is clearer
CCBUG: 352055
There seems to be two different bug in 352055 but looks similar, the other one is fixed in Qt 5.6 according to Albert Astals Cid.
execute a script from the look and feel package when
an applet is added, adding to the script environment
"applet" that wraps the currently added applet and
"containment" that wraps its containment.
from there the javascript part can do anything it can do
in the startup script as well.
In case of containments, "applet" and "containment" will
be the same thing
REVIEW:125562
This patch allows to filter the loaded Plasmoids by formFactor. It uses
a property of host, and passes this down to the PlasmoidProtocol, which
then decides based on formFactor whether or not to show a Plasmoid.
The value for FormFactor can be changed from QML.
REVIEW:124634
This way we don't need to keep three different models in sync which has shown to
break quite often resulting in gaps in the layout and other strange behavior.
BUG: 347554
FIXED-IN: 5.4.0
REVIEW: 124380
applet loading in systemtray doesn't depend from sycoca anymore
it uses Plasma::PluginLoader, so it works with both sycoca-based
libplasma and with the new branch without
A custom tooltip text is not mandated by the SNI spec. Instead, we just show
the application name and icon if none is given.
This fixes Steam not having a tooltip and restores Plasma 4.x behavior.
REVIEW: 120407
BUG: 337710
FIXED-IN: 5.1
The systemtray plugin for dbus-activated plasmoids removed the
plasmoid as soon as a service vanished, that matched the pattern.
This behavior broke as soon as there're multiple matchin services,
e.g. the mediacontroller plasmoid when multiple mpris2-mediaplayers
are started. As soon as you quit one application, the plasmoid would
get removed.
With this patch the plasmoid only gets removed after the last service
quit.
Quoting the KIconThemes change that lead to this change:
Revert "Revert "Allow passing custom theme base path together with custom app themes""
This reverts commit 6a75883159bbeb9a9316436d428d2617c3b5fc96.
This was never intended to be pushed, it was a local test for the testcase
in RR119058. Sorry for the mixup.
We're back to good now.
CCMAIL:mklapetek@kde.org
CCMAIL:plasma-devel@kde.org
This is needed to build against KIconThemes 6a75883159bbeb9, which
reverts the commit that adds the path to the addAppDir call. From
looking at the API docs, this *seems* to be the right fix, but I don't
know how to test this properly, so I can't confirm that this actually
works. It builds though, and that's at least a step forward.
If someone can test this, that would be very useful.
CCMAIL:mklapetek@kde.org
CCMAIL:plasma-devel@kde.org
Reviewed-by: Eike Hein on IRC
David Edmundson
Aleix Pol
Marco Martin
David Edmundson
Leslie Zhai
Xuetian Weng
Montel Laurent
Albert Astals Cid
Kai Uwe Broulik
Sebastian Kügler
Lukáš Tinkl
Anton Kreuzkamp