Views shouldn't decide to delete themselves.
ShellCorona is responsible for managing them, it should be the one
managing them in all cases.
bring panelContainmentDestroyed and desktopContainmentDestroyed in line
REVIEW: 127225
All autogenerated qtdbus property fetches are synchronous and not ideal
for Plasma to call.
1) Don't bother checking the protocol version.
If the signals are the same, we may as well try and use the old signals,
if it's not - the signals won't match anything anyway so it won't do
anything anyway.
2) Replace the blocking RegisteredStatusNotifierItem request with an
async variant.
CCBUG: 359611
REVIEW: 127199
When the applet is opened you can press the following keys to control it:
* Space (and K): Play/Pause
* P: Previous song
* N: Next song
* S: Stop playback
* Left key (or J): seek back 5s
* Right key (or L): seek forward 5s
* Home: Go to beginning of track
* End: Go to end of track (ie. basically goes to next track)
* 0..9: Jump to 0%, 10%, 20%, etc of track's length depending on the number
Of course there's still the global shortcuts so you don't actually need this.
While at it I made the slider a bit more reliable while manipulating it so it
wouldn't twitch around.
BUG: 351146
FIXED-IN: 5.6.0
When automatic screen locking is enabled, we want to ensure the screen is fully locked
before we switch sessions or go to the login screen to avoid brief exposure of the desktop
when we return.
This check happens asynchronously and because the User Switcher dialog closes immediately
after issuing the switch request, the SessionsModel is already destroyed and the reply is never
actually processed.
BUG: 356945
FIXED-IN: 5.5.5
Differential Revision: https://phabricator.kde.org/D1020
set values that could be null as QString() instead of QVariant
the values so will be there but empty
similarly, set as empty qstrings also missing QIcons,
that's the only way qml can check if it's valis since QIcon is an
opaque type for QML
Summary:
If user is using svg wallpaper with opaque area, then this allows users to fill opaque area with color.
BUG: 351012
Reviewers: #plasma, bshah
Reviewed By: #plasma, bshah
Subscribers: bshah, broulik, plasma-devel
Projects: #plasma
Differential Revision: https://phabricator.kde.org/D1008
If built against KIO v5.20+ we use a new version of the KDirNotify
file rename notification interface that allows providing enough
information to allow KCoreDirLister to announce a file change
instead of relisting the affected file(s) and causing position data
to be lost. We also make use of a new mechanism for informing KIO that
kio_desktop will in fact take care of producing the rename notification
by itself, avoiding KIO::SimpleJob doing it as well (and losing the old,
lossy interface since it doesn't have the same information we have
available in kio_desktop).
Reviewed-by: faure@kde.org
BUG:359596
this makes kspash be in a rectanle that looks just like the one
used now in lockscreen and sddm.
the weird start animation is removed, but the k+progressbar enter
from the right (to complete, sddm could have its content sliding
to the left before the actual login, not sure is possible)
it also *should* kindof play nice with hig dpi (not tested, a bit
tricky since still restricting to pure Qt imports for load times)
Summary:
If the window's platform surface was destroyed, there is also
no shadow to be removed.
Both X and Wayland code will try to create the platform surface
again, and it will lead to crash in other code that doesn't expect
platform surface to be created when the containment is being deleted.
This fixes crash in PanelConfigView::event when removing panels.
Reviewers: graesslin, #plasma
Reviewed By: graesslin, #plasma
Subscribers: plasma-devel
Projects: #plasma
Differential Revision: https://phabricator.kde.org/D951
Instead of an hardcoded list of translations of country names, look
them up in the iso_3166 domain, provided by iso-codes. The names of
countries are changes to their ISO 3166 versions in iso-codes.
Look for iso-codes in cmake, but just as indication of it as runtime
dependency.
REVIEW: 126879
If no text is input "Search..." is shown to clarify what this window the user might
have accidentally triggered is all about. In single runner mode, the name of the
runner that will be queried will be shown.
REVIEW: 126878
When in single runner
Otherwise we'll crash. This is the only occurrence I stumbled upon this right now
but there may be others in the port away from Qt4Support.
CCMAIL: apol@kde.org
In the unlikely event that the user right clicks the SNI and chooses "Report Bug",
while we show a notification with exactly this option, we should still close it.
Summary:
Since Qt 5.5 there is a dedicated event when a PlatformSurface gets
created. This allows us to know when we need to setup the Wayland
integration.
Reviewers: mart
Subscribers: plasma-devel
Differential Revision: https://phabricator.kde.org/D819
The tray window itself may be destroyed before we start monitor the
event of it. Check the returned error and skip this window if BadWindow
happens.
FIXED-IN: 5.6.0
BUG: 358719
REVIEW: 127014
The selection manager of tray may hold a property to indicate the tray
icon window visual. Try to use the visual with alpha channel when
composite is enabled.
REVIEW: 127009
We were rejecting all key presses that had modifier in it, this included upper-case letters because of Shift being pressed.
Accept keys where *only* the Shift modifier is pressed, too.
BUG: 353959
FIXED-IN: 5.6.0
Differential Revision: https://phabricator.kde.org/D902
David Edmundson
Kai Uwe Broulik
Jonathan Riddell
David Edmundson
Marco Martin
Bhavisha Dhruve
David Rosca
l10n daemon script
Eike Hein
David Faure
Andreas Hartmetz
Elias Probst
Pino Toscano
Aleix Pol
Martin Gräßlin
Weng Xuetian
Dāvis Mosāns
Friedrich W. H. Kossebau