Summary:
When having expanded System Tray once, plasmashell crashes on teardown.
Fixes regression introduced in D27085.
BUG: 417552
FIXED-IN: 5.19.0
Test Plan:
1. Start plasmashell
2. Open System Tray popup, close it again
3. run kquitapp5 plasmashell, it should not crash
Reviewers: #plasma_workspaces, #plasma, broulik, ngraham
Reviewed By: ngraham
Subscribers: anthonyfieroni, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27401
Avoids repeatedly resizing the dialog when copying many files.
It will still resize when the speed label comes and goes but at least when copying many tiny files it won't be as obnoxious.
BUG: 417489
FIXED-IN: 5.18.1
Differential Revision: https://phabricator.kde.org/D27344
Summary:
VirtualDesktopInfo::Private is ref counted and shared between N
VirtualDesktopInfo's.
We were passing the first VirtualDesktopInfo as a parent to
VirtualDesktopInfo::Private which didn't manage the lifespan or do
anything useful.
The wayland backend incorrectly used this 'q' object and spanned
mulitple internal objects and connections to the first object that
created the shared private instance, leaving us with dangly objects
inside.
BUG: 415200
(and possibly several other bugs of wayland task manager not updating
correctly)
Test Plan:
Compiles
Plasma still loads
Reviewers: #plasma, zzag
Reviewed By: #plasma, zzag
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27266
Summary: According to Qt docs, QUuid() creates a null UUID object.
Test Plan: N/A, plasmashell is very unstable with Qt 5.15.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27237
Summary:
plasma.kde.org doesn't exist anymore and causes the appstream test to
to fail.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27304
Summary:
The urls were changed from http to https in the test's source files
with 6d6d3c5b3e but not in the json test
files.
Test Plan: Built fine and the test passed with a clean build dir
Reviewers: #plasma, yurchor
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27281
Summary: Equivalent of dbus-update-activation-environment but in runtime
Test Plan:
Changed cursor theme (with some additional fixes there)
Checked the systemd env via the property on manager1.
It had changed
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27054
Summary:
We use this centered style in many other places and are moving towards using it
everywhere. This patch applies the same style to the System Tray popups for
notifications and devices, which were still using the old style.
Test Plan:
Notifications, before: {F8090822}
Notifications, after: {F8090777}
Device Notifier: before: {F8090825}
Device Notifier, after: {F8090776}
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: davidedmundson, ndavis, trmdi, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27219
Summary:
Also drop the prefix and use the KDE_INSTALL_FULL.. variant for an
absolute path (similar to logo=${KDE_INSTALL_FULL_DATADIR}...).
Test Plan:
Checked that the path of the background image is the same as
before.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27241
Summary:
Since D10835 opening urls that needed mimetype determination such as smb:/ or sftp:/ urls were always opened with a "Open With" dialog.
To keep the same security but adding some convenience, use KRun::setRunExecutables to disable executable run here.
Reviewers: #plasma, broulik, aleksejshilin, hein
Reviewed By: #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26582
Summary:
Few unrelated fixes, bunched together:
* move some code from main.qml to PlasmoidItem where it belongs
* easier to understand item size calculation
* where possible, replace parent.parent comparisons with a property in AbstractItem
* get rid of marginHints
* Qt 5.14 compatibility fix in configuration
* formatting etc
Test Plan: Everything should work as before, this is just refactoring.
Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27085
This wasn't an issue before as notification popups could never have focus.
However, now with quick reply they can, leading to funky results and gaps when a notification appears while answering another one.
Differential Revision: https://phabricator.kde.org/D27134
Summary:
If StatusNotifierItem is registered and then immediately destroyed, it is possible that QDBusServiceWatcher will not emit the serviceUnregistered signal.
Add an additional check to avoid such situations.
BUG: 416652
FIXED-IN: 5.18.0
Test Plan: Telegram should not add empty items.
Reviewers: #plasma_workspaces, #plasma, davidedmundson
Reviewed By: #plasma_workspaces, #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27126
The category was only used for proper Plasma::Applet instances but not unloaded plasmoids from pure metadata.
BUG: 416947
FIXED-IN: 5.18.0
Differential Revision: https://phabricator.kde.org/D27068
The code tried hard to ignore garbage URLs, as Qt is quite lenient, e.g. QUrl("Garbage Url") is still valid.
There is no way to change the strictness of a QUrl after creation,
so the code would enforce it by doing QUrl strictUrl(inputUrl.toString(), QUrl::StrictMode).
However, toString() defaults to PrettyDecoded which avoids percent-encoding and keeps spaces
in tact which is not a valid thing to have in a strict URL.
Effectively, we want to ensure a URL is either a valid path to a local file,
or one of the special applications (for menu ids), or preferred for preferred applications, like web browser,
BUG: 385727
FIXED-IN: 5.18.0
Differential Revision: https://phabricator.kde.org/D26941
Konrad Materka
Kai Uwe Broulik
Nate Graham
David Edmundson
Vlad Zahorodnii
Heiko Becker
l10n daemon script
Méven Car
Yuri Chornoivan
Marco Martin
Jonathan Riddell