Summary:
* first check CanControl property, as it overrules things
* next check each action Can* property, to spare D-Bus call and app
activation if false
* support CanPause and only call PlayPause is possible,
otherwise use Play
Test Plan:
Vlc can be controlled by keyboard media keys as before,
Gwenview patched to support MPRIS (with CanPause=false) can now be
controlled with the Play/Pause media key.
Reviewers: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10991
Summary:
ServiceJob::setResult already does a emitResult.
Discovered with the assert created in https://phabricator.kde.org/D9862
Reviewers: #frameworks, #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10629
Since Qt 5.6.3/5.7.1 qdbusxml2cpp favours as name for signals argument
annotations the name "org.qtproject.QtDBus.QtTypeName.Out*", matching
the "out" direction nature of the arguments.
".In*" is still supported for backward compat, but with a warning.
Summary:
Qt labels support a HTML subset, using a completely internal parser in
QTextDocument.
The Notification spec support an even smaller subset of notification
elements.
It's important to strip out irrelevant tags that could potentially load
remote information without user interaction, such as img
src or even <b style="background:url...
But we want to maintain the basic rich text formatting of bold and
italics and links.
This parser iterates reads the XML, copying only permissable tags and
attributes.
A future obvious improvement would be to merge the original regular
expressions into this stream parser, but I'm trying to minimise
breakages to get this into 5.12.
Test Plan:
Moved code into it's own class for easy unit testing
Tried a bunch of things, including what the old regexes were doing
Also ran notify send with a few options to make sure things worked
Reviewers: #plasma, fvogt
Reviewed By: fvogt
Subscribers: aacid, fvogt, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10188
Sync querying of the time dataengine is no longer possible,
also is the calculation of the elevation not depending on other data
then those passed in, so this is not really data hold by the time
data engine. Instead one would calculate the values needed on the fly.
Yet to solve: how to make direct use of the solarsystem code currently
part of the time dataengine only.
Kai Uwe Broulik
Friedrich W. H. Kossebau
l10n daemon script
Jaime Torres
Laurent Montel
David Edmundson
Luca Beltrame