this caused an unnecessary warning. when the list is empty the join
results in "" which is considered invalid for the reference of %2
leading to ki18n warning that not enough arguments were supplied. simply
return an empty string when the message is not visible
the recycler did not really serve a purpose here. the delegates are
fairly cheap and there's a very finite amount of them and the amount
isn't going to be in the thousands either
it did however cause spurious warnings because there is a space of time
where model and index isn't available to the delegate and so trying to
get a role out of the model would cause warnings because model is null
initially.
removing the recycler gets rid of the warnings.
I've also changed parent.width to refer to the view explicitly as parent
isn't necessarily defined right out the gate causing excess warnings.
this is also typically what we do in other places.
We got some reports that the update did not work correctly.
The kconf update daemon watches for new files so we should
rename the file in addition to changing the IP.
Instead listen to KNS signals and only update the parts that are needed.
The signals from the qtquickengine also produce less unwanted noise
because the signal does not get emitted for intermediate states.
This also prevents the scrolling position from scrolling unnecessarily
to the top.
Instead listen to KNS signals and only update the parts that are needed.
The signals from the qtquickengine also produce less unwanted noise
because the signal does not get emitted for intermediate states.
This also prevents the scrolling position from scrolling unnecessarily
to the top.
To be consistent with what we generally do in other places, use the
trashcan icon for the remove button, and only show it when the list has
more than one item in it.
BUG: 437567
BUG: 437566
FIXED-IN: 5.22
This commit implements what was agreed upon in
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/690, but
does it correctly by simply disabling the menu item by default, not
removing it entirely. This ensures that the change is only made for new
installs. Existing users' configs will not be touched (because all
values are serialized to the config file already), and any new users
will be able to re-enable this item if they like it.
CCBUG: 437747
This reverts commit 1cb254416c.
This change was not implemented in the correct way. The context menu is
configurable, so instead of removing the possibility of the menu item
ever being in the menu, we should have simply removed it from the
default set of menu items.
BUG: 437747
FIXED-IN: 5.22
This is an extremely fiddly procedure well-suited for being automated
rather than documented.
The approach taken here should work for all distros, even those that
freak out if system DBus files are modified or symlinked into a home
directory.
BUG: 425272
Harald Sitter
Shubham Shubham
Alexander Lohnau
David Redondo
l10n daemon script
Nicolas Fella
Ayushmaan jangid
Nate Graham
Konrad Materka
Cyril Rossi
Andreas Cord-Landwehr
Mikel Johnson
Devin Lin
Felipe Kinoshita