Summary:
Reduces code duplication and we always opperate on cached value, that
is the platform is only checked once in application life cycle.
Reviewers: #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2342
since now desktop scripting is supposed to modify
containments instead of creating activities,
make sure a desktop containment exists for each screen
by running addoutput
Summary:
On Wayland ksplash only showed on one screen. This is due to QtWayland
not passing any hint to the compositor on which output to show the
fullscreen window. Thus the compositor placed all windows on the first
output.
This change uses KWayland to work around this problem by performing
a deeper integration. It doesn't use fullscreen windows any more, but
normal windows in combination with the PlasmaShell interface. That way
the windows can perform absolute positioning.
As the window is no longer fullscreen, it's marked as OnScreenDisplay
which makes sure that KWin raises it on top of all other windows. Also
ensures that opened windows aren't raised above it as used to happen.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2242
Summary:
allow for lnf package to override templates, so that
for instance, "default panel" can be overriden, so in a
distribution adding a "default panel" would add what is the
"default panel" of that distribution.
switching lnf package would get back a normal panel
Reviewers: garg, ivan, #plasma
Reviewed By: ivan, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2298
Summary:
check first i the lnf package if
we have a default containment for the current shell
then fallback to the one specified by the shell package
Reviewers: ivan, #plasma
Reviewed By: ivan, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2286
Summary:
We used to append them, but that didn't work well and was crashing plasmashell
on fresh start.
A default desktop would be created alongside with the one provided by the
layout instead of replacing it.
If a layout wants to provide an additional screen for a desktop in the secondary
screen, it should specify the screen.
Test Plan:
Now the plasmashell tests pass. In fact I noticed it was broken due to an e-mail
Jonathan sent me that the test on neon was timing out. The test in neon will
freeze when the test crashes. Probably something to look into.
It can be reproduced by running:
```
xvfb-run -a --server-args="-screen 0 1024x768x24" dbus-launch --exit-with-session <exec>
```
Where `exec` is the process we need to run.
Now the test passes.
It's a crash that I had reproduced locally in the past. I can't now.
Reviewers: #plasma, mart
Reviewed By: mart
Subscribers: sitter, jriddell, plasma-devel, #neon
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2117
Summary:
Used to work, then patch f7ef6ee87b
changed it.
Docs above edited code say:
"it is valid for KAMD to not be running."
This fixes that but keeps the objective of patch f7ef6ee, of delaying
load() if we're still loading KAMD.
Test Plan:
Reviewers:
#plasma
Subscribers:
Summary:
We have a method to add an activity in plasma script, but
not to remove it. This patch fixes this situation.
Reviewers: garg, davidedmundson, mart
Reviewed By: davidedmundson, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2251
There was a conflict between adding a config option [1] in master and a
fix to crop to the icon size [2] in the 5.7 branch. I still need the
cropping on my vertical panel, otherwise the icons are insanely big.
[1] https://git.reviewboard.kde.org/r/128400/
[2] https://phabricator.kde.org/D2160
Reviewed-By-Over-IRC: Marco Martin <notmart@gmail.com>
BUG: 365394
Kickoff traditionally prefers showing the application comment (ie. "File Manager", "Web Browser", etc)
over the actual application name. This allows to find applications this way.
Differential Revision: https://phabricator.kde.org/D2204
As requested by Usability we'll assume a job finished successfully as the most likely case
and only keep the notification persistent in case of an error.
This makes dealing with files significantly less annoying.
Differential Revision: https://phabricator.kde.org/D2223
As per notification spec the value "0" means "persistent notification" whereas "-1"
means "server default timeout", so when no timeout is explicitly specified,
it always yielded a persistent notification.
Differential Revision: https://phabricator.kde.org/D2222
l10n daemon script
Marco Martin
Martin Gräßlin
Kai Uwe Broulik
David Edmundson
Luca Beltrame
Jonathan Riddell
Ivan Čukić
Eike Hein
Jan Kundrát