to ensure that the target URL is updated by KDirLister.
This unittest requires the KIO fix 1449ecf136 (KF 5.37).
CCBUG: 382341
The unittest detected a "//" in the UDS_LOCAL_PATH values,
so this commit fixed that as well.
This way Folder View could use the root item for its heading instead of special-casing it for desktop:/
Differential Revision: https://phabricator.kde.org/D5221
Summary:
Commit 72e39f083a broke the kded module. Turns out that the old code
just forced a refresh of the `remote:/` QUrl, so we can just do that
explicitly and remove all the old cruft.
While at it, use a KDirWatcher that just watches the
`.local/share/remote/` folder, instead of checking *every* unrelated
QUrl emitted by KDirNotify.
Test Plan:
Adding/deleting/editing .desktop files in `.local/share/remoteview` now
automatically reloads the `remote:/` url in Dolphin or Folder View.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4573
Summary: Ran `uncrustify-kf5` from kde-dev-scripts.
Test Plan: Builds; still works.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4489
Summary:
Commit 72e39f083a broke the remote ioslave from Dolphin Details view
mode, because of missing slashes or otherwise broken `QUrl`s.
BUG: 376131
FIXED-IN: 5.9.2
Test Plan: `remote:/` now works again from Dolphin Details view mode.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4480
Summary:
This is clearly some upgrade code from many years ago - before Plasma 5.
Gets rid of a whole lot of deprecated function calls (and a unsigned vs
signed int wraning
Test Plan: make
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2579
UDS_LOCAL_PATH will return the path without file scheme. This schemeless
path will be set in UDS_TARGET_URL and then will be used by kio's
targetUrl and then final passed to Krun where it will fail the scheme test
eventually leading to the said bug.
Fix for this is to create a url using QUrl::fromLocalFile and then
pass the url.toString()'s result to insert.
BUG: 364530
CCMAIL: chinmoyrp65@gmail.com
Differential revision: https://phabricator.kde.org/D2054
Will make KIO clients listing desktop:/ re-list at runtime. Makes
the desktop not break when changing the desktop location in the
user paths KCM.
CCBUG:356548
Will make KIO clients listing desktop:/ re-list at runtime. Makes
the desktop not break when changing the desktop location in the
user paths KCM.
CCBUG:356548
If built against KIO v5.20+ we use a new version of the KDirNotify
file rename notification interface that allows providing enough
information to allow KCoreDirLister to announce a file change
instead of relisting the affected file(s) and causing position data
to be lost. We also make use of a new mechanism for informing KIO that
kio_desktop will in fact take care of producing the rename notification
by itself, avoiding KIO::SimpleJob doing it as well (and losing the old,
lossy interface since it doesn't have the same information we have
available in kio_desktop).
Reviewed-by: faure@kde.org
BUG:359596