This makes the config dialog more responsive when opening it multiple
times, and minimizes network traffic.
The equality check at the beginning of sourceRequestEvent was
completely wrong, if the source (DataContainer) was deleted-because-unused then
we need to proceed with the request even if it's the same as the
previous request. And if the request is ongoing then DataEngine
doesn't call us again, it connects to the existing source...
Summary:
Right now, new Action always appends to the list, but application may
want to add new action in the middle of the menu. This breaks such
application with dynamic menu entries. This change tries to keep the
order of actions same as the order in dbus request.
Test Plan: Manually tested the brokened menu in certain applications.
Reviewers: #plasma, davidedmundson, broulik
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8585
Summary:
AFAICS the only other user for the engine (other than the applet I'm
porting) is the runner for KRunner, where links don't work anyway.
Port to QRegularExpression while at it.
Test Plan: Tested with the upcoming dict applet.
Reviewers: #plasma, davidedmundson, broulik, mart
Reviewed By: #plasma, mart
Subscribers: ngraham, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8534
Summary:
Instead of returning "<dl>\n<dt><b></b></dt>\n<dd></dl>"
when the word doesn't exist, return a proper readable string so users
know that the lookup is done and nothing was found.
Test Plan: I'm porting the dict applet to QtQuick, review request coming soon.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: broulik, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8419
This way when a third party like pinning or dragging from Kickoff sends an absolute desktop file
path we would still only store the application id if possible.
CCBUG: 385594
Differential Revision: https://phabricator.kde.org/D8260
The switch user greeter accesses it to get the "vtNumber" when you click the "Switch" button.
CHANGELOG: Fixed being unable to switch users from the Switch User screen
This reverts commit cc86474810.
The reason why this was added is not valid anymore now that we set the QQC2 style in C++. Setting it causes crashes in QGuiApplications
that need to be worked around with an ugly hack in plasma-integration.
Differential Revision: https://phabricator.kde.org/D7998
They have been removed way back in Plasma 4.7 and are the cause of the "Error contacting the daemon!" message on KRunner startup.
Differential Revision: https://phabricator.kde.org/D7919
begin() and end() operate on the hash values.
This avoids creating a temporary list just for this.
Differential Revision: https://phabricator.kde.org/D7917
Summary: As now it is set by our QPT
Reviewers: #plasma, gladhorn
Reviewed By: #plasma, gladhorn
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7936
Summary:
This sets a transient parent on the shown menus, meaning a panel knows
to stay open whilst it has any menu showing.
We also pulse setStatus() to trigger activating an autohidden panel if
activated via a shortcut.
BUG: 384861
Test Plan:
Ran menu
Using both mouse and keyboard shortcuts navigated a menu
and submenus
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7883
Summary:
On X our font DPI is used in addition to the scaling.
i.e I want scale 2 and font DPI at 192 (96*2)
On Wayland it's the opposite. The font is scaled *with* the output
scaling. So I want it at 96 (or unset)
Using the same settings makes swithing to and from X and wayland hard,
and also makes the first Wayland run suck.
There are potentially some users who want it 110 at both, so we do still
need the option (so this isn't a perfect solution)
Can we just divide it? Not really as we don't know what scale the user
will be using and it might not just be one value.
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7830
Summary:
Add more explicit text to labels (available via "flat review" keys)
Add names to media controls
Test Plan: Ran lockscreen with orca running
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7789
Summary:
enable actual keyboard navigation, as the previous
completely manual keyboard navigation in krunner completely broke
the screen reader support, rendering it inaccessible (while
potentially krunner is one of the most useful apps for blind
users)
Test Plan:
tested to navigate with keyboard (still similar behavior as before)
while having orca running, which correctly read the result entries
Reviewers: #plasma, davidedmundson, broulik
Reviewed By: #plasma, davidedmundson
Subscribers: gladhorn, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7765
Summary:
Scale factor is sent on the output, we don't need to have the hacky env
variables.
When the kscreen KCM is used on wayland it doesn't set the variable this
is using.
Test Plan:
Configured an X session to have high DPI with this variable.
Logged into a wayland session, ran env.
(font DPI is still a problem, if it gets set on X
it's visually doubled on my wayland session. )
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7781
Jonathan Riddell
l10n daemon script
David Faure
Friedrich W. H. Kossebau
Weng Xuetian
Aleix Pol
Алексей Шилин
David Edmundson
Kai Uwe Broulik
Marco Martin
Antonio Rojas
Eike Hein
Pino Toscano