Needs c815c7a9bc
Currently the logic is very fragile and depends on the data being an url.
However the data of the match is an implementation detail and is in case of the KCM matches
a KPluginMetaData instance.
To avoid this issue the first url of the QueryMatch::urls() return value is checked.
This data is intended for mime-type/scheme related operations.
In the future we need an extra url for systemsettings & should consistently use the
urls of the query match. I will work on this before continuing to port the
plasma KCMs from KServiceTypeTrader.
BUG: 442522
A placeholder screen is created by Qt when no real screens exist. We
don't want to create panels and containments for those, it is a whole
world of pain.
Plasma has a hook to ignore some screens which is extended with this
check.
CCBUG: 419492
When applying an accent color, the color was added to the color scheme's
Header color group. But not all color schemes have this group, and
adding it made the color scheme break in creative ways.
BUG: 443786
FIXED-IN: 5.23.1
ManagedConfigModule::save() writes the value for the 'ColorScheme' entry to disk.
If we notify the settings change anyone who connects to it may read the old value before the new one is saved.
To avoid this race consition emit the signal after saving instead of before
'xrdb -remove' can't remove a specific entry, it removes all entries only.
So query all entries, remove "Xft.dpi" from them, and replace Xresources
with the result.
BUG: 350039
CCBUG: 376406
kscreenlocker implements sleep and hibernate requests, but they aren't
wired anywhere in. Besides that, it can be useful to have a quick way to
suspend or hibernate computer from lockscreen.
This was deprecated, because having string based key-actions values
does not fit the usecases we have.
Consequently we should check if the runner has any QAction children, this
works if the runner created the QActions manually or if the actions
are registered in the abstract runner.
Also we can drop the ugly hack.
On this page there is no concept of the user being passwordless because
no username has been specified by the user yet; we cannot know ahead of
time. As a result, userList.currentItem.needsPassword is blank so the
password field gets hidden.
We should just assume that in username/password entry mode, all users
have a password set. For any users where this is not the case, they can
just leave the password blank, and it's not any worse than it was in
Plasma 5.22.
BUG: 443737
FIXED-IN: 5.23.1
cd68df165a
added a setting to force the date to be at the same line as the time.
Add another option to that setting to force the date to be below the
time.
- Up/Down now ensures item is completely in view
- Ctrl+F works
- Tab/Shift+Tab events are no longer eaten by the search field
- Tab/Shift+Tab now resolve to actions on the selected item first
- Can use Escape key to go back from from QR code page
The app name in the header has poor text contrast because it is 40%
transparent and sits on a gray background. It is also using a
semantically incorrect UI component (DescriptiveLabel) which was meant
for de-emphasized subtitles, not titles. The correct component for that
is a Heading, so let's use that.
Because this means that we will hve two identically-sized headings in
close proximity, we need to distinguish the text for the notification
title without making it huge, which is overkill for a notification. To
accomplish this, this MR uses the Heading's "Primary" type which was
made for this purpose.
In most cases the port is trivial and can even simplify the code like in
the case of the system tray applet. In the case of notifications applet,
this is causing a bigger refactor and it's now also using a TextArea
that provides the automatic scrolling when selecting behavior.
CCBUG: 437155
Previously, the tooltips referred to generic "Open an existing document" or
"Print document", as defined in the kframework.
These descriptions now match what they do, since they are specific to font
files and printing font previews. This updates both the menubar action
tooltips as well as button tooltips.
The file org.kde.StatusNotifierItem was syncronised with up-to-date
master, despite being previous edited to be only supported actions.
Whilst it seems harmless the line:
+ <property name="Menu" type="o" access="read"/>
means we now advertise this property.
Marshalling an empty path gives a warning.
Plasma-workspace "correctly" thinks we have a supported DBus menu and
therefore don't want to receive context menu events.
This reverts commit e782a1248d.
This reverts commit b9de2c8546.
The XML file gains a comment at the top so this doesn't happen again.
BUG: 442758