We set KeepAbove using KWindowSystem but since Qt 5.7 apparently Qt does something weird and loses the flag.
Explicitly add it to flags. Not doing any other cleanup in the code because this is critical for 5.8.0.
BUG: 368997
FIXED-IN: 5.8.0
Differential Revision: https://phabricator.kde.org/D2825
even while closed, the panel controller may control panel size
or offset, with some unwanted binding loops it was
resetting the offset when the panel changes screen (primary
screen changes)
reviewd-by:David Edmundson <david@davidedmundson.co.uk>
This fixes the panel configuration having shadows on all sides, casting a shadow onto
the panel and causing an ugly glitch during the sliding animation.
Also expose the borders as property to the QML part but it doesn't use it currently.
Differential Revision: https://phabricator.kde.org/D1778
Summary:
If the window's platform surface was destroyed, there is also
no shadow to be removed.
Both X and Wayland code will try to create the platform surface
again, and it will lead to crash in other code that doesn't expect
platform surface to be created when the containment is being deleted.
This fixes crash in PanelConfigView::event when removing panels.
Reviewers: graesslin, #plasma
Reviewed By: graesslin, #plasma
Subscribers: plasma-devel
Projects: #plasma
Differential Revision: https://phabricator.kde.org/D951
Summary:
Since Qt 5.5 there is a dedicated event when a PlatformSurface gets
created. This allows us to know when we need to setup the Wayland
integration.
Reviewers: mart
Subscribers: plasma-devel
Differential Revision: https://phabricator.kde.org/D819
engine()->rootContext() will give a different result to
rootContext() when using a shared engine.
One being in the right context, the other being the context of the
shared engine. Using the latter means two panels end up sharing the same
object which leads to some interesting results and QML crashes in
QV4::QObjectWrapper::wrap when one gets deleted.
I've tested against 356545, but I think it's the cause of a lot of the
mystery QML bugs we couldn't figure out.
BUG: 356545
BUG: 355885
BUG: 356916
REVIEW: 126491
this because due to Qt xcb implementation the actual flags gets
set only after a while after the window is actually visible.
kwin has actually time to move the window since is not a dock yet,
at the moment there is no solution besides moving it back
BUG:339614
when the panel mode is autohide, the visibility mode has to be
altered when the controller is open, or the panel will go invisible
also when the mode is windowcancover is better to alter, or the panel may disappear
as well.
Kai Uwe Broulik
Marco Martin
David Rosca
Martin Gräßlin
David Edmundson
Montel Laurent
David Edmundson
Aleix Pol