Set root context properties on the right context

engine()->rootContext() will give a different result to
rootContext() when using a shared engine.

One being in the right context, the other being the context of the
shared engine. Using the latter means two panels end up sharing the same
object which leads to some interesting results and QML crashes in
QV4::QObjectWrapper::wrap when one gets deleted.

I've tested against 356545, but I think it's the cause of a lot of the
mystery QML bugs we couldn't figure out.

BUG: 356545
BUG: 355885
BUG: 356916
REVIEW: 126491

shell/containmentconfigview.cpp

@@ -56,7 +56,7 @@ ContainmentConfigView::ContainmentConfigView(Plasma::Containment *cont, QWindow
       m_ownWallpaperConfig(0)
 {
     qmlRegisterType<QAbstractItemModel>();
-    engine()->rootContext()->setContextProperty(QStringLiteral("configDialog"), this);
+    rootContext()->setContextProperty(QStringLiteral("configDialog"), this);
     setCurrentWallpaper(cont->containment()->wallpaper());
 
     KPackage::Package pkg = KPackage::PackageLoader::self()->loadPackage(QStringLiteral("Plasma/Wallpaper"));
@@ -237,7 +237,7 @@ void ContainmentConfigView::syncWallpaperObjects()
     if (!wallpaperGraphicsObject) {
         return;
     }
-    engine()->rootContext()->setContextProperty(QStringLiteral("wallpaper"), wallpaperGraphicsObject);
+    rootContext()->setContextProperty(QStringLiteral("wallpaper"), wallpaperGraphicsObject);
 
     //FIXME: why m_wallpaperGraphicsObject->property("configuration").value<ConfigPropertyMap *>() doesn't work?
     m_currentWallpaperConfig = static_cast<KDeclarative::ConfigPropertyMap *>(wallpaperGraphicsObject->property("configuration").value<QObject *>());

shell/panelconfigview.cpp

@@ -79,8 +79,8 @@ PanelConfigView::PanelConfigView(Plasma::Containment *containment, PanelView *pa
     updateContrast();
     connect(&m_theme, &Plasma::Theme::themeChanged, this, &PanelConfigView::updateContrast);
 
-    engine()->rootContext()->setContextProperty(QStringLiteral("panel"), panelView);
-    engine()->rootContext()->setContextProperty(QStringLiteral("configDialog"), this);
+    rootContext()->setContextProperty(QStringLiteral("panel"), panelView);
+    rootContext()->setContextProperty(QStringLiteral("configDialog"), this);
     connect(containment, &Plasma::Containment::formFactorChanged, this, &PanelConfigView::syncGeometry);
     connect(containment, &Plasma::Containment::locationChanged, this, &PanelConfigView::syncSlideLocation);
 

shell/panelview.cpp

@@ -110,7 +110,7 @@ PanelView::PanelView(ShellCorona *corona, QScreen *targetScreen, QWindow *parent
             this, &PanelView::updateStruts);
 
     qmlRegisterType<QScreen>();
-    engine()->rootContext()->setContextProperty(QStringLiteral("panel"), this);
+    rootContext()->setContextProperty(QStringLiteral("panel"), this);
     setSource(QUrl::fromLocalFile(m_corona->kPackage().filePath("views", QStringLiteral("Panel.qml"))));
     PanelShadows::self()->addWindow(this);
 }

shell/shellcorona.cpp

@@ -510,7 +510,7 @@ void ShellCorona::showAlternativesForApplet(Plasma::Applet *applet)
     qmlObj->setSource(QUrl::fromLocalFile(alternativesQML));
 
     AlternativesHelper *helper = new AlternativesHelper(applet, qmlObj);
-    qmlObj->engine()->rootContext()->setContextProperty(QStringLiteral("alternativesHelper"), helper);
+    qmlObj->rootContext()->setContextProperty(QStringLiteral("alternativesHelper"), helper);
 
     m_alternativesObjects << qmlObj;
     qmlObj->completeInitialization();
@@ -1152,7 +1152,7 @@ void ShellCorona::showInteractiveConsole()
         m_interactiveConsole->setSource(QUrl::fromLocalFile(consoleQML));
 
         QObject *engine = new WorkspaceScripting::ScriptEngine(this, m_interactiveConsole);
-        m_interactiveConsole->engine()->rootContext()->setContextProperty(QStringLiteral("scriptEngine"), engine);
+        m_interactiveConsole->rootContext()->setContextProperty(QStringLiteral("scriptEngine"), engine);
 
         m_interactiveConsole->completeInitialization();
         if (m_interactiveConsole->rootObject()) {