The switch user greeter accesses it to get the "vtNumber" when you click the "Switch" button.
CHANGELOG: Fixed being unable to switch users from the Switch User screen
This reverts commit cc86474810.
The reason why this was added is not valid anymore now that we set the QQC2 style in C++. Setting it causes crashes in QGuiApplications
that need to be worked around with an ugly hack in plasma-integration.
Differential Revision: https://phabricator.kde.org/D7998
They have been removed way back in Plasma 4.7 and are the cause of the "Error contacting the daemon!" message on KRunner startup.
Differential Revision: https://phabricator.kde.org/D7919
begin() and end() operate on the hash values.
This avoids creating a temporary list just for this.
Differential Revision: https://phabricator.kde.org/D7917
Summary: As now it is set by our QPT
Reviewers: #plasma, gladhorn
Reviewed By: #plasma, gladhorn
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7936
Summary:
This sets a transient parent on the shown menus, meaning a panel knows
to stay open whilst it has any menu showing.
We also pulse setStatus() to trigger activating an autohidden panel if
activated via a shortcut.
BUG: 384861
Test Plan:
Ran menu
Using both mouse and keyboard shortcuts navigated a menu
and submenus
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7883
Summary:
On X our font DPI is used in addition to the scaling.
i.e I want scale 2 and font DPI at 192 (96*2)
On Wayland it's the opposite. The font is scaled *with* the output
scaling. So I want it at 96 (or unset)
Using the same settings makes swithing to and from X and wayland hard,
and also makes the first Wayland run suck.
There are potentially some users who want it 110 at both, so we do still
need the option (so this isn't a perfect solution)
Can we just divide it? Not really as we don't know what scale the user
will be using and it might not just be one value.
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7830
Summary:
Add more explicit text to labels (available via "flat review" keys)
Add names to media controls
Test Plan: Ran lockscreen with orca running
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7789
Summary:
enable actual keyboard navigation, as the previous
completely manual keyboard navigation in krunner completely broke
the screen reader support, rendering it inaccessible (while
potentially krunner is one of the most useful apps for blind
users)
Test Plan:
tested to navigate with keyboard (still similar behavior as before)
while having orca running, which correctly read the result entries
Reviewers: #plasma, davidedmundson, broulik
Reviewed By: #plasma, davidedmundson
Subscribers: gladhorn, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7765
Summary:
Scale factor is sent on the output, we don't need to have the hacky env
variables.
When the kscreen KCM is used on wayland it doesn't set the variable this
is using.
Test Plan:
Configured an X session to have high DPI with this variable.
Logged into a wayland session, ran env.
(font DPI is still a problem, if it gets set on X
it's visually doubled on my wayland session. )
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7781
This makes the font selector more compact and moves it to the end of the dialog.
Settings like show seconds and date are more important than using a custom font for the clock.
Differential Revision: https://phabricator.kde.org/D7633
Summary:
When the service is regsitered we want to have all the internal routing
pre-configured. Otherwise pending calls (such as pending DBus activated
calls) can be processed before the path is registered and then fail with
an error that the path does not exist.
Also remove the fairly redundant check on registerObject. That can return
false if some object in this process has registered itself on that path; but in that
case, the very last thing we'd want to do is call unregisterService.
Test Plan:
Generated a load of notifications
Started plasma
Ouptut showed valid return on GetCapabilities, not an error on missing path
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7596
This will route the event through the containment first which can then intercept it, e.g. to prevent
Escape from exiting showing desktop while renaming where it should only cancel that.
CCBUG: 352988
Differential Revision: https://phabricator.kde.org/D7630
This allows the config UI to know when to enable the Apply button.
Currently we only do that when the shortcut or actions themselves change but not their configuration.
Differential Revision: https://phabricator.kde.org/D6443
This replaces the loop with fixed values by an Instantiator creating bindings on the model.
CCBUG: 372090
Differential Revision: https://phabricator.kde.org/D7603
Summary:
There's no reason to have different behaviour depending on whether the
UI is presented in an applet or not.
Test Plan: Looked in qdbusviewer
Reviewers: #plasma
Subscribers: graesslin, heikobecker, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7536
Summary:
QDBusConnection::serviceOwnerChanged is deprecated, with the intended
replacement being QDBusServiceWatcher. QDBusServiceWatcher only creates
a match rule for the relevant services, resulting in less noise and
wakeups.
(practically this has no impact as the the system tray also connects to
watch every service change, and that runs in the same process)
Test Plan:
Ran appmenu
Had dolphin open showing the menu
Closed dolphin
menu immediately closed
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7611
Summary:
In any place we look up a KService, check if it has a menuId,
and then generate KAStats-style applications: URL with it. Also
learn how to handle applications: URLs.
This was requested by Kai in D7203. His patch makes Kate
dynamically add its sessions as jump list actions to a copy of its
.desktop file in $HOME. As the library would generate the absolute
path to a .desktop file e.g. in /usr as launcher URL before, the
TM applet would ignore the overriding copy in $HOME and the actions
wouldn't be found.
This patch won't rewrite existing config, but LauncherTasksModel
will resolve the absolute path to the applications: URL as it goes
through TaskTools, and then return that. The window and startup
tasks models produce those URLs, too, so things match up. Newly-
added launchers will then store the applications: URL in config
directly.
Moving away from storing absolute paths when we can is also nice
in case there is a $HOME .desktop file at the time a launcher is
added which later gets deleted. Using the new storage format, we
will now fall back to a system file instead.
Note the conservative approach taken: We only generate an
applications: URL when the service returns something for menuId().
We don't use KService::storageId() here, which can fall back to
KService::entryPath() - in this case we're better off just using
the absolute path we already have. We still use storageId() when
generating the applications: URL for KAStats db insertions, as
that is more liberal (and matches Kicker).
It makes sense to look at the Kicker backend code to see if should
store applications: URLs (which it already produces to insert into
KAStats) as well.
This will need a subsequent patch to the Task Manager applet to
handle applications: URLs there in code that consumes launcher URLs
to parse things out of .desktop files.
Contains other minor cleanup and fixes, such as porting the
LauncherTasksModel to use TaskTools::runApp (which now understands
preferred: URLs as well), a fix for a small logic error there (the
&& before the !isApplication should have been ||, now moot), and
not needlessly opening and parsing a .desktop file in
TaskTools::appDataFromUrl.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7561
Plasma doesn't use any cln code directly, only via libqalculate. In version 2.0, libqalculate dropped cln in favor of gmp, so the cln dependency
becomes unnecessary.
Differential Revision: https://phabricator.kde.org/D7590
Creating one from an empty string prints a warning and here we don't actually need
a fully-fledged QDBusObjectPath, we can just compare strings.
BUG: 383557
Differential Revision: https://phabricator.kde.org/D7538
We have a custom compact representation anyway.
All it does is change the tooltip icon but more importantly break the notification icon in System Tray settings.
BUG: 375093
FIXED-IN: 5.11.0
Differential Revision: https://phabricator.kde.org/D7542
Kai Uwe Broulik
Jonathan Riddell
l10n daemon script
Marco Martin
Antonio Rojas
Eike Hein
Pino Toscano
David Edmundson