The model has changed and is now created in JS but the code that changes the shortcuts was never adjusted
Differential Revision: https://phabricator.kde.org/D1567
Summary:
Currently we leak an IconLoader for each icon for the time the system
tray is in memory.
An app may also load icons from their own directories, so we need a new
iconloader that takes this into account
This is wrapped into a subclass of iconengine so the iconloader lifespan
matches the icon object
Reviewers: #plasma
Subscribers: plasma-devel
Projects: #plasma
Differential Revision: https://phabricator.kde.org/D1498
it's way simpler and more reliable than using it trough ObjectModel
ObjectModel seems good enough if items are always owned by one
but not when going back and forth between 2 models
Current usage of QDBusServiceWatcher is not a intended feature and will
be removed in Qt 5.6 (see https://bugreports.qt.io/browse/QTBUG-51683 ).
Use the old fashioned QDBusConnectionInterface::serviceOwnerChanged to
implement the same thing.
REVIEW: 127285
something really wrong is going on on the proxymodel updates
the wrong item gets removed from the list.
it may be a wrong mapping between source and dest model
(doesn't seem so)
or may have been some misguided attempt by QML to recycle delegates
anyways resetting the model in some conditions even if expensive
seems to be the only way to workaround this.
Anyways this systray implementation is beyond any repair and
the rewritten version won't have to rely on so many models
and proxymodels
BUG:357627
CCBUG:352055
something really wrong is going on on the proxymodel updates
the wrong item gets removed from the list.
it may be a wrong mapping between source and dest model
(doesn't seem so)
or may have been some misguided attempt by QML to recycle delegates
anyways resetting the model in some conditions even if expensive
seems to be the only way to workaround this.
Anyways this systray implementation is beyond any repair and
the rewritten version won't have to rely on so many models
and proxymodels
BUG:357627
CCBUG:352055
As in "panel options" when systray is in the panel.
Only one of the formerly two (see
https://git.reviewboard.kde.org/r/125973/) methods did this, so I think
it's safe to remove from the one I'm keeping.
REVIEW: 125972
Remove almost completely duplicated function.
One was used for right clicking on expanded items, the other for full
compact items.
A missing action for expanded items is added so the two menus are now
consistent.
Global co-ordinates are used as args for menus everywhere so we can
share the mapping code SNIs currently use.
REVIEW: 125973
Kai Uwe Broulik
David Edmundson
Aleix Pol
David Rosca
Marco Martin
l10n daemon script
Eike Hein
Ivan Čukić
Weng Xuetian
David Edmundson