This contains the actual name of the desktop file which might be different from the one the application got built with.
Differential Revision: https://phabricator.kde.org/D22506
Summary:
QQC2 StackView has a major behavioural difference
QQuickStackViewPrivate::setCurrentItem
item->setFocus(true);
This as a general rule makes sense, especially if you're pushing a whole
focus scope onto the stackView, it would automatically select the right
element. However as our base was not a focus scope the
SessionManagementScreen instance itself got focus, taking it away from
the child password box.
LockScreenUi has to be changed so that it sets the initial focus the
same even though the stackview is on QQC1.
Test Plan:
qmlscene in the sddm-theme directory with the dummydata setup
locked the screen regularly
Lots of gammaray
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: davidre, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25261
Summary:
This removes hacks and does things in a cleaner way.
Credits go to @broulik.
Reviewers: #plasma, broulik, ngraham
Reviewed By: ngraham
Subscribers: ngraham, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25614
When e.g. connecting to a network with captive portal, it leaves you sitting there wondering what's going on.
The notification won't time out until it becomes visible again but still there's been complaints that the notifications go missing.
This patch makes them move out of the way vertically.
It is pretty crude but covers the majority ("System Tray covers notifications") case.
Differential Revision: https://phabricator.kde.org/D25566
Summary:
support the automatic shadow hint
When the hint is shadowedBackground, do an automatic shadow with a shader, and
change applet's color to complementary
Test Plan:
Tested the functionality on various applets. To test, the digital clock is enabling explicitly background configurability
{F7788553}
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25591
Summary:
For each tray icon XEmbedSNIProxy is creating container window 32x32 in size. It is black with opaque set to 0 (fully transparent when compositor is enabled). All of these container windows are stacked below all windows, so normally you can't see them. On creation all container windows are created in top-left corner. When user clicks on the tray icon, container window is moved to the click location (to handle events correctly).
On KWin restart all windows are shuffled, usually KWin is able to restore ordering correctly, but for some reason not it this case. As a result black/transparent container windows are stacked above all other windows and panels.
To solve that, on KWin restart, XembedSNIProxy needs to iterate over all known container windows and stack them below again.
BUG: 357443
Test Plan:
1. [Optional] Disable compositor - with disable container window is black and easier to spot
2. Run any application with XEmbed system tray icon, do not click on the icon
3. Restart KWin
a) Before: black/transparent rectangle in the top-left corner, reacts to mouse click
b) After: no rectangle, mouse clicks work as expected
Reviewers: #plasma_workspaces, #plasma, davidedmundson
Reviewed By: #plasma_workspaces, #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25603
Summary:
If available, always use 32-bit color. We don't need Composite extension to handle transparency - all client windows are our children and transparency in handled in QML, inside the panel (so no need to composite real windows).
BUG: 356937
FIXED-IN: 5.17.1
Test Plan:
Disable compositor, run:
- pidgin (make sure pidgin-libnotify is NOT installed)
- keepassx
- xchat
- liferea
Before changes: black backgroud
After changes: transparent background
Reviewers: davidedmundson, #plasma_workspaces, #plasma
Reviewed By: davidedmundson, #plasma_workspaces, #plasma
Subscribers: mlaurent, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24530
Summary:
This is full of mixed bindings/signal handlers for properties and of
broken references in here!
There's likely more to do, but those were the most obvious ones when
working on the screenlocker KCM.
Reviewers: #plasma, mart, davidedmundson, crossi, bport
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25567
Summary:
`TaskGroupingProxyModel::requestToggleMaximized` now uses this to
minimize and restore groups of windows while preserving the
stacking order, a frequently user-requested wish.
BUG:368867
Window activation is additionally tracked to implement a new front-
end feature to activate the most recently active window (or fall
through to stacking order otherwise) subsequently.
CCBUG:370258
A Wayland implementation requires the addition of a
`PlasmaWindowManagement::stackingOrder()`, which should be a QList
of PlasmaWindow* in stacking order, along with a change signal. We
discussed this at the Plasma+KWin sprint and I'll code up patches
to KWin and KWayland soon and then implement the new API in here.
Reviewers: #plasma
Subscribers: davidedmundson, pino, anthonyfieroni, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22053
Summary:
BUG: 414399
FIXED-IN: 5.18
Test Plan:
1. Lock screen
2. type something in the password field
3. Close lid/suspend system
4. Reopen Lid
Before:
Password text is kept as in step 2
After:
Password text is empty
Reviewers: #plasma, broulik, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25487
Summary:
Currently the avatar in the logout screen is noticeably smaller than the avatar in the lock and logout screens.
This patch roughly bases the size value on what is produced in the lock and logout, and then applies it to the logout screen.
Test Plan:
Before (logout screen):
{F7680624}
After (logout screen):
{F7680632}
Before (lock screen):
{F7680634}
After (lock screen):
{F7680635}
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: davidedmundson, ngraham, plasma-devel
Tags: #plasma
Maniphest Tasks: T11093
Differential Revision: https://phabricator.kde.org/D25024
Summary:
The file path of the main script is hard-coded to ui/main.qml, so setting
X-Plasma-MainScript is pointless.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25201
In b7b25010aa the import line was changed
but nothing else was, causing errors in QML loading which ultimately
prevented SDDM from loading the theme.
BUG: 414252
CCMAIL: i@guoyunhe.me
Summary: Lower QQC2 version to minimum requirement. Add context to i18nc function. Cannot use `i18ncp` because the number isn't integer.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25319
Summary:
The TableView in digital clock widget time zone configuration is replaced with ListView. Other UI didn't change.
{F7635385}
Reviewers: #plasma, #plasma_workspaces, ngraham
Reviewed By: ngraham
Subscribers: GB_2, ahiemstra, broulik, kmaterka, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24798
Summary:
Most group have icons, this one did not. A new icon just got created for
all applications, it makes sense to be consistent.
This has no effect in the kicker-dash as that does not show icons, nor
kicker/kickoff as they don't show the all applications group.
Only third party menus will be affected.
Test Plan:
Looked at my custom menu
Looked at kicker-dash
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25294
Summary:
QQC2 StackView has a major behavioural difference
QQuickStackViewPrivate::setCurrentItem
item->setFocus(true);
This as a general rule makes sense, especially if you're pushing a whole
focus scope onto the stackView, it would automatically select the right
element. However as our base was not a focus scope the
SessionManagementScreen instance itself got focus, taking it away from
the child password box.
LockScreenUi has to be changed so that it sets the initial focus the
same even though the stackview is on QQC1.
Test Plan:
qmlscene in the sddm-theme directory with the dummydata setup
locked the screen regularly
Lots of gammaray
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: davidre, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25261
Summary:
When we load and position the Image the height is constrained, the width
is not. The image fillMode is set as PreserveAspectFit so the width
will adjust to fit the aspect ratio,
Therefore we only want to set a fixed height on the sourceSize, it will
automatically match the resultant width.
BUG: 413087
FIXED-IN: 5.17.3
Test Plan:
I was unable to reproduce the state.
Patch is based on reading the code and docs
Reviewers: #plasma, broulik, ngraham
Reviewed By: #plasma, broulik, ngraham
Subscribers: broulik, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25252