Summary:
Changes the button in the wallpaper chooser marked "Open..." to say "Add Image..". This matches the text style for the button in slideshow mode, which says, "Add Folder"
Also added ellipses to "Add Folder"; it's now "Add Folder..."
Test Plan:
Tested in KDE Neon.
Before:
{F5473479}
After:
{F5473507}
Reviewers: #plasma, broulik, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: aspotashev, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8658
Summary:
BUG: 345940
Move the "Enable Power Management" checkbox to the top of the window to match other applets (bluetooth, network)
Reviewers: #plasma_workspaces, broulik, mck182, davidedmundson, mart
Reviewed By: #plasma_workspaces, davidedmundson, mart
Subscribers: mart, jensreuterberg, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8607
remove invalid and superfluous markup <qt> + </qt> in kcfg file
add TranslationSystem=kde in kcfgc file to generate i18n() calls at build time for these tooltips
using the catalog klipper defined with setApplicationDomain
Differential Revision: https://phabricator.kde.org/D8453
Summary:
AFAICS the only other user for the engine (other than the applet I'm
porting) is the runner for KRunner, where links don't work anyway.
Port to QRegularExpression while at it.
Test Plan: Tested with the upcoming dict applet.
Reviewers: #plasma, davidedmundson, broulik, mart
Reviewed By: #plasma, mart
Subscribers: ngraham, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8534
Summary:
This was tricky bug to track down, needed to add debug statements in
literally every functions.
The flow of events is something like this, At startup:
- We don't have information about actual brightness for few seconds
- In this period, brightness slider have default value of 1
- This triggers the function which sets batterymonitor.screenBrightness
- onScreenBrightnessChanged gets called, which sets the actual
brightness
- onScreenBrightnessChanged have a guard for disableBrightnessUpdate but
since we have it marked as false initially, we proceed to set actual
brightness to 1
- However before we set value of brightness to 1, we do get actual
brightness back from dataengine, and our call overrides it to 1 later.
- On desktop we do get 2nd dataChanged event from somewhere, so
brightness is proper, but on mobile that is not case and results in
brightness staying at 1.
To fix this bug, we set disableBrightnessUpdate true at startup, and
when there is actual brightness change from powerdevil or
powermanagement engine, Logic.js takes care of enabling and disabling
brightness change.
(I quite like the boolean trap there in variable name :P .. will fix in
another change in master)
Test Plan:
Tested on desktop and mobile, verified that
- Brightness keys work
- Brightness slider works
- Scroll to change brightness works
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8462
Summary:
Instead of returning "<dl>\n<dt><b></b></dt>\n<dd></dl>"
when the word doesn't exist, return a proper readable string so users
know that the lookup is done and nothing was found.
Test Plan: I'm porting the dict applet to QtQuick, review request coming soon.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: broulik, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8419
Summary: BUG: 381174
Test Plan:
Had debug in QtWayland
Clicked on systray
Had parent, menu was in the right position
Reviewers: #plasma, mart, graesslin
Reviewed By: #plasma, mart, graesslin
Subscribers: apol, graesslin, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8338
This way when a third party like pinning or dragging from Kickoff sends an absolute desktop file
path we would still only store the application id if possible.
CCBUG: 385594
Differential Revision: https://phabricator.kde.org/D8260
Aleix Pol
Jonathan Riddell
Nathaniel Graham
l10n daemon script
David Faure
Kai Uwe Broulik
Burkhard Lück
Christoph Feck
Алексей Шилин
Bhushan Shah
David Edmundson
Guo Yunhe
Andrius Štikonas