Summary:
In the lock screen, pressing the enter key while the UI is not yet
visible ends up trying to unlock (and would usually fail because the
password field is empty).
Ensure that the UI is visible before unlocking.
BUG: 395671
Test Plan:
Lock the session, press enter. The UI should appear without any
"Unlocking failed" message.
Reviewers: #plasma, #vdg, ngraham, davidedmundson
Reviewed By: #plasma, #vdg, ngraham, davidedmundson
Subscribers: ngraham, davidedmundson, abetts, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16219
The setting was supposed to be disabled when global menu service was unavailable.
However, the service is now autostarted based on whether there is a global menu "view" available.
The property got removed but forgotten here.
Differential Revision: https://phabricator.kde.org/D16149
Summary:
ksmserver autostart had a system where processes, such as plasma, could
block the startup phase from moving on.
It is currently entirely unused.
It's very difficult to use properly, plasmashell has to block startup
before ksmserver moves on to phase 1. Racey at best.
I did hack it to work, and it does make a surprising positive
improvement to bootup. Worth exploring the idea properly, but implemented
better.
We should be able to get the same results by
blocking and waiting for the DBus name in the autostart desktop file to
become registered rather than having a ksmserver-specific solution.
Test Plan: Compiles, can still login
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16042
Summary:
In response to the question in the TODO being removed:
No. KDBusService does it later
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16040
Summary:
kcheckrunning is only used by startkde, it shouldn't be in the ksmserver
folder.
No code or behavioural changes, just tidying.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15202
Previously it would use an on-disk KImageCache which would never be invalidated.
Moreover, it just uses KIO::PreviewJob which does its own more clever (compares mtime and other properties) on-disk caching already.
It is using its own QCache rather than QPixmapCache to not jeopardize other caching for the potentially large wallpaper thumbnails
that are only relevant while the dialog is open.
BUG: 395447
FIXED-IN: 5.15.0
Differential Revision: https://phabricator.kde.org/D16095
Summary: "Login" is a noun: "I have a login for the system." This is not appropriate for a button title that is used as an action; the correct verb-based string is "Log In".
Test Plan: {F6311398}
Reviewers: #vdg, #plasma, abetts
Reviewed By: #vdg, abetts
Subscribers: abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16035
Summary:
When unmounting a removable device from dolphin, the device notifier
will popup saying the device can now be safely removed. But the popup
never auto-hides.
Test Plan:
Plug a USB pen drive
Unmount it from dolpin
Device notifier should popup and hide itself after 3 seconds
Reviewers: #plasma, #vdg, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16045
org.kde.slideshow is duplicated at compile time, so translations aren't extracted for it.
Setting an explicit domain fixes that.
Differential Revision: https://phabricator.kde.org/D16037
Summary:
An entry from the moz_places db may have several referring entries
in the moz_bookmarks db, i.e. where moz_places.id = moz_bookmarks.fk.
One of these entries is the "main" entry, while the other ones are used
for tags. Only the main entry has a title, while the others have not.
The tag entries have the same type as the main entry, even the parents
have the same type (folder).
Another source for duplicate URLs are manually created bookmarks, e.g.
in different folders. These may have the same or different titles.
To remove these duplicates, merge all entries with the same URL. If a
URL has multiple entries, keep all with distinct titles, otherwise keep
at least one - a bookmark may have an empty title.
See also T9626
Test Plan:
- Create a bookmark
- Add one or more tags
- Open FFs bookmarks sidebar
- Copy and paste the new entry
- Copy and paste the new entry again, change its title
Search for the new bookmark. It should appear exactly twice, once
with the original title, once with the modified one.
Without patch, it appears 3 times, plus once more for each tag.
Caveat: The bookmarks db has to be checkpointed to make the new
entries visible in the main DB file. To force checkpointing, execute:
$> sqlite3 -column -header ~/.mozilla/firefox/*.default/places.sqlite "PRAGMA wal_checkpoint"
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, davidedmundson, zzag, ngraham, plasma-devel
Tags: #plasma
Maniphest Tasks: T9626
Differential Revision: https://phabricator.kde.org/D15357
Summary:
Each notification was created as new datasource, and was newer removed
as long as the engine exists. This is especially bad for long living
applets like the device notifier. As there can only be one notification
per device (the last error state, or none), use the UDI as source name
and update the contents.
Also cancel (remove source) an old notifications in case of a successful
setup, otherwise old error messages are shown in the device notifier.
Test Plan:
in Dolphin, select "Release" (context menu) for a mounted CD
-> Notification in device notifier appears "Device can be safely removed"
remount without ejecting
-> Notification message is removed, device shows "mounted" emblem.
Without the change, the message stayed and the device kept the notification
emblem "(!)".
Reviewers: #frameworks, broulik
Reviewed By: broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15892
Summary:
"Shutdown" is a noun ("The nuclear reactor is experiencing a shutdown!")
"Shut Down" is an imperative command with a verb ("Shut down the nuclear reactor!"), which is how everything else is phrased.
Test Plan:
- Login screen button now says "Shut Down"
- Searching for "shut down" in KRunner brings up the appropriate option ("shutdown" still works too)
- KRunner says, "Shut down the computer"
Reviewers: #vdg, #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15878
Summary:
KSmserver is currently very heavily tied to the shutdown prompt dialog.
On upgrades a user ends up in a situation where they have an old
ksmserver running but a newer shutdown dialog. This has caused issues
repeatedly in the past.
I want to make some changes to how the shutdown prompt is shown for
5.15. First step is making the old releases more robust.
Prompt looks ugly but a user will only see it at most once. Hopefully
never.
Test Plan:
rm'd the greeter
Got an ugly messagebox instead of nothing
Reviewers: #plasma, broulik, ngraham
Reviewed By: #plasma, broulik
Subscribers: ngraham, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15869
Summary:
QDBusInterface is a blocking call that calls introspect. We don't need
to introspect.
As this is called on startup this call starts kuiserver, which means
plasma is blocked whilst a whole process spawns, this is a lot worse
than just a regular, ~100ms on my system
Also using the generated versions is generally neater to read.
Test Plan:
Restarted plasmashell
Copied a file
Still had a spinny wheel
Q_DBUS_BLOCKING_CALL_MAIN_THREAD_WARNING_MS=0 doesn't list kuiserver
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15815
Summary:
10 seconds isn't the best default value for slideshows. 15 minutes is more reasonable, and easier on battery life for laptops, too.
For comparison: macOS and Windows both default to 30 minutes.
Test Plan: {F6287038}
Reviewers: #plasma, broulik, mart, #vdg, abetts, davidedmundson
Reviewed By: #plasma, #vdg, abetts, davidedmundson
Subscribers: abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15785
In QtQuick Controls 2 (Plasma Components 3) there's separate signals for when the slider's value
changes "on its own" or by explicit user interaction. Pressing a keyboard shortcut changes the
value but doesn't cause the move signal to be emitted. Do this explicitly now.
Summary:
Shows tooltips for buttons left and right of the search box.
FEATURE: 398943
{F6284809}
Test Plan: Manually test appearance of tooltips, unlikely to cause new issues.
Reviewers: #vdg, acrouthamel, ngraham
Reviewed By: #vdg, acrouthamel, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15749
Summary:
When a Solid device is removed (e.g. a CD is ejected) the notifier tries
to read the attributes although the Source for the UDI has just vanished.
Fixes several QML error messages, i.e. "TypeError: Cannot read property
'...' of undefined" and "Unable to assign [undefined] to QString".
Apparently these errors also have the effect of items showing outdated
state, i.e. optical media still being shown after ejecting it.
CCBUG: 394348
Test Plan:
1. insert optical medium
2. eject
Without the changes, the item was stuck
Now, the item is removed as soon as the medium is ejected
Also, no more errors are logged for the devicenotifier
Reviewers: #frameworks, broulik
Reviewed By: broulik
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15687
Thomas Surrel
l10n daemon script
Jonathan Riddell
Antonio Rojas
Kai Uwe Broulik
Laurent Montel
David Edmundson
Nathaniel Graham
Chris Holland
Stefan Brüns
Silas Lenz