Summary:
This patch removes some spacing which was making the 'switch users' button get slightly cut off on small displays (1366x768). Quite a few old laptops have screens of this size, so it is good to take into account that display size as well, as long as it doesn't negatively affect the appearance for large displays.
BUG: 410801
FIXED-IN: 5.17.0
Test Plan:
Lock screen when connected to a low-res display and check that the 'switch users' button isn't cut off.
**Before this patch:**
Lockscreen on small display (1366x768): {F7330101}
Lockscreen on big display (1920x1080): {F7330096}
**After this patch:**
Lockscreen on small display (1366x768): {F7342190}
Lockscreen on big display (1920x1080): {F7342191}
Reviewers: #plasma, #vdg, ngraham, filipf
Reviewed By: #vdg, ngraham, filipf
Subscribers: filipf, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23786
Summary:
@mart dislikes idea of manually ordering the systray (D11233, D11292) but prefers auto
ordering instead. To make my opinion I hacked up this and started testing on myself.
Current version breaks if two items have the same category and text (I guess this
should not happen but...).
Note that category order is more or less randomly chosen (I do believe someone else
has an opinion what the correct order is).
This is mutually exclusive with D11292.
Reviewers: #vdg, #plasma, mart, ngraham
Reviewed By: #vdg, #plasma, mart, ngraham
Subscribers: kmaterka, ognarb, ngraham, wsdfhjxc, mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11352
Summary:
There are two proposed justifications for this addition:
- In general, VDG would like to move towards consistently using the Meta key for global shortcuts
- Switching macOS users will be able to activate KRunner with the exact same keyboard shortcut they used to activate Spotlight
Reviewers: #vdg, #plasma, ndavis, GB_2
Reviewed By: #vdg, ndavis, GB_2
Subscribers: GB_2, romangg, ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24033
Summary:
TL;DR version: whenever you currently would be taken to a session switcher page where the only possible action is to go to SDDM and start a new session, instead just show SDDM immediately instead.
Currently, the session switcher screen suffers from a few UX problems:
- There's a fake "start new session" item that looks like a button but isn't clickable
- Asking to switch users always goes to the screen where you can switch to existing sessions even if there are no existing sessions to switch to, which is an unnecessary extra step
This patch aims to solve those problems in the following ways:
- Don't show a fake "start new session" item in the Breeze theme; instead add a real button in the UI to do this
- When asked to show the session management screen and there is only one session so the on;y thing you could do on that screen is create another session, instead just go to session creation directly
- For themes where the fake "start new session" button is shown, use a better icon that doesn't make it look like a clickable button
BUG: 386361
FIXED-IN: 5.17.0
Depends on D23279
Test Plan:
1. Have only one session > Kickoff/Kicker/dash/Krunner > Switch User -> you go directly to SDDM where you can start a new session
2. Start a new session, then Switch user again -> you go to the session management screen where you can switch to the other session, or start a new one
Videos:
Clicking "Switch User" when there are no other sessions: {F7264475}
Clicking "Switch User" when there is another session to switch to, and then switching to it: {F7264476}
Clicking "Switch User" when there is another session to switch to, and then starting a new session: {F7264480}
Switching between multiple sessions in the session switcher: {F7264483}
If the fake "New Session" item is shown (e.g in other themes), here's what it now looks like: {F7264485}
Reviewers: #plasma, #vdg, GB_2, mart
Reviewed By: #plasma, #vdg, GB_2, mart
Subscribers: GB_2, gregormi, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23283
The Switch Window popup menu originally numbered the desktops starting
from 0, in contrast to the KWin and Task Manager menus which start
from 1. Adjust the Switch Window numbering to start from 1 also.
Do not use the internal desktop ID for this, on X11 it is indeed the
1-based desktop number but on Wayland it is a UUID string.
BUG:410190
Differential Revision: https://phabricator.kde.org/D22740
A job instance is created as soon as the job starts but it might not be shown to the user right away or at all.
JobPrivate::prettyDestUrl() already creates the KFilePlacesModel if needed, no need to do it in the constructor.
Differential Revision: https://phabricator.kde.org/D23983
Currently, a notification is considered "unread" when it was created or updated after the last time the user opened the history.
To alleviate this, when the notification popup is hovered, e.g. because the user wanted to drag an image out, select some text,
or open the "More" menu, it is considered read. It will still end up in the history but will not needlessly show the "unread notification" bell icon.
Moreover, job finished notifications are always considered read, as they are either from long-standing jobs which the user is likely aware of,
or confirmation of short tasks the user doesn't need explicit confirmation about. For example, extracting an archive in Dolphin,
I get an "Extracting (Finished)" but I don't want to explicitly acknowledge that notification because I can just enter the folder that was just created in Dolphin.
This surely doesn't fix the underlying problem of notification expiration and history, and the user might just interact wiht some
tray icons or the clock and not actually deal with the notification popup but this is imho an acceptable stopgap until a proper
solution is found, which won't happen in time for Plasma 5.17 anyway.
Differential Revision: https://phabricator.kde.org/D23977
Summary: It got lost during the porting to native executables
Test Plan:
Set KDEWM=awesome, successfully started a new Plasma
session with it, unset it again and kwin is started in the next
session.
Reviewers: #plasma, apol, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23910
Summary: {F7331506}
Test Plan: Open Kicker and open the context menu for a menu item.
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23793
Summary:
Use the new icon added in D22155.
{F6948276}
{F6948277}
Test Plan: Open the desktop context menu and also search for "activity" in KRunner.
Reviewers: #plasma, #vdg, ndavis
Reviewed By: #vdg, ndavis
Subscribers: #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22167
Summary: Load only once and share
Test Plan: Restarted. Also made a small test app that I'll submit once this is in as it depends.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23719
Laurent Montel
David Faure
Kai Uwe Broulik
l10n daemon script
Nate Graham
Kishore Gopalakrishnan
Radek Hušek
Heiko Becker
Bhushan Shah
Jonathan Riddell
Marco Martin
Jonathan Marten
Aleix Pol
Luca Beltrame
Guo Yunhe
Björn Feber
Nicolas Fella